Skip to content

Conversation

@fanquake
Copy link
Member

Includes bitcoin-core/leveldb-subtree#41 which is used in #30234.

fanquake added 2 commits June 13, 2024 13:17
688561cba8 Merge bitcoin-core/leveldb-subtree#41: Ignore clang's self-assignment check
7045a90ed7 Ignore clang's self-assignment check

git-subtree-dir: src/leveldb
git-subtree-split: 688561cba8746482893f835c4829e4eb4a5b7615
@DrahtBot
Copy link
Contributor

DrahtBot commented Jun 13, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK theuni

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #30234 (Enable clang-tidy checks for self-assignment by theuni)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@fanquake fanquake requested a review from theuni June 13, 2024 13:18
Copy link
Member

@theuni theuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 95812d9

@fanquake fanquake merged commit 0b94fb8 into bitcoin:master Jun 14, 2024
@fanquake fanquake deleted the leveldb_subtree_update branch June 14, 2024 10:26
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Oct 30, 2024
a37778d Squashed 'src/leveldb/' changes from e2f10b4e47..688561cba8 (fanquake)

Pull request description:

  Includes bitcoin-core/leveldb-subtree#41 which is used in bitcoin#30234.

ACKs for top commit:
  theuni:
    utACK 95812d9

Tree-SHA512: 3d943695a3d33816cf5558b183f5629aa92a500a1544eecedf84952e93c8592a8cf0d554b88281fc0bad3c9e920ebcff1ed8edc12f8e73f36ed5335482beb829
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Feb 20, 2025
a37778d Squashed 'src/leveldb/' changes from e2f10b4e47..688561cba8 (fanquake)

Pull request description:

  Includes bitcoin-core/leveldb-subtree#41 which is used in bitcoin#30234.

ACKs for top commit:
  theuni:
    utACK 95812d9

Tree-SHA512: 3d943695a3d33816cf5558b183f5629aa92a500a1544eecedf84952e93c8592a8cf0d554b88281fc0bad3c9e920ebcff1ed8edc12f8e73f36ed5335482beb829
PastaPastaPasta added a commit to dashpay/dash that referenced this pull request Feb 21, 2025
c34e7ab Merge bitcoin#30534: guix: move bison from global scope, to Linux (merge-script)
da11d29 Merge bitcoin#30282: Revert "contrib: macdeploy: monkey-patch gen-sdk to be deterministic" (merge-script)
20bcee8 Merge bitcoin#30281: Update leveldb subtree to latest upstream (merge-script)
a74b1e2 Merge bitcoin#30253: refactor: performance-for-range-copy in psbt.h (merge-script)
2ea479f Merge bitcoin#29650: depends: drop 1 Qt determinism patch (fanquake)
6506f52 Merge bitcoin#28833: wallet: refactor: remove unused `SignatureData` instances in spkm's `FillPSBT` methods (Ava Chow)
6235590 Merge bitcoin#29213: doc, test: test and explain service flag handling (Ava Chow)
34bbe69 Merge bitcoin#28965: guix: remove input labels (fanquake)
490b390 Merge bitcoin#28859: guix: update signapple (drop macho & altgraph) (fanquake)
a12ad80 Merge bitcoin#28325: test: wallet_backup.py, fix intermittent failure in "restore using dumped wallet" (fanquake)
15f8b74 Merge bitcoin#27779: guix: remove cURL from build env (fanquake)
1289d32 Merge bitcoin#27801: wallet: Add tracing for sqlite statements (fanquake)
ba3aff7 Merge bitcoin-core/gui#729: test: Add missed header (Hennadii Stepanov)
536a265 Merge bitcoin#27209: ci: Remove unused EXPECTED_TESTS_DURATION_IN_SECONDS env var (glozow)
f2caccd Merge bitcoin#27174: ci: bump lint task to bookworm for git v2.38 (fanquake)
0be2932 Merge bitcoin#27009: validation: Skip VerifyDB checks of level >=3 if dbcache is too small (fanquake)

Pull request description:

  ## Issue being fixed or feature implemented
  Batch of trivial back ports

  ## What was done?

  ## How Has This Been Tested?
  Built locally; haven't reviewed commits yet.

  ## Breaking Changes

  ## Checklist:
    _Go over all the following points, and put an `x` in all the boxes that apply._
  - [ ] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  UdjinM6:
    utACK c34e7ab
  kwvg:
    utACK c34e7ab

Tree-SHA512: e20270e48273ad5fd5926e75b025fe69a70e698a82f0a11a1fa646c44a7affbd7a5f33eebcd7faa606e7adc2a888df141c660339d7240e6ed64f8525558215de
@bitcoin bitcoin locked and limited conversation to collaborators Jun 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants