wallet: refactor: remove unused SignatureData instances in spkm's FillPSBT methods
#28833
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
…methods These are filled with signature data from a PSBT input, but not used anywhere after, hence they can be removed.
148d663 to
e2ad343
Compare
brunoerg
left a comment
There was a problem hiding this comment.
crACK e2ad343
I checked that FillSignatureData only modifies FillSignatureData and does not affect anything from the PSBTInput itself. Since SignatureData instances are not used in spkm's FillPSBTmethods, makes sense to remove them. Also, FillSignatureData could return SignatureData instead of void.
|
ACK e2ad343 |
These are filled with signature data from a PSBT input, but not used anywhere after, hence they can be removed. Note that the same code is in the
SignPSBTInputfunction where thesigdataresult is indeed used.