Revert "contrib: macdeploy: monkey-patch gen-sdk to be deterministic" #30282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ba30a54.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
Member
|
cc @prusnak |
Contributor
Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use] |
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Feb 20, 2025
… to be deterministic" b03a45b Revert "contrib: macdeploy: monkey-patch gen-sdk to be deterministic" (fanquake) Pull request description: This reverts commit ba30a54. We no-longer support Python 3.8, so remove the monkey patching. ACKs for top commit: hebasto: ACK b03a45b, I have reviewed the code and it looks OK. Tree-SHA512: 5bf68c2b332f18a620a8a6f77812ed93afa988016847bec1d3b7355670301dc957442ac47191a0cb7c3fe607d902914fb00c96345c8170f2a64429638c00b3c4
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Feb 21, 2025
c34e7ab Merge bitcoin#30534: guix: move bison from global scope, to Linux (merge-script) da11d29 Merge bitcoin#30282: Revert "contrib: macdeploy: monkey-patch gen-sdk to be deterministic" (merge-script) 20bcee8 Merge bitcoin#30281: Update leveldb subtree to latest upstream (merge-script) a74b1e2 Merge bitcoin#30253: refactor: performance-for-range-copy in psbt.h (merge-script) 2ea479f Merge bitcoin#29650: depends: drop 1 Qt determinism patch (fanquake) 6506f52 Merge bitcoin#28833: wallet: refactor: remove unused `SignatureData` instances in spkm's `FillPSBT` methods (Ava Chow) 6235590 Merge bitcoin#29213: doc, test: test and explain service flag handling (Ava Chow) 34bbe69 Merge bitcoin#28965: guix: remove input labels (fanquake) 490b390 Merge bitcoin#28859: guix: update signapple (drop macho & altgraph) (fanquake) a12ad80 Merge bitcoin#28325: test: wallet_backup.py, fix intermittent failure in "restore using dumped wallet" (fanquake) 15f8b74 Merge bitcoin#27779: guix: remove cURL from build env (fanquake) 1289d32 Merge bitcoin#27801: wallet: Add tracing for sqlite statements (fanquake) ba3aff7 Merge bitcoin-core/gui#729: test: Add missed header (Hennadii Stepanov) 536a265 Merge bitcoin#27209: ci: Remove unused EXPECTED_TESTS_DURATION_IN_SECONDS env var (glozow) f2caccd Merge bitcoin#27174: ci: bump lint task to bookworm for git v2.38 (fanquake) 0be2932 Merge bitcoin#27009: validation: Skip VerifyDB checks of level >=3 if dbcache is too small (fanquake) Pull request description: ## Issue being fixed or feature implemented Batch of trivial back ports ## What was done? ## How Has This Been Tested? Built locally; haven't reviewed commits yet. ## Breaking Changes ## Checklist: _Go over all the following points, and put an `x` in all the boxes that apply._ - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: utACK c34e7ab kwvg: utACK c34e7ab Tree-SHA512: e20270e48273ad5fd5926e75b025fe69a70e698a82f0a11a1fa646c44a7affbd7a5f33eebcd7faa606e7adc2a888df141c660339d7240e6ed64f8525558215de
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ba30a54.
We no-longer support Python 3.8, so remove the monkey patching.