ci: bump lint task to bookworm for git v2.38 #27174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
hebasto
approved these changes
Feb 28, 2023
Member
hebasto
left a comment
There was a problem hiding this comment.
ACK 836720e366f61f23c7a56775e11d58890b002d75
maflcko
reviewed
Feb 28, 2023
836720e to
257dfef
Compare
Since 5497c14, verify-commits.py requires git merge-tree which is only available in git v2.38 or later.
Member
|
lgtm ACK 257dfef897db0ece387511d0592076381aaeff2b The title and commit message can be adjusted to |
257dfef to
a984bee
Compare
Member
Author
sorry, pushed again because commit message still said lunar |
Member
|
ACK a984bee |
hebasto
approved these changes
Feb 28, 2023
maflcko
approved these changes
Feb 28, 2023
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 1, 2023
a984bee [ci] change lint to bookworm for git v2.38 (glozow) Pull request description: Since 5497c14, verify-commits.py uses `git merge-tree` which requires git v2.38 or later. Fix the lint jobs on master (e.g. https://cirrus-ci.com/task/4971007513985024). ACKs for top commit: achow101: ACK a984bee hebasto: re-ACK a984bee Tree-SHA512: dd50598aefb6f9c86cf221dea27fcc521e335cb182f7a3abcb3215d3991794354085be3e07c133ab74ca8b957e3a6acc43722899165957b3d898867d6253ebdc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 5497c14, verify-commits.py uses
git merge-treewhich requires git v2.38 or later. Fix the lint jobs on master (e.g. https://cirrus-ci.com/task/4971007513985024).