Blowfish OFB Block Cipher Mode Support#2892
Merged
Conversation
36f8df2 to
af46416
Compare
ce1cdd7 to
c449e22
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2892 +/- ##
==========================================
+ Coverage 78.22% 78.26% +0.04%
==========================================
Files 683 683
Lines 117491 117604 +113
Branches 16510 16516 +6
==========================================
+ Hits 91909 92045 +136
+ Misses 24694 24674 -20
+ Partials 888 885 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c449e22 to
d3b6992
Compare
d3b6992 to
cb574c0
Compare
WillChilds-Klein
previously approved these changes
Dec 9, 2025
justsmth
reviewed
Dec 10, 2025
cb574c0 to
63e5800
Compare
63e5800 to
0896ab1
Compare
0896ab1 to
db77da6
Compare
justsmth
previously approved these changes
Dec 10, 2025
cfa6a5b to
38374c3
Compare
WillChilds-Klein
approved these changes
Dec 11, 2025
justsmth
approved these changes
Dec 11, 2025
justsmth
pushed a commit
that referenced
this pull request
Dec 12, 2025
## What's Changed * Add encap/decapKeyCheck support in ACVP by @samuel40791765 in #2872 * Clarify comments and API behaviour for equal-preference for TLS 1.3 by @torben-hansen in #2873 * Add support for external contexts in ML-DSA ACVP by @samuel40791765 in #2880 * Route ML-DSA ACVP to the right APIs by @samuel40791765 in #2884 * Add sha1 CLI by @nhatnghiho in #2885 * Fix openssl comparison tests by @justsmth in #2888 * tool-openssl: pkcs8 error output on decrypt by @justsmth in #2883 * Add RSA_X931_PADDING to rsa.h by @justsmth in #2889 * Bump urllib3 from 2.5.0 to 2.6.0 in /tests/ci by @dependabot[bot] in #2886 * Run ACCP integration tests on aarch64 by @WillChilds-Klein in #2894 * Blowfish OFB Block Cipher Mode Support by @skmcgrail in #2892 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
OPENSSL_NO_BFdefine when we re-added support for these decrepit algorithms.Testing:
There doesn't really appear to be much extensive OFB KATs available, so I've extended the current test data using the OpenSSL 1.1.1 APIs:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.