Skip to content

tool-openssl: pkcs8 error output on decrypt#2883

Merged
justsmth merged 2 commits intoaws:mainfrom
justsmth:pkcs8-error-decrypting-key
Dec 8, 2025
Merged

tool-openssl: pkcs8 error output on decrypt#2883
justsmth merged 2 commits intoaws:mainfrom
justsmth:pkcs8-error-decrypting-key

Conversation

@justsmth
Copy link
Copy Markdown
Contributor

@justsmth justsmth commented Dec 5, 2025

Description of changes:

Align error output of "openssl pkcs8" when handling encrypted keys.

Testing:

Added new test to prevent regression

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner December 5, 2025 22:35
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 84.31373% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.23%. Comparing base (7c02cb3) to head (c0ac3b7).
⚠️ Report is 50 commits behind head on main.

Files with missing lines Patch % Lines
tool-openssl/pkcs8.cc 77.14% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2883   +/-   ##
=======================================
  Coverage   78.23%   78.23%           
=======================================
  Files         683      683           
  Lines      117412   117462   +50     
  Branches    16500    16509    +9     
=======================================
+ Hits        91856    91899   +43     
- Misses      24668    24676    +8     
+ Partials      888      887    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth merged commit 3f7f005 into aws:main Dec 8, 2025
582 of 589 checks passed
@justsmth justsmth deleted the pkcs8-error-decrypting-key branch December 8, 2025 20:32
justsmth pushed a commit that referenced this pull request Dec 12, 2025
## What's Changed
* Add encap/decapKeyCheck support in ACVP by @samuel40791765 in
#2872
* Clarify comments and API behaviour for equal-preference for TLS 1.3 by
@torben-hansen in #2873
* Add support for external contexts in ML-DSA ACVP by @samuel40791765 in
#2880
* Route ML-DSA ACVP to the right APIs by @samuel40791765 in
#2884
* Add sha1 CLI by @nhatnghiho in #2885
* Fix openssl comparison tests by @justsmth in
#2888
* tool-openssl: pkcs8 error output on decrypt by @justsmth in
#2883
* Add RSA_X931_PADDING to rsa.h by @justsmth in
#2889
* Bump urllib3 from 2.5.0 to 2.6.0 in /tests/ci by @dependabot[bot] in
#2886
* Run ACCP integration tests on aarch64 by @WillChilds-Klein in
#2894
* Blowfish OFB Block Cipher Mode Support by @skmcgrail in
#2892

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants