Route ML-DSA ACVP to the right APIs#2884
Merged
samuel40791765 merged 2 commits intoaws:mainfrom Dec 6, 2025
Merged
Conversation
skmcgrail
previously approved these changes
Dec 5, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2884 +/- ##
==========================================
- Coverage 78.23% 78.22% -0.01%
==========================================
Files 683 683
Lines 117412 117416 +4
Branches 16500 16503 +3
==========================================
- Hits 91856 91854 -2
- Misses 24668 24674 +6
Partials 888 888 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WillChilds-Klein
approved these changes
Dec 6, 2025
skmcgrail
approved these changes
Dec 6, 2025
samuel40791765
added a commit
to samuel40791765/aws-lc
that referenced
this pull request
Dec 8, 2025
### Description of changes: The previous ML-DSA change weren't routing against the right APIs. This fixes that. Issues were mainly: 1. `extmu` is exclusive to `signatureInterface=internal`, but we were passing in false for `signatureInterface=external`. 2. `ml_dsa_*_sign` APIs are non-deterministic and we weren't passing in `rnd` as the random bytes. This routes the SignGen tests to the right places. ### Call-outs: N/A ### Testing: New ACVP demo vector, verified against expected outputs and added to this change. The new tests fail without the new changes made to ACVP. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. (cherry picked from commit 745d009)
justsmth
pushed a commit
that referenced
this pull request
Dec 12, 2025
## What's Changed * Add encap/decapKeyCheck support in ACVP by @samuel40791765 in #2872 * Clarify comments and API behaviour for equal-preference for TLS 1.3 by @torben-hansen in #2873 * Add support for external contexts in ML-DSA ACVP by @samuel40791765 in #2880 * Route ML-DSA ACVP to the right APIs by @samuel40791765 in #2884 * Add sha1 CLI by @nhatnghiho in #2885 * Fix openssl comparison tests by @justsmth in #2888 * tool-openssl: pkcs8 error output on decrypt by @justsmth in #2883 * Add RSA_X931_PADDING to rsa.h by @justsmth in #2889 * Bump urllib3 from 2.5.0 to 2.6.0 in /tests/ci by @dependabot[bot] in #2886 * Run ACCP integration tests on aarch64 by @WillChilds-Klein in #2894 * Blowfish OFB Block Cipher Mode Support by @skmcgrail in #2892 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
The previous ML-DSA change weren't routing against the right APIs. This fixes that.
Issues were mainly:
extmuis exclusive tosignatureInterface=internal, but we were passing in false forsignatureInterface=external.ml_dsa_*_signAPIs are non-deterministic and we weren't passing inrndas the random bytes. This routes the SignGen tests to the right places.Call-outs:
N/A
Testing:
New ACVP demo vector, verified against expected outputs and added to this change. The new tests fail without the new changes made to ACVP.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.