Clarify comments and API behaviour for equal-preference for TLS 1.3 #2873
Merged
torben-hansen merged 3 commits intoaws:mainfrom Dec 3, 2025
Merged
Clarify comments and API behaviour for equal-preference for TLS 1.3 #2873torben-hansen merged 3 commits intoaws:mainfrom
torben-hansen merged 3 commits intoaws:mainfrom
Conversation
…not possible for TLS 1.3
… configuration for TLS 1.3
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2873 +/- ##
==========================================
- Coverage 78.24% 78.24% -0.01%
==========================================
Files 683 683
Lines 117388 117389 +1
Branches 16497 16497
==========================================
- Hits 91853 91851 -2
Misses 24649 24649
- Partials 886 889 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
samuel40791765
approved these changes
Dec 2, 2025
WillChilds-Klein
approved these changes
Dec 3, 2025
justsmth
pushed a commit
that referenced
this pull request
Dec 12, 2025
## What's Changed * Add encap/decapKeyCheck support in ACVP by @samuel40791765 in #2872 * Clarify comments and API behaviour for equal-preference for TLS 1.3 by @torben-hansen in #2873 * Add support for external contexts in ML-DSA ACVP by @samuel40791765 in #2880 * Route ML-DSA ACVP to the right APIs by @samuel40791765 in #2884 * Add sha1 CLI by @nhatnghiho in #2885 * Fix openssl comparison tests by @justsmth in #2888 * tool-openssl: pkcs8 error output on decrypt by @justsmth in #2883 * Add RSA_X931_PADDING to rsa.h by @justsmth in #2889 * Bump urllib3 from 2.5.0 to 2.6.0 in /tests/ci by @dependabot[bot] in #2886 * Run ACCP integration tests on aarch64 by @WillChilds-Klein in #2894 * Blowfish OFB Block Cipher Mode Support by @skmcgrail in #2892 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
#2814
Description of changes:
The algorithm used to compute the negotiated cipher suite in TLS 1.3 is different than the one used for the older versions. Clarify what this means for equal-preference groups.
Call-outs:
There is some leftover work to do for this part of the negotiation implementation. Firstly, one can consider whether to consolidate the the negotiation algorithm for cipher suites over all TLS versions. Secondly, if not, how/if should one support
SSL_OP_CIPHER_SERVER_PREFERENCEas a condition, that is not applied in TLS 1.3 as described in #2814.Testing:
No code harmed, yet.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.