Skip to content

Fix openssl comparison tests#2888

Merged
justsmth merged 1 commit intoaws:mainfrom
justsmth:fix-openssl-comparison
Dec 8, 2025
Merged

Fix openssl comparison tests#2888
justsmth merged 1 commit intoaws:mainfrom
justsmth:fix-openssl-comparison

Conversation

@justsmth
Copy link
Copy Markdown
Contributor

@justsmth justsmth commented Dec 8, 2025

Description of changes:

  • Our "openssl" command output no longer strictly matches the output from Openssl's master branch.
  • Previously, due to how the variables were declared, we were only actually comparing our output to that of their master branch.

Testing:

We are only concerned about comparisons with OpenSSL v1.1.1 and v3.0. Updated to only compare against these two.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner December 8, 2025 14:21
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.22%. Comparing base (d6298ee) to head (a8ca812).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2888      +/-   ##
==========================================
- Coverage   78.22%   78.22%   -0.01%     
==========================================
  Files         683      683              
  Lines      117441   117441              
  Branches    16502    16501       -1     
==========================================
- Hits        91870    91867       -3     
- Misses      24683    24688       +5     
+ Partials      888      886       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth enabled auto-merge (squash) December 8, 2025 17:20
@justsmth justsmth merged commit 92ff0c5 into aws:main Dec 8, 2025
405 of 412 checks passed
justsmth pushed a commit that referenced this pull request Dec 12, 2025
## What's Changed
* Add encap/decapKeyCheck support in ACVP by @samuel40791765 in
#2872
* Clarify comments and API behaviour for equal-preference for TLS 1.3 by
@torben-hansen in #2873
* Add support for external contexts in ML-DSA ACVP by @samuel40791765 in
#2880
* Route ML-DSA ACVP to the right APIs by @samuel40791765 in
#2884
* Add sha1 CLI by @nhatnghiho in #2885
* Fix openssl comparison tests by @justsmth in
#2888
* tool-openssl: pkcs8 error output on decrypt by @justsmth in
#2883
* Add RSA_X931_PADDING to rsa.h by @justsmth in
#2889
* Bump urllib3 from 2.5.0 to 2.6.0 in /tests/ci by @dependabot[bot] in
#2886
* Run ACCP integration tests on aarch64 by @WillChilds-Klein in
#2894
* Blowfish OFB Block Cipher Mode Support by @skmcgrail in
#2892

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
@justsmth justsmth deleted the fix-openssl-comparison branch January 22, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants