Skip to content

Support "openssl dhparam"#2790

Merged
justsmth merged 4 commits intoaws:mainfrom
justsmth:tool-openssl-dhparam
Nov 3, 2025
Merged

Support "openssl dhparam"#2790
justsmth merged 4 commits intoaws:mainfrom
justsmth:tool-openssl-dhparam

Conversation

@justsmth
Copy link
Copy Markdown
Contributor

Issues:

Addresses #2764

Description of changes:

Add support for the "openssl dhparam" subcommand. It supports the -in, -out, -inform, -outform, -text, and -noout` options.

Testing

Adds tests for coverage.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth force-pushed the tool-openssl-dhparam branch from 492c941 to 8b810c5 Compare October 31, 2025 14:21
@justsmth justsmth force-pushed the tool-openssl-dhparam branch from 8b810c5 to bdfef2a Compare October 31, 2025 14:25
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 68.67089% with 99 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.49%. Comparing base (7e6ef7b) to head (bdfef2a).
⚠️ Report is 40 commits behind head on main.

Files with missing lines Patch % Lines
tool-openssl/dhparam_test.cc 57.52% 74 Missing and 5 partials ⚠️
tool-openssl/dhparam.cc 84.61% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2790      +/-   ##
==========================================
- Coverage   78.52%   78.49%   -0.03%     
==========================================
  Files         680      682       +2     
  Lines      115362   115678     +316     
  Branches    16329    16368      +39     
==========================================
+ Hits        90587    90806     +219     
- Misses      23979    24071      +92     
- Partials      796      801       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth changed the title [DRAFT] Support "openssl dhparam" Support "openssl dhparam" Oct 31, 2025
@justsmth justsmth marked this pull request as ready for review October 31, 2025 20:55
@justsmth justsmth requested a review from a team as a code owner October 31, 2025 20:55
@jakemas
Copy link
Copy Markdown
Contributor

jakemas commented Nov 3, 2025

I got Cline to build out a lot of the tooling for digest sign back when I was getting familiar with using the tool, it did a pretty good job. The process also taught me a little about this code area in our library.

@justsmth justsmth merged commit 177b296 into aws:main Nov 3, 2025
546 of 571 checks passed
@justsmth justsmth deleted the tool-openssl-dhparam branch November 3, 2025 22:03
justsmth added a commit that referenced this pull request Nov 11, 2025
### Description of changes: 
Prepare release v1.64.0.


### What's Changed
* Update max polyz value by @jakemas in
#2787
* ECR Repositories for Android and Formal Verification Images by
@skmcgrail in #2794
* Support more "openssl rsa" options by @justsmth in
#2777
* Remove python codebuild patches by @WillChilds-Klein in
#2793
* Additional options for "openssl c_client" by @justsmth in
#2791
* GitHub-based Formal Verification Image Build by @skmcgrail in
#2796
* Use C++11 atomics to update session stats by @justsmth in
#2786
* Support "openssl dhparam" by @justsmth in
#2790
* Add scrutinice pull permissions for aws-lc/amazonlinux repository by
@skmcgrail in #2799
* Use GitHub-based Verification Images by @skmcgrail in
#2798
* Remove dead code by @torben-hansen in
#2797
* Rename snapsafe to VM UBE by @torben-hansen in
#2800
* Bump MySQL version tag to 9.5.0 by @samuel40791765 in
#2768
* Migrate to macos-15-intel by @samuel40791765 in
#2802
* Use right compiler with ruby CI by @samuel40791765 in
#2801
* Migrate analytics job to be GitHub triggered by @skmcgrail in
#2779
* Support NetBSD by @justsmth in #2754
* Make poly_chknorm constant flow by @jakemas in
#2788
* Rename fork to fork UBE by @torben-hansen in
#2803
* Extend grv asan timeout for Golang to allow completion by
@torben-hansen in #2805

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
sgmenda pushed a commit to sgmenda/aws-lc that referenced this pull request Nov 11, 2025
### Description of changes: 
Prepare release v1.64.0.


### What's Changed
* Update max polyz value by @jakemas in
aws#2787
* ECR Repositories for Android and Formal Verification Images by
@skmcgrail in aws#2794
* Support more "openssl rsa" options by @justsmth in
aws#2777
* Remove python codebuild patches by @WillChilds-Klein in
aws#2793
* Additional options for "openssl c_client" by @justsmth in
aws#2791
* GitHub-based Formal Verification Image Build by @skmcgrail in
aws#2796
* Use C++11 atomics to update session stats by @justsmth in
aws#2786
* Support "openssl dhparam" by @justsmth in
aws#2790
* Add scrutinice pull permissions for aws-lc/amazonlinux repository by
@skmcgrail in aws#2799
* Use GitHub-based Verification Images by @skmcgrail in
aws#2798
* Remove dead code by @torben-hansen in
aws#2797
* Rename snapsafe to VM UBE by @torben-hansen in
aws#2800
* Bump MySQL version tag to 9.5.0 by @samuel40791765 in
aws#2768
* Migrate to macos-15-intel by @samuel40791765 in
aws#2802
* Use right compiler with ruby CI by @samuel40791765 in
aws#2801
* Migrate analytics job to be GitHub triggered by @skmcgrail in
aws#2779
* Support NetBSD by @justsmth in aws#2754
* Make poly_chknorm constant flow by @jakemas in
aws#2788
* Rename fork to fork UBE by @torben-hansen in
aws#2803
* Extend grv asan timeout for Golang to allow completion by
@torben-hansen in aws#2805

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants