Conversation
| #define ML_DSA_POLYZ_PACKEDBYTES_MAX (576) | ||
| #define ML_DSA_POLYZ_PACKEDBYTES_MAX (640) | ||
|
|
||
| OPENSSL_EXPORT void ml_dsa_44_params_init(ml_dsa_params *params); |
Contributor
There was a problem hiding this comment.
warning: unknown type name 'OPENSSL_EXPORT' [clang-diagnostic-error]
OPENSSL_EXPORT void ml_dsa_44_params_init(ml_dsa_params *params);
^| #define ML_DSA_POLYZ_PACKEDBYTES_MAX (640) | ||
|
|
||
| OPENSSL_EXPORT void ml_dsa_44_params_init(ml_dsa_params *params); | ||
| OPENSSL_EXPORT void ml_dsa_65_params_init(ml_dsa_params *params); |
Contributor
There was a problem hiding this comment.
warning: unknown type name 'OPENSSL_EXPORT' [clang-diagnostic-error]
OPENSSL_EXPORT void ml_dsa_65_params_init(ml_dsa_params *params);
^
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2787 +/- ##
=======================================
Coverage 78.50% 78.51%
=======================================
Files 680 680
Lines 115362 115363 +1
Branches 16329 16330 +1
=======================================
+ Hits 90568 90577 +9
+ Misses 23998 23989 -9
- Partials 796 797 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dkostic
approved these changes
Oct 30, 2025
justsmth
approved these changes
Oct 31, 2025
justsmth
added a commit
that referenced
this pull request
Nov 11, 2025
### Description of changes: Prepare release v1.64.0. ### What's Changed * Update max polyz value by @jakemas in #2787 * ECR Repositories for Android and Formal Verification Images by @skmcgrail in #2794 * Support more "openssl rsa" options by @justsmth in #2777 * Remove python codebuild patches by @WillChilds-Klein in #2793 * Additional options for "openssl c_client" by @justsmth in #2791 * GitHub-based Formal Verification Image Build by @skmcgrail in #2796 * Use C++11 atomics to update session stats by @justsmth in #2786 * Support "openssl dhparam" by @justsmth in #2790 * Add scrutinice pull permissions for aws-lc/amazonlinux repository by @skmcgrail in #2799 * Use GitHub-based Verification Images by @skmcgrail in #2798 * Remove dead code by @torben-hansen in #2797 * Rename snapsafe to VM UBE by @torben-hansen in #2800 * Bump MySQL version tag to 9.5.0 by @samuel40791765 in #2768 * Migrate to macos-15-intel by @samuel40791765 in #2802 * Use right compiler with ruby CI by @samuel40791765 in #2801 * Migrate analytics job to be GitHub triggered by @skmcgrail in #2779 * Support NetBSD by @justsmth in #2754 * Make poly_chknorm constant flow by @jakemas in #2788 * Rename fork to fork UBE by @torben-hansen in #2803 * Extend grv asan timeout for Golang to allow completion by @torben-hansen in #2805 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
sgmenda
pushed a commit
to sgmenda/aws-lc
that referenced
this pull request
Nov 11, 2025
### Description of changes: Prepare release v1.64.0. ### What's Changed * Update max polyz value by @jakemas in aws#2787 * ECR Repositories for Android and Formal Verification Images by @skmcgrail in aws#2794 * Support more "openssl rsa" options by @justsmth in aws#2777 * Remove python codebuild patches by @WillChilds-Klein in aws#2793 * Additional options for "openssl c_client" by @justsmth in aws#2791 * GitHub-based Formal Verification Image Build by @skmcgrail in aws#2796 * Use C++11 atomics to update session stats by @justsmth in aws#2786 * Support "openssl dhparam" by @justsmth in aws#2790 * Add scrutinice pull permissions for aws-lc/amazonlinux repository by @skmcgrail in aws#2799 * Use GitHub-based Verification Images by @skmcgrail in aws#2798 * Remove dead code by @torben-hansen in aws#2797 * Rename snapsafe to VM UBE by @torben-hansen in aws#2800 * Bump MySQL version tag to 9.5.0 by @samuel40791765 in aws#2768 * Migrate to macos-15-intel by @samuel40791765 in aws#2802 * Use right compiler with ruby CI by @samuel40791765 in aws#2801 * Migrate analytics job to be GitHub triggered by @skmcgrail in aws#2779 * Support NetBSD by @justsmth in aws#2754 * Make poly_chknorm constant flow by @jakemas in aws#2788 * Rename fork to fork UBE by @torben-hansen in aws#2803 * Extend grv asan timeout for Golang to allow completion by @torben-hansen in aws#2805 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves #V1982529084
Description of changes:
Fix a parameter issue that was not set as the max: ml-dsa-44 uses
576, ml-dsa-65 uses640, ml-dsa-87 uses640, so max should be640Testing:
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.