Skip to content

Remove dead code#2797

Merged
torben-hansen merged 1 commit intoaws:mainfrom
torben-hansen:t_P330826687
Nov 4, 2025
Merged

Remove dead code#2797
torben-hansen merged 1 commit intoaws:mainfrom
torben-hansen:t_P330826687

Conversation

@torben-hansen
Copy link
Copy Markdown
Contributor

Issues:

P330826687

Description of changes:

out_file can't be NULL due to prior condition in the same function. Using out_file is not necessary though. Just remove it.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@torben-hansen torben-hansen requested a review from a team as a code owner November 3, 2025 22:07
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.41%. Comparing base (3be9a2b) to head (b922e3d).
⚠️ Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
tool-openssl/rsa.cc 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2797      +/-   ##
==========================================
- Coverage   78.46%   78.41%   -0.05%     
==========================================
  Files         681      683       +2     
  Lines      115975   116283     +308     
  Branches    16367    16405      +38     
==========================================
+ Hits        90994    91183     +189     
- Misses      24111    24224     +113     
- Partials      870      876       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@torben-hansen torben-hansen enabled auto-merge (squash) November 4, 2025 00:31
@torben-hansen torben-hansen merged commit 5a3e34e into aws:main Nov 4, 2025
397 of 409 checks passed
justsmth added a commit that referenced this pull request Nov 11, 2025
### Description of changes: 
Prepare release v1.64.0.


### What's Changed
* Update max polyz value by @jakemas in
#2787
* ECR Repositories for Android and Formal Verification Images by
@skmcgrail in #2794
* Support more "openssl rsa" options by @justsmth in
#2777
* Remove python codebuild patches by @WillChilds-Klein in
#2793
* Additional options for "openssl c_client" by @justsmth in
#2791
* GitHub-based Formal Verification Image Build by @skmcgrail in
#2796
* Use C++11 atomics to update session stats by @justsmth in
#2786
* Support "openssl dhparam" by @justsmth in
#2790
* Add scrutinice pull permissions for aws-lc/amazonlinux repository by
@skmcgrail in #2799
* Use GitHub-based Verification Images by @skmcgrail in
#2798
* Remove dead code by @torben-hansen in
#2797
* Rename snapsafe to VM UBE by @torben-hansen in
#2800
* Bump MySQL version tag to 9.5.0 by @samuel40791765 in
#2768
* Migrate to macos-15-intel by @samuel40791765 in
#2802
* Use right compiler with ruby CI by @samuel40791765 in
#2801
* Migrate analytics job to be GitHub triggered by @skmcgrail in
#2779
* Support NetBSD by @justsmth in #2754
* Make poly_chknorm constant flow by @jakemas in
#2788
* Rename fork to fork UBE by @torben-hansen in
#2803
* Extend grv asan timeout for Golang to allow completion by
@torben-hansen in #2805

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
sgmenda pushed a commit to sgmenda/aws-lc that referenced this pull request Nov 11, 2025
### Description of changes: 
Prepare release v1.64.0.


### What's Changed
* Update max polyz value by @jakemas in
aws#2787
* ECR Repositories for Android and Formal Verification Images by
@skmcgrail in aws#2794
* Support more "openssl rsa" options by @justsmth in
aws#2777
* Remove python codebuild patches by @WillChilds-Klein in
aws#2793
* Additional options for "openssl c_client" by @justsmth in
aws#2791
* GitHub-based Formal Verification Image Build by @skmcgrail in
aws#2796
* Use C++11 atomics to update session stats by @justsmth in
aws#2786
* Support "openssl dhparam" by @justsmth in
aws#2790
* Add scrutinice pull permissions for aws-lc/amazonlinux repository by
@skmcgrail in aws#2799
* Use GitHub-based Verification Images by @skmcgrail in
aws#2798
* Remove dead code by @torben-hansen in
aws#2797
* Rename snapsafe to VM UBE by @torben-hansen in
aws#2800
* Bump MySQL version tag to 9.5.0 by @samuel40791765 in
aws#2768
* Migrate to macos-15-intel by @samuel40791765 in
aws#2802
* Use right compiler with ruby CI by @samuel40791765 in
aws#2801
* Migrate analytics job to be GitHub triggered by @skmcgrail in
aws#2779
* Support NetBSD by @justsmth in aws#2754
* Make poly_chknorm constant flow by @jakemas in
aws#2788
* Rename fork to fork UBE by @torben-hansen in
aws#2803
* Extend grv asan timeout for Golang to allow completion by
@torben-hansen in aws#2805

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants