Skip to content

Additional options for "openssl c_client"#2791

Merged
justsmth merged 2 commits intoaws:mainfrom
justsmth:tool-openssl-s_client
Nov 3, 2025
Merged

Additional options for "openssl c_client"#2791
justsmth merged 2 commits intoaws:mainfrom
justsmth:tool-openssl-s_client

Conversation

@justsmth
Copy link
Copy Markdown
Contributor

Description of changes:

Add support for -tls1_1 and -cipher for "openssl s_client"

Call-outs:

We previously were not build/running the "s_client" tests. 🤦‍♂️

Testing:

Add tests for new options.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.62%. Comparing base (7e6ef7b) to head (df75be0).
⚠️ Report is 233 commits behind head on main.

Files with missing lines Patch % Lines
tool/client.cc 50.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2791      +/-   ##
==========================================
+ Coverage   78.52%   78.62%   +0.10%     
==========================================
  Files         680      681       +1     
  Lines      115362   115402      +40     
  Branches    16329    16334       +5     
==========================================
+ Hits        90587    90740     +153     
+ Misses      23979    23792     -187     
- Partials      796      870      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth force-pushed the tool-openssl-s_client branch from 89569ed to df75be0 Compare October 31, 2025 15:09
@justsmth justsmth changed the title [DRAFT] Additional options for "openssl c_client" Additional options for "openssl c_client" Oct 31, 2025
@justsmth justsmth marked this pull request as ready for review October 31, 2025 15:38
@justsmth justsmth requested a review from a team as a code owner October 31, 2025 15:38
@justsmth justsmth merged commit 3be9a2b into aws:main Nov 3, 2025
367 of 387 checks passed
@justsmth justsmth deleted the tool-openssl-s_client branch November 3, 2025 19:52
justsmth added a commit that referenced this pull request Nov 11, 2025
### Description of changes: 
Prepare release v1.64.0.


### What's Changed
* Update max polyz value by @jakemas in
#2787
* ECR Repositories for Android and Formal Verification Images by
@skmcgrail in #2794
* Support more "openssl rsa" options by @justsmth in
#2777
* Remove python codebuild patches by @WillChilds-Klein in
#2793
* Additional options for "openssl c_client" by @justsmth in
#2791
* GitHub-based Formal Verification Image Build by @skmcgrail in
#2796
* Use C++11 atomics to update session stats by @justsmth in
#2786
* Support "openssl dhparam" by @justsmth in
#2790
* Add scrutinice pull permissions for aws-lc/amazonlinux repository by
@skmcgrail in #2799
* Use GitHub-based Verification Images by @skmcgrail in
#2798
* Remove dead code by @torben-hansen in
#2797
* Rename snapsafe to VM UBE by @torben-hansen in
#2800
* Bump MySQL version tag to 9.5.0 by @samuel40791765 in
#2768
* Migrate to macos-15-intel by @samuel40791765 in
#2802
* Use right compiler with ruby CI by @samuel40791765 in
#2801
* Migrate analytics job to be GitHub triggered by @skmcgrail in
#2779
* Support NetBSD by @justsmth in #2754
* Make poly_chknorm constant flow by @jakemas in
#2788
* Rename fork to fork UBE by @torben-hansen in
#2803
* Extend grv asan timeout for Golang to allow completion by
@torben-hansen in #2805

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
sgmenda pushed a commit to sgmenda/aws-lc that referenced this pull request Nov 11, 2025
### Description of changes: 
Prepare release v1.64.0.


### What's Changed
* Update max polyz value by @jakemas in
aws#2787
* ECR Repositories for Android and Formal Verification Images by
@skmcgrail in aws#2794
* Support more "openssl rsa" options by @justsmth in
aws#2777
* Remove python codebuild patches by @WillChilds-Klein in
aws#2793
* Additional options for "openssl c_client" by @justsmth in
aws#2791
* GitHub-based Formal Verification Image Build by @skmcgrail in
aws#2796
* Use C++11 atomics to update session stats by @justsmth in
aws#2786
* Support "openssl dhparam" by @justsmth in
aws#2790
* Add scrutinice pull permissions for aws-lc/amazonlinux repository by
@skmcgrail in aws#2799
* Use GitHub-based Verification Images by @skmcgrail in
aws#2798
* Remove dead code by @torben-hansen in
aws#2797
* Rename snapsafe to VM UBE by @torben-hansen in
aws#2800
* Bump MySQL version tag to 9.5.0 by @samuel40791765 in
aws#2768
* Migrate to macos-15-intel by @samuel40791765 in
aws#2802
* Use right compiler with ruby CI by @samuel40791765 in
aws#2801
* Migrate analytics job to be GitHub triggered by @skmcgrail in
aws#2779
* Support NetBSD by @justsmth in aws#2754
* Make poly_chknorm constant flow by @jakemas in
aws#2788
* Rename fork to fork UBE by @torben-hansen in
aws#2803
* Extend grv asan timeout for Golang to allow completion by
@torben-hansen in aws#2805

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants