Skip to content

KAFKA-2211: Adding simpleAclAuthorizer implementation and test cases.#195

Closed
Parth-Brahmbhatt wants to merge 17 commits into
apache:trunkfrom
Parth-Brahmbhatt:KAFKA-2211
Closed

KAFKA-2211: Adding simpleAclAuthorizer implementation and test cases.#195
Parth-Brahmbhatt wants to merge 17 commits into
apache:trunkfrom
Parth-Brahmbhatt:KAFKA-2211

Conversation

@Parth-Brahmbhatt

@Parth-Brahmbhatt Parth-Brahmbhatt commented Sep 4, 2015

Copy link
Copy Markdown
Contributor

No description provided.

@asfbot

asfbot commented Sep 4, 2015

Copy link
Copy Markdown

kafka-trunk-git-pr #359 FAILURE
Looks like there's a problem with this pull request

@Parth-Brahmbhatt

Parth-Brahmbhatt commented Sep 4, 2015

Copy link
Copy Markdown
Contributor Author

The only test failure reported by the bot was
kafka.producer.ProducerTest > testSendWithDeadBroker FAILED
java.lang.AssertionError: Message set should have 1 message
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at kafka.producer.ProducerTest.testSendWithDeadBroker(ProducerTest.scala:260)

Which passes locally and seems very unrelated to the changes i made. I will try and run the test in a loop to see if I can reproduce.

@asfbot

asfbot commented Sep 4, 2015

Copy link
Copy Markdown

kafka-trunk-git-pr #363 SUCCESS
This pull request looks good

junrao
junrao reviewed Sep 6, 2015
View reviewed changes
Comment thread core/src/main/scala/kafka/security/auth/SimpleAclAuthorizer.scala Outdated

@junrao junrao Sep 6, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that it will be cleaner if we split this into getAcls and getAclsFromZK. The former will just read from the cache and the latter always read from ZK. Only the ZK listener will use the latter.

@Parth-Brahmbhatt Parth-Brahmbhatt Sep 9, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Parth-Brahmbhatt

Parth-Brahmbhatt commented Sep 11, 2015

Copy link
Copy Markdown
Contributor Author

@junrao Added a generic ZkNodeChangeListener and removed the scheduler thread. Couldn't think of a better name for the class so if you have a better name let me know. Addressed all other comments in this PR.

@asfbot

asfbot commented Sep 12, 2015

Copy link
Copy Markdown

kafka-trunk-git-pr #410 FAILURE
Looks like there's a problem with this pull request

@asfbot

asfbot commented Sep 12, 2015

Copy link
Copy Markdown

kafka-trunk-git-pr #411 FAILURE
Looks like there's a problem with this pull request

junrao
junrao reviewed Sep 13, 2015
View reviewed changes
Comment thread core/src/main/scala/kafka/common/ZkNodeChangeNotificationListener.scala Outdated

@junrao junrao Sep 13, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo immeditatly

@Parth-Brahmbhatt Parth-Brahmbhatt Sep 14, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

junrao
junrao reviewed Sep 21, 2015
View reviewed changes
Comment thread core/src/main/scala/kafka/security/auth/SimpleAclAuthorizer.scala Outdated

@junrao junrao Sep 21, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove ": Unit ="

@Parth-Brahmbhatt Parth-Brahmbhatt Sep 21, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@asfbot

asfbot commented Sep 21, 2015

Copy link
Copy Markdown

kafka-trunk-git-pr #469 FAILURE
Looks like there's a problem with this pull request

junrao
junrao reviewed Sep 21, 2015
View reviewed changes
Comment thread core/src/main/scala/kafka/security/auth/SimpleAclAuthorizer.scala Outdated

@junrao junrao Sep 21, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove =

@asfbot

asfbot commented Sep 21, 2015

Copy link
Copy Markdown

kafka-trunk-git-pr #475 SUCCESS
This pull request looks good

@junrao

junrao commented Sep 22, 2015

Copy link
Copy Markdown
Contributor

Thanks a lot for the patch. LGTM.

@asfgit asfgit closed this in 0990b6b Sep 22, 2015
@ijuma

ijuma commented Sep 22, 2015

Copy link
Copy Markdown
Member

Thanks Parth!

jsancio pushed a commit to jsancio/kafka that referenced this pull request May 30, 2019
@jarekr
MINOR: put back no-daemon flag (apache#195)
ed2cfc5 
also turn off pint merge check for this repo, for now as I'm not sure it will work.
efeg pushed a commit to efeg/kafka that referenced this pull request Jan 29, 2020
@becketqin
Fix PercentileMetricAnomalyFinderTest (apache#195)
e527258 
Also rename a anomaly analyzer to anomaly finder
efeg pushed a commit to efeg/kafka that referenced this pull request Sep 8, 2021
@lmr3796
[LI-HOTFIX] Enable spotbugs on build (apache#195)
22517e6 
TICKET = N/A
EXIT_CRITERIA = N/A
wyuka pushed a commit to wyuka/kafka that referenced this pull request Jan 7, 2022
@Lincong @lmr3796
[LI-HOTFIX] CI: Migrate CI build to Github Actions
a77d9e7 
This commit is a squash of:
- 97f6a93 [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (apache#106)
- bb6cab9 [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (apache#107)
- 4ac92ac [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (apache#108)
- e3ca505 [LI-HOTFIX] Add note on LinkedIn Kafka Branch to README
- 883ece3 [LI-HOTFIX] Updating description of the CI flow (apache#114)
- 77cad71 [LI-HOTFIX] Add rat to CI build to make it consistent with PR (apache#173)
- 2af73a1 [LI-HOTFIX] CI: Split test builds to multiple jobs
- 22517e6 [LI-HOTFIX] CI: Enable spotbugs on build (apache#195)

And partially picked up the rat set up from
- 66596f0 [LI-HOTFIX] Adding licence and rat check (apache#159)

TICKET = N/A
LI_DESCRIPTION = LIKAFKA-34202
EXIT_CRITERIA = When migrating off Github Actions for CI
wyuka pushed a commit to wyuka/kafka that referenced this pull request Jun 16, 2022
@Lincong @lmr3796
[LI-HOTFIX] CI: Migrate CI build to Github Actions
76b2ef9 
This commit is a squash of:
- 97f6a93 [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (apache#106)
- bb6cab9 [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (apache#107)
- 4ac92ac [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (apache#108)
- e3ca505 [LI-HOTFIX] Add note on LinkedIn Kafka Branch to README
- 883ece3 [LI-HOTFIX] Updating description of the CI flow (apache#114)
- 77cad71 [LI-HOTFIX] Add rat to CI build to make it consistent with PR (apache#173)
- 2af73a1 [LI-HOTFIX] CI: Split test builds to multiple jobs
- 22517e6 [LI-HOTFIX] CI: Enable spotbugs on build (apache#195)

And partially picked up the rat set up from
- 66596f0 [LI-HOTFIX] Adding licence and rat check (apache#159)

TICKET = N/A
LI_DESCRIPTION = LIKAFKA-34202
EXIT_CRITERIA = When migrating off Github Actions for CI
davide-armand pushed a commit to aiven/kafka that referenced this pull request Dec 1, 2025
@giuseppelillo
Adjust FileExtent range length in FileFetchJob [INK-140] (apache#195)
74c80b1 
FileExtent created from FileFetchJob should take into account
that its range it's bounded by the underlying buffer, which
could be shorter than the range requested in the fetch job.
fvaleri added a commit to fvaleri/kafka that referenced this pull request Jun 10, 2026
@fvaleri
Fix consumer group offset sync skipping EMPTY groups (apache#195)
deb8cf3 
The getNonSyncableDestinationGroupIds method included GroupState.EMPTY
in its filter, causing groups with no active members to be treated as
non-syncable. After the first offset commit created the group on the
destination in EMPTY state, all subsequent sync cycles skipped it,
leaving offsets permanently stale.

Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Parth-Brahmbhatt @asfbot @ijuma @junrao