Skip to content

MINOR: kafkatest add manifest#173

Closed
granders wants to merge 5 commits into
apache:trunkfrom
confluentinc:minor-kafkatest-add-manifest
Closed

MINOR: kafkatest add manifest#173
granders wants to merge 5 commits into
apache:trunkfrom
confluentinc:minor-kafkatest-add-manifest

Conversation

@granders

Copy link
Copy Markdown
Contributor

This patch makes it possible to publish kafkatest (system test package) to pypi and use it as a library in other projects by:

  • including necessary static resources with the package
  • renaming the version to conform w/PEP 440, since python packaging tools reject the current version name

@asfbot

asfbot commented Aug 28, 2015

Copy link
Copy Markdown

kafka-trunk-git-pr #246 FAILURE
Looks like there's a problem with this pull request

@granders

Copy link
Copy Markdown
Contributor Author

Legit problem - rat complaining about licenses

@asfbot

asfbot commented Aug 28, 2015

Copy link
Copy Markdown

kafka-trunk-git-pr #248 FAILURE
Looks like there's a problem with this pull request

@ewencp

ewencp commented Aug 28, 2015

Copy link
Copy Markdown
Contributor

LGTM. Worth pointing out that this also includes an unrelated (but useful) change to stop logging every console consumer message. Not sure if it was intended.

@granders

Copy link
Copy Markdown
Contributor Author

@ewencp Yes, intentional but I probably should have called it out a bit more clearly.

@asfgit asfgit closed this in 9c936b1 Aug 28, 2015
@granders granders deleted the minor-kafkatest-add-manifest branch August 29, 2015 16:36
efeg pushed a commit to efeg/kafka that referenced this pull request Sep 8, 2021
wyuka pushed a commit to wyuka/kafka that referenced this pull request Jan 7, 2022
This commit is a squash of:
- 97f6a93 [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (apache#106)
- bb6cab9 [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (apache#107)
- 4ac92ac [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (apache#108)
- e3ca505 [LI-HOTFIX] Add note on LinkedIn Kafka Branch to README
- 883ece3 [LI-HOTFIX] Updating description of the CI flow (apache#114)
- 77cad71 [LI-HOTFIX] Add rat to CI build to make it consistent with PR (apache#173)
- 2af73a1 [LI-HOTFIX] CI: Split test builds to multiple jobs
- 22517e6 [LI-HOTFIX] CI: Enable spotbugs on build (apache#195)

And partially picked up the rat set up from
- 66596f0 [LI-HOTFIX] Adding licence and rat check (apache#159)

TICKET = N/A
LI_DESCRIPTION = LIKAFKA-34202
EXIT_CRITERIA = When migrating off Github Actions for CI
wyuka pushed a commit to wyuka/kafka that referenced this pull request Jun 16, 2022
This commit is a squash of:
- 97f6a93 [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (apache#106)
- bb6cab9 [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (apache#107)
- 4ac92ac [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (apache#108)
- e3ca505 [LI-HOTFIX] Add note on LinkedIn Kafka Branch to README
- 883ece3 [LI-HOTFIX] Updating description of the CI flow (apache#114)
- 77cad71 [LI-HOTFIX] Add rat to CI build to make it consistent with PR (apache#173)
- 2af73a1 [LI-HOTFIX] CI: Split test builds to multiple jobs
- 22517e6 [LI-HOTFIX] CI: Enable spotbugs on build (apache#195)

And partially picked up the rat set up from
- 66596f0 [LI-HOTFIX] Adding licence and rat check (apache#159)

TICKET = N/A
LI_DESCRIPTION = LIKAFKA-34202
EXIT_CRITERIA = When migrating off Github Actions for CI
patrik-marton pushed a commit to patrik-marton/kafka that referenced this pull request Mar 11, 2025
davide-armand pushed a commit to aiven/kafka that referenced this pull request Dec 1, 2025
…-110] (apache#173)

* refactor(inkless): remove uploaded files when CP fails [INK-110]

On regular uploads, if the control plane fails for any reason, the
uploaded file is not deleted. This commit fixes that.

* refactor(inkless:control_plane): Mark file for deletion on failed merge [INK-110]

If the control plane finds that the merge file should fail because of a
failure condition (e.g. wrong number of parent batches), then the
uploaded file should be marked for deletion.

* refactor(inkless:merger): delete uploaded files when cp fails [INK-110]
fvaleri added a commit to fvaleri/kafka that referenced this pull request May 19, 2026
These chanegs come from the discussion thread.

Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants