KAFKA-2386; increase timeouts for transient test failure in ConsumerCoordinatorResponseTests#107
Closed
hachikuji wants to merge 1 commit into
Closed
KAFKA-2386; increase timeouts for transient test failure in ConsumerCoordinatorResponseTests#107hachikuji wants to merge 1 commit into
hachikuji wants to merge 1 commit into
Conversation
…oordinatorResponseTest
Contributor
|
LGTM. That is - the timeouts were unrealistically low (and still are after the change), so changing them doesn't compromise the test. I didn't do an exhaustive testing of new parameters, but it passed few times on my machine, which is good enough :) |
|
kafka-trunk-git-pr #80 SUCCESS |
ambroff
pushed a commit
to ambroff/kafka
that referenced
this pull request
Jan 20, 2021
…l tests upon a tag creation/push (apache#107) TICKET = N/A LI_DESCRIPTION = LIKAFKA-34202 EXIT_CRITERIA = N/A
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Jan 7, 2022
This commit is a squash of: - 97f6a93 [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (apache#106) - bb6cab9 [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (apache#107) - 4ac92ac [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (apache#108) - e3ca505 [LI-HOTFIX] Add note on LinkedIn Kafka Branch to README - 883ece3 [LI-HOTFIX] Updating description of the CI flow (apache#114) - 77cad71 [LI-HOTFIX] Add rat to CI build to make it consistent with PR (apache#173) - 2af73a1 [LI-HOTFIX] CI: Split test builds to multiple jobs - 22517e6 [LI-HOTFIX] CI: Enable spotbugs on build (apache#195) And partially picked up the rat set up from - 66596f0 [LI-HOTFIX] Adding licence and rat check (apache#159) TICKET = N/A LI_DESCRIPTION = LIKAFKA-34202 EXIT_CRITERIA = When migrating off Github Actions for CI
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Jun 16, 2022
This commit is a squash of: - 97f6a93 [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (apache#106) - bb6cab9 [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (apache#107) - 4ac92ac [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (apache#108) - e3ca505 [LI-HOTFIX] Add note on LinkedIn Kafka Branch to README - 883ece3 [LI-HOTFIX] Updating description of the CI flow (apache#114) - 77cad71 [LI-HOTFIX] Add rat to CI build to make it consistent with PR (apache#173) - 2af73a1 [LI-HOTFIX] CI: Split test builds to multiple jobs - 22517e6 [LI-HOTFIX] CI: Enable spotbugs on build (apache#195) And partially picked up the rat set up from - 66596f0 [LI-HOTFIX] Adding licence and rat check (apache#159) TICKET = N/A LI_DESCRIPTION = LIKAFKA-34202 EXIT_CRITERIA = When migrating off Github Actions for CI
davide-armand
pushed a commit
to aiven/kafka
that referenced
this pull request
Dec 1, 2025
fvaleri
added a commit
to fvaleri/kafka
that referenced
this pull request
Mar 26, 2026
Hide mirror.name internal config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two race conditions in the test case "testGenerationIdIncrementsOnRebalance." First, a delay before the second join group request can timeout the initial group and cause the generationId to unexpectedly reset. Second, a delay in the join group request handling will timeout the request itself and cause the test to fail. This commit doesn't address these race conditions, but increases the timeouts to make them more unlikely. If the problem reoccurs, then we'll probably need a better solution.