Skip to content

KAFKA-2406: Throttle ISR propagation#114

Closed
becketqin wants to merge 7 commits into
apache:trunkfrom
becketqin:KAFKA-2406
Closed

KAFKA-2406: Throttle ISR propagation#114
becketqin wants to merge 7 commits into
apache:trunkfrom
becketqin:KAFKA-2406

Conversation

@becketqin

Copy link
Copy Markdown
Contributor

This is a follow up patch for KAFKA-2406. Further test to verify if this change alone is enough to solve the problem or not.

@asfbot

asfbot commented Aug 5, 2015

Copy link
Copy Markdown

kafka-trunk-git-pr #88 FAILURE
Looks like there's a problem with this pull request

@asfbot

asfbot commented Aug 5, 2015

Copy link
Copy Markdown

kafka-trunk-git-pr #89 SUCCESS
This pull request looks good

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To do this, we need to hold a controller lock since sendUpdateMetadataRequest() is not thread safe.

@asfbot

asfbot commented Aug 7, 2015

Copy link
Copy Markdown

kafka-trunk-git-pr #102 SUCCESS
This pull request looks good

@becketqin becketqin changed the title KAFKA-2406[WIP]: Throttle ISR propagation KAFKA-2406: Throttle ISR propagation Aug 7, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that you also wanted to move the code that creates the isr_change path in ZK to the beginning of broker startup (currently it's in the controller startup)?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I did that in another patch. I can put it in this patch to save a separate commit :)

@asfbot

asfbot commented Aug 9, 2015

Copy link
Copy Markdown

kafka-trunk-git-pr #116 SUCCESS
This pull request looks good

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method is probably no longer needed.

@asfbot

asfbot commented Aug 10, 2015

Copy link
Copy Markdown

kafka-trunk-git-pr #119 SUCCESS
This pull request looks good

…terval value for now and keep KIP-29 open for discussion to see if we want to expose a config. There will be a follow up patch after we reach conclusion in KIP-29.
@asfbot

asfbot commented Aug 11, 2015

Copy link
Copy Markdown

kafka-trunk-git-pr #128 SUCCESS
This pull request looks good

@junrao

junrao commented Aug 13, 2015

Copy link
Copy Markdown
Contributor

Thanks for the latest patch. LGTM.

@asfgit asfgit closed this in 2c55bd8 Aug 13, 2015
hachikuji pushed a commit to hachikuji/kafka that referenced this pull request Dec 8, 2016
This is the first cut to enable integration of client and broker code for the Idempotent producer.
hachikuji pushed a commit to hachikuji/kafka that referenced this pull request Dec 14, 2016
This is the first cut to enable integration of client and broker code for the Idempotent producer.
hachikuji pushed a commit to hachikuji/kafka that referenced this pull request Dec 20, 2016
This is the first cut to enable integration of client and broker code for the Idempotent producer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants