KAFKA-2402: Create IsrChangeNotificationPath when server statrs.#108
KAFKA-2402: Create IsrChangeNotificationPath when server statrs.#108becketqin wants to merge 3 commits into
Conversation
|
kafka-trunk-git-pr #81 FAILURE |
|
The change looks good although I wonder if there's anything we can do to make it less likely for similar problems to occur in the future. An automated test would be ideal, but if that is hard then a potential alternative would be to move the |
|
LGTM! However, an unit test or integration test will be helpful. |
|
@ijuma @samshah , unit test might be a little bit hard to do here simply because the issue will only occur during version upgrade. We need a rolling upgrade test as proposed in KAFKA-1888. This is probably a non-trivial work and maybe out of the scope of this simple fix? |
|
@becketqin, fair enough. Do you think it's worth moving the Note that this branch doesn't merge cleanly anymore so that needs to be fixed before it can merged. |
|
kafka-trunk-git-pr #94 FAILURE |
|
kafka-trunk-git-pr #95 SUCCESS |
|
@becketqin, I think this change was included as part of 2c55bd8#diff-f4fe18d654e20048317014cfe9d53968R61 right? If so, can you please close this PR? And thanks for making the change I suggested. |
|
@ijuma Yes, this patch was put in KAFKA-2406 already. I'll close it. |
…chive and disable all Travis actions (apache#108) TICKET = N/A LI_DESCRIPTION = LIKAFKA-34202 EXIT_CRITERIA = N/A
This commit is a squash of: - 97f6a93 [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (apache#106) - bb6cab9 [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (apache#107) - 4ac92ac [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (apache#108) - e3ca505 [LI-HOTFIX] Add note on LinkedIn Kafka Branch to README - 883ece3 [LI-HOTFIX] Updating description of the CI flow (apache#114) - 77cad71 [LI-HOTFIX] Add rat to CI build to make it consistent with PR (apache#173) - 2af73a1 [LI-HOTFIX] CI: Split test builds to multiple jobs - 22517e6 [LI-HOTFIX] CI: Enable spotbugs on build (apache#195) And partially picked up the rat set up from - 66596f0 [LI-HOTFIX] Adding licence and rat check (apache#159) TICKET = N/A LI_DESCRIPTION = LIKAFKA-34202 EXIT_CRITERIA = When migrating off Github Actions for CI
This commit is a squash of: - 97f6a93 [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (apache#106) - bb6cab9 [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (apache#107) - 4ac92ac [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (apache#108) - e3ca505 [LI-HOTFIX] Add note on LinkedIn Kafka Branch to README - 883ece3 [LI-HOTFIX] Updating description of the CI flow (apache#114) - 77cad71 [LI-HOTFIX] Add rat to CI build to make it consistent with PR (apache#173) - 2af73a1 [LI-HOTFIX] CI: Split test builds to multiple jobs - 22517e6 [LI-HOTFIX] CI: Enable spotbugs on build (apache#195) And partially picked up the rat set up from - 66596f0 [LI-HOTFIX] Adding licence and rat check (apache#159) TICKET = N/A LI_DESCRIPTION = LIKAFKA-34202 EXIT_CRITERIA = When migrating off Github Actions for CI
No description provided.