Skip to content

fix(core): Resolve forwardRef declarations for jit#46334

Closed
pauldraper wants to merge 1 commit intoangular:mainfrom
pauldraper:pauldraper/forwardref
Closed

fix(core): Resolve forwardRef declarations for jit#46334
pauldraper wants to merge 1 commit intoangular:mainfrom
pauldraper:pauldraper/forwardref

Conversation

@pauldraper
Copy link
Contributor

Resolves #45741

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

NgModule.declarations supports forwardRef for AOT but not JIT

Issue Number: #45741

What is the new behavior?

NgModule.declarations supports forwardRef for JIT

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Follow-up to #45742

@pullapprove pullapprove bot requested a review from jessicajaniuk June 10, 2022 20:55
@pauldraper pauldraper force-pushed the pauldraper/forwardref branch from 540b7d7 to e0c115d Compare June 10, 2022 20:59
@jessicajaniuk jessicajaniuk added the area: core Issues related to the framework runtime label Jun 10, 2022
@ngbot ngbot bot added this to the Backlog milestone Jun 10, 2022
Fix forwardRef() usage for declarations for jit. Resolves angular#45741.
@pauldraper pauldraper force-pushed the pauldraper/forwardref branch from e0c115d to 7f4ea80 Compare June 10, 2022 21:35
@AndrewKushnir AndrewKushnir requested a review from JoostK June 10, 2022 22:32
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jun 10, 2022
Copy link
Member

@JoostK JoostK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@JoostK JoostK added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 11, 2022
@JoostK
Copy link
Member

JoostK commented Jun 11, 2022

Oh this needs fw-core approval, so @jessicajaniuk you're still on the hook to review as well :-)

@jessicajaniuk jessicajaniuk changed the title fix(core): Resolve forwardRef delcarations for jit fix(core): Resolve forwardRef declarations for jit Jun 13, 2022
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍪

thank you!

@jessicajaniuk jessicajaniuk removed the action: presubmit The PR is in need of a google3 presubmit label Jun 13, 2022
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit b1a3dec.

jessicajaniuk pushed a commit that referenced this pull request Jun 13, 2022
Fix forwardRef() usage for declarations for jit. Resolves #45741.

PR Close #46334
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Jun 17, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`14.0.1` -> `14.0.2`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.0.1/14.0.2) |
| [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`14.0.1` -> `14.0.2`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.0.1/14.0.2) |
| [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`14.0.1` -> `14.0.2`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.0.1/14.0.2) |
| [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | patch | [`14.0.1` -> `14.0.2`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.0.1/14.0.2) |
| [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`14.0.1` -> `14.0.2`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.0.1/14.0.2) |
| [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`14.0.1` -> `14.0.2`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.0.1/14.0.2) |
| [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`14.0.1` -> `14.0.2`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.0.1/14.0.2) |
| [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`14.0.1` -> `14.0.2`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.0.1/14.0.2) |
| [zone.js](https://github.com/angular/angular) ([changelog](https://github.com/angular/angular/blob/master/packages/zone.js/CHANGELOG.md)) | dependencies | patch | [`0.11.5` -> `0.11.6`](https://renovatebot.com/diffs/npm/zone.js/0.11.5/0.11.6) |

---

### Release Notes

<details>
<summary>angular/angular (@&#8203;angular/animations)</summary>

### [`v14.0.2`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#&#8203;1402-2022-06-15)

[Compare Source](angular/angular@14.0.1...14.0.2)

##### common

| Commit | Type | Description |
| -- | -- | -- |
| [ef5cba3df7](angular/angular@ef5cba3) | fix | allow null in ngComponentOutlet ([#&#8203;46280](angular/angular#46280)) |

##### compiler-cli

| Commit | Type | Description |
| -- | -- | -- |
| [8ecfd71fd7](angular/angular@8ecfd71) | fix | don't emit empty providers array ([#&#8203;46301](angular/angular#46301)) |
| [b92c1a6ada](angular/angular@b92c1a6) | fix | use inline type-check blocks for components outside `rootDir` ([#&#8203;46096](angular/angular#46096)) |

##### core

| Commit | Type | Description |
| -- | -- | -- |
| [3fd8948b4a](angular/angular@3fd8948) | fix | Resolve forwardRef declarations for jit ([#&#8203;46334](angular/angular#46334)) |

#### Special Thanks

Alex Rickabaugh, Andrew Scott, Badawi7, Daniel Schmitz, Derek Cormier, JoostK, Kevin Davila, Kristiyan Kostadinov, Paul Draper, Paul Gschwendtner, Tom Eustace, Totati, Younes Jaaidi, alefra, dario-piotrowicz, markostanimirovic, mgechev, piyush132000, sten-bone and vivekkoya

<!-- CHANGELOG SPLIT MARKER -->

</details>

<details>
<summary>angular/angular (zone.js)</summary>

### [`v0.11.6`](https://github.com/angular/angular/blob/HEAD/packages/zone.js/CHANGELOG.md#&#8203;0116-httpsgithubcomangularangularcomparezonejs-0115zonejs-0116-2022-06-02)

[Compare Source](angular/angular@zone.js-0.11.5...zone.js-0.11.6)

##### Bug Fixes

-   **zone.js:** check if `process` is defined when patching the `GlobalErrors.install` ([#&#8203;45392](angular/angular#45392)) ([c7bcc1b](angular/angular@c7bcc1b)), closes [#&#8203;42260](angular/angular#42260)
-   **zone.js:** in TaskTrackingZoneSpec track a periodic task until it is cancelled ([#&#8203;45391](angular/angular#45391)) ([f19b36f](angular/angular@f19b36f))
-   **zone.js:** read `Symbol.species` safely ([#&#8203;45369](angular/angular#45369)) ([e2eaac3](angular/angular@e2eaac3))
-   **zone.js:** should ignore multiple resolve call ([#&#8203;45283](angular/angular#45283)) ([aebf165](angular/angular@aebf165)), closes [#&#8203;44913](angular/angular#44913)
-   **zone.js:** swallow the error when the element callback is not patchable ([#&#8203;45400](angular/angular#45400)) ([4ea70e3](angular/angular@4ea70e3)), closes [lwc/engine-core/src/framework/base-bridge-element.ts#L180-L186](https://github.com/lwc/engine-core/src/framework/base-bridge-element.ts/issues/L180-L186) [#&#8203;42546](angular/angular#42546)

##### BREAKING CHANGES

-   **zone.js:** in TaskTrackingZoneSpec track a periodic task until it is cancelled

The breaking change is scoped only to the plugin
`zone.js/plugins/task-tracking`. If you used `TaskTrackingZoneSpec` and
checked the pending macroTasks e.g. using `(this.ngZone as any)._inner ._parent._properties.TaskTrackingZone.getTasksFor('macroTask')`, then
its behavior slightly changed for periodic macrotasks. For example,
previously the `setInterval` macrotask was no longer tracked after its
callback was executed for the first time. Now it's tracked until
the task is explicitly cancelled, e.g with `clearInterval(id)`.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1420
Reviewed-by: 6543 <6543@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NgModule.declarations forwardRef doesn't work for JIT

4 participants