fix(core) Resolve forwardRef declarations for render3 jit#45742
Closed
pauldraper wants to merge 1 commit intoangular:mainfrom
Closed
fix(core) Resolve forwardRef declarations for render3 jit#45742pauldraper wants to merge 1 commit intoangular:mainfrom
pauldraper wants to merge 1 commit intoangular:mainfrom
Conversation
Contributor
Author
An odd thing to say, considering this is a change to But names are hard :) |
Contributor
|
Hi @pauldraper, could you please address Joost's change request? |
Contributor
|
Closing as there's been no activity here. Feel free to open a new pull request with the suggested fixes if you'd like this to land. Thanks! |
14 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #45741
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
NgModule.declarations supports forwardRef for AOT but not JIT
Issue Number: #45741
What is the new behavior?
NgModule.declarations supports forwardRef for JIT
Does this PR introduce a breaking change?
Other information