fix(zone.js): check if process is defined when patching the GlobalErrors.install#45392
Closed
arturovt wants to merge 1 commit intoangular:masterfrom
Closed
fix(zone.js): check if process is defined when patching the GlobalErrors.install#45392arturovt wants to merge 1 commit intoangular:masterfrom
process is defined when patching the GlobalErrors.install#45392arturovt wants to merge 1 commit intoangular:masterfrom
Conversation
294f7fc to
1a84b05
Compare
process defined when patching the GlobalErrors.installprocess is defined when patching the GlobalErrors.install
…Errors.install` Jasmine checks internally if `process` and `process.on` is defined. Otherwise, it installs the browser rejection handler through the `global.addEventListener`. This code may be run in the browser environment where `process` is not defined, and this will lead to a runtime exception since Webpack 5 removed automatic Node.js polyfills. PR Close angular#42260
JiaLiPassion
approved these changes
Mar 20, 2022
Contributor
JiaLiPassion
left a comment
There was a problem hiding this comment.
LGTM! thank you for the PR.
Contributor
|
This PR was merged into the repository by commit c7bcc1b. |
dylhunn
pushed a commit
that referenced
this pull request
Mar 24, 2022
…Errors.install` (#45392) Jasmine checks internally if `process` and `process.on` is defined. Otherwise, it installs the browser rejection handler through the `global.addEventListener`. This code may be run in the browser environment where `process` is not defined, and this will lead to a runtime exception since Webpack 5 removed automatic Node.js polyfills. PR Close #42260 PR Close #45392
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
Issue Number: #42260
Does this PR introduce a breaking change?