fix(core): Resolve forwardRef declarations for jit (#46334)

pauldraper · thePunderWoman · commit 3fd8948b4a04 · 2022-06-13T16:59:59.000Z
Fix forwardRef() usage for declarations for jit. Resolves #45741. PR Close #46334
diff --git a/packages/core/src/render3/jit/module.ts b/packages/core/src/render3/jit/module.ts
@@ -466,6 +466,7 @@ function setScopeOnDeclaredComponents(moduleType: Type<any>, ngModule: NgModule)
   const transitiveScopes = transitiveScopesFor(moduleType);
 
   declarations.forEach(declaration => {
+    declaration = resolveForwardRef(declaration);
     if (declaration.hasOwnProperty(NG_COMP_DEF)) {
       // A `ɵcmp` field exists - go ahead and patch the component directly.
       const component = declaration as Type<any>& {ɵcmp: ComponentDef<any>};
diff --git a/packages/core/test/render3/ivy/jit_spec.ts b/packages/core/test/render3/ivy/jit_spec.ts
@@ -7,7 +7,7 @@
  */
 import 'reflect-metadata';
 
-import {Component, ContentChild, ContentChildren, Directive, ElementRef, getNgModuleById, HostBinding, HostListener, Input, NgModule, Pipe, QueryList, ViewChild, ViewChildren, ɵNgModuleDef as NgModuleDef, ɵɵngDeclareComponent as ngDeclareComponent} from '@angular/core';
+import {Component, ContentChild, ContentChildren, Directive, ElementRef, forwardRef, getNgModuleById, HostBinding, HostListener, Input, NgModule, Pipe, QueryList, ViewChild, ViewChildren, ɵNgModuleDef as NgModuleDef, ɵɵngDeclareComponent as ngDeclareComponent} from '@angular/core';
 import {Injectable} from '@angular/core/src/di/injectable';
 import {setCurrentInjector, ɵɵinject} from '@angular/core/src/di/injector_compatibility';
 import {ɵɵdefineInjectable, ɵɵInjectorDef} from '@angular/core/src/di/interface/defs';
@@ -226,6 +226,25 @@ describe('render3 jit', () => {
     expect(moduleDef.declarations[0]).toBe(Cmp);
   });
 
+  it('compiles a module with forwardRef', () => {
+    @NgModule({
+      declarations: [forwardRef(() => Cmp)],
+    })
+    class Module {
+    }
+
+    @Component({
+      template: 'foo',
+      selector: 'foo',
+    })
+    class Cmp {
+    }
+
+    const componentDef: ComponentDef<Module> = (Cmp as any).ɵcmp;
+    expect(componentDef).toBeDefined();
+    expect(componentDef.schemas).toBeInstanceOf(Array);
+  });
+
   it('compiles a module with an id and registers it correctly', () => {
     @NgModule({
       id: 'test',
