Update all AMP devDependencies to their latest versions by rsimha · Pull Request #12472 · ampproject/amphtml

rsimha · 2017-12-14T20:30:42Z

This PR does the following:

Runs yarn upgrade --dev --exact --latest. With this, all the packages in AMP's devDependencies are at their latest versions. (The packages in dependencies remain unchanged.)
Fixes all the errors and warnings that are currently seen with yarn check

Full list of packages that were updated, with new versions:

"ajv": "5.5.2",
"ajv-keywords": "2.1.1",
"ava": "0.24.0",
"babel-preset-env": "1.6.1",
"babelify": "8.0.0",
"bluebird": "3.5.1",
"body-parser": "1.18.2",
"browserify": "14.5.0",
"browserify-istanbul": "3.0.1",
"chalk": "2.3.0",
"del": "3.0.0",
"eslint": "4.13.1",
"esprima": "4.0.0",
"express": "4.16.2",
"fetch-mock": "5.13.1",
"formidable": "1.1.1",
"fs-extra": "5.0.0",
"gulp-exec": "2.1.3",
"gulp-file": "0.3.0",
"gulp-git": "2.4.2",
"gulp-if": "2.0.2",
"gulp-load-plugins": "1.5.0",
"gulp-replace": "0.6.1",
"gulp-sourcemaps": "2.6.1",
"gulp-uglify": "3.0.0",
"gulp-util": "3.0.8",
"gulp-watch": "4.3.11",
"gulp-wrap": "0.13.0",
"gzip-size": "4.1.0",
"jsdom": "11.5.1",
"markdown-link-check": "3.1.5",
"minimatch": "3.0.4",
"moment": "2.20.1",
"morgan": "1.9.0",
"nodemon": "1.14.0",
"phantomjs-prebuilt": "2.1.16",
"pretty-bytes": "4.0.2",
"react-dates": "16.0.1",
"request": "2.83.0",
"rimraf": "2.6.2",
"through2": "2.0.3",
"touch": "3.1.0",
"uglifyify": "4.0.5",

Follow up to #12179, #12450, #12476, #12486, #12499, and #12512
Partial fix for #12181
Fixes #12565

rsimha · 2017-12-18T22:34:36Z

/to @choumx @erwinmombay

rsimha · 2017-12-18T22:37:22Z

/cc @cramforce

erwinmombay · 2017-12-18T22:44:02Z

package.json

  "dependencies": {
    "babel-polyfill": "6.26.0",
-    "document-register-element": "1.5.0",
+    "document-register-element": "1.7.0",


im hesitant in updating this without thorough testing (this is the only change here that is not a dev dep)

enough that this change should be in its own PR

cc @dvoytenko

Noted. What does document-register-element do, and what kind of testing must we do? Also, is there any reason these four items must live in dependencies and not devDependencies?

document-register-element is a polyfill for browsers that don't support custom elements, this is going to be mostly old iOS i believe.

yes, these items are in dependencies and not devDependencies since these are node modules that are compiled with the production runtime (meaning they are included in the code that we serve) and not a tool/development dependency

We just need to understand what changed between 1.5 -> 1.6 -> 1.7 and test on browsers that don't support custom element and ones that do

Honestly, it might be a clean update but since it affects production code, id rather be cautious

Gotcha, re: dependencies vs devDependencies.

Here's the commit log for document-register-element. About a dozen code changes between versions 1.5.0 and 1.7.0. @dvoytenko @erwinmombay, think you can look at them and see if you're worried about anything? https://github.com/WebReflection/document-register-element/commits/master

FWIW, out integration_tests shard on Travis now runs tests on 12 browsers, including old versions of iOS. (11.0, 10.0, and 9.0). See https://travis-ci.org/ampproject/amphtml/jobs/318328159

@erwinmombay I've reverted the change to the document-register-element version. I agree that it should go in as a separate PR that's easy to revert if needed.

PTAL.

erwinmombay · 2017-12-18T23:12:32Z

package.json

    "atob": "2.0.3",
-    "autoprefixer": "6.7.0",
-    "ava": "0.15.2",
+    "autoprefixer": "7.2.3",


I'll LGTM, but i'd like autoprefixer, cssnano, postcss, and postcss-import to be on a separate PR (these are all css processing tools that i'd like to manually test or create a golden file for)

Gotcha. I'll hold off on merging this PR, and first do those upgrades in a separate PR. I'll ping this PR after that. Thanks for the comments!

@erwinmombay Sent you #12512 with the CSS changes alone.

Update: #12512 has now been tested with the golden file that was added in #12526, and should be merged soon.

Merged and rebased. This PR no longer contains any CSS-related package changes.

rsimha · 2017-12-20T23:07:43Z

@erwinmombay This has been rebased on all the previous changes. PTAL.

erwinmombay · 2017-12-21T16:36:14Z

~~@rsimha-amp not sure how #12472 overlaps with this PR. can you explain?~~

erwinmombay · 2017-12-21T17:06:34Z

package.json

    "react": "16.2.0",
    "react-addons-shallow-compare": "15.6.2",
-    "react-dates": "13.0.6",
+    "react-dates": "16.0.1",


@cvializ should this be in dependencies and not devDependencies? we bundle this with your extension correct?

Just merged this, but I think it should be moved to dependencies. I'll move it up in a follow up PR right now and revert it to its old 13.0.6 version, and update the documentation.

It turns out that @cvializ added several packages to package.json in his date picker PR. I've started a new discussion / PR at #12571 to see if this is indeed a concern. It's possible that the only package that needs to move to dependencies is react-dates, since the only import from node_modules in amp-date-picker is here: https://github.com/ampproject/amphtml/blob/master/extensions/amp-date-picker/0.1/amp-date-picker.css

Let's continue this discussion in #12571.

…mpproject#12574)

erwinmombay · 2018-02-27T18:32:45Z

package.json

+    "gzip-size": "4.1.0",
    "is-running": "2.1.0",
    "jison": "0.4.18",
-    "jsdom": "9.2.1",


this broke a few live list examples

@erwinmombay Any chance there's a newer version that fixes the bug? If not, we can roll back and add an exception so this package is manually updated.

googlebot added the cla: yes label Dec 14, 2017

rsimha requested review from dreamofabear and erwinmombay December 14, 2017 20:30

ampprojectbot added this to the Pending Triage milestone Dec 18, 2017

rsimha self-assigned this Dec 18, 2017

rsimha requested a review from cramforce December 18, 2017 22:37

erwinmombay reviewed Dec 18, 2017

View reviewed changes

rsimha changed the title ~~Update all dependencies to their latest versions~~ Update all AMP devDependencies to their latest versions Dec 18, 2017

erwinmombay reviewed Dec 18, 2017

View reviewed changes

rsimha mentioned this pull request Dec 18, 2017

Update all of AMP's CSS devDependencies to their latest versions #12512

Merged

Update all devDependencies

e7cfcd2

This was referenced Dec 20, 2017

yarn check reports multiple errors due to duplicate versions in devDependency packages #12565

Closed

upgrade closure compiler to v20180610 #12558

Closed

erwinmombay approved these changes Dec 21, 2017

View reviewed changes

rsimha merged commit 8debbfd into ampproject:master Dec 21, 2017

rsimha deleted the 2017-12-14-UpdateAll branch December 21, 2017 17:06

erwinmombay reviewed Dec 21, 2017

View reviewed changes

This was referenced Dec 21, 2017

Move react-dates, etc. from devDependencies to dependencies #12571

Merged

Update 'yarn add' instructions #12572

Merged

erwinmombay added a commit to erwinmombay/amphtml that referenced this pull request Dec 21, 2017

root process path is different somehow because of ampproject#12472

46d197a

erwinmombay added a commit to erwinmombay/amphtml that referenced this pull request Dec 21, 2017

root process path is different somehow because of ampproject#12472

0ac3d2f

erwinmombay added a commit that referenced this pull request Dec 21, 2017

root process path is different somehow because of #12472 (#12574)

171e033

gzgogo pushed a commit to gzgogo/amphtml that referenced this pull request Jan 26, 2018

Update all devDependencies (ampproject#12472)

8850583

gzgogo pushed a commit to gzgogo/amphtml that referenced this pull request Jan 26, 2018

root process path is different somehow because of ampproject#12472 (a…

210dcd3

…mpproject#12574)

erwinmombay reviewed Feb 27, 2018

View reviewed changes

rsimha mentioned this pull request Jun 5, 2018

Avoid document-register-element changes in Chrome 67+ #15728

Closed

Conversation

rsimha commented Dec 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rsimha commented Dec 18, 2017

Uh oh!

rsimha commented Dec 18, 2017

Uh oh!

erwinmombay Dec 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rsimha Dec 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rsimha commented Dec 20, 2017

Uh oh!

erwinmombay commented Dec 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erwinmombay Dec 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rsimha commented Dec 14, 2017 •

edited

Loading

erwinmombay Dec 18, 2017 •

edited

Loading

rsimha Dec 18, 2017 •

edited

Loading

erwinmombay commented Dec 21, 2017 •

edited

Loading

erwinmombay Dec 21, 2017 •

edited

Loading