Update sinon version to 4.0#12476
Merged
rsimha merged 2 commits intoampproject:masterfrom Dec 15, 2017
rsimha:2017-12-14-UpgradeSinon
Merged
Update sinon version to 4.0#12476rsimha merged 2 commits intoampproject:masterfrom rsimha:2017-12-14-UpgradeSinon
rsimha merged 2 commits intoampproject:masterfrom
rsimha:2017-12-14-UpgradeSinon
Conversation
Contributor
Author
|
/to @erwinmombay @choumx |
Contributor
Author
|
/to @jridgewell |
erwinmombay
approved these changes
Dec 15, 2017
This was referenced Dec 18, 2017
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
sinonlibrary used by the AMP tests from version 2 to version 4. It also fixes the numerous invalidstubcalls found in the tests.Invalid:
Valid:
See http://sinonjs.org/releases/v3.0.0/migrating-to-3.0/
Partial fix for #12181