Update mocha, karma, and all related deps to their latest versions#12499
Merged
rsimha merged 4 commits intoampproject:masterfrom Dec 18, 2017
rsimha:2017-12-18-MochaKarma
Merged
Update mocha, karma, and all related deps to their latest versions#12499rsimha merged 4 commits intoampproject:masterfrom rsimha:2017-12-18-MochaKarma
rsimha merged 4 commits intoampproject:masterfrom
rsimha:2017-12-18-MochaKarma
Conversation
Contributor
Author
|
/to @erwinmombay @choumx |
erwinmombay
approved these changes
Dec 18, 2017
Contributor
Author
cathyxz
reviewed
Dec 18, 2017
| return ampAd.implementation_.upgradeCallback().then(() => { | ||
| done(); | ||
| }); | ||
| return ampAd.implementation_.upgradeCallback(); |
Contributor
There was a problem hiding this comment.
So is the new best practice just to return Promises and no longer to use done? Or does it not matter so long as it's consistent?
Contributor
There was a problem hiding this comment.
Oh nvm. It doesn't matter so long as you're consistent. This change is just because this throws an exception now. Sorry--should have clicked through to the attached links.
Contributor
Author
There was a problem hiding this comment.
Yep. If you're returning a Promise, the call to done() used to be ignored, but it now flags an error.
This was referenced Dec 18, 2017
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
mocha,karma, all their dependencies, and related tools to their latest versions.connectOptions(which contained a hard-coded port number) fromkarma.conf.js(See Tests not working on Sauce Labs karma-runner/karma-sauce-launcher#145 (comment))List of packages updated:
Partial fix for #12181