create and commit golden css#12526
Merged
erwinmombay merged 2 commits intoampproject:masterfrom Dec 20, 2017
Merged
Conversation
3e74fe4 to
92e2753
Compare
Member
Author
|
@rsimha-amp PTAL |
92e2753 to
b66d254
Compare
8316539 to
0544615
Compare
rsimha
approved these changes
Dec 19, 2017
Contributor
rsimha
left a comment
There was a problem hiding this comment.
Thanks for working on this!
| */ | ||
|
|
||
| /** | ||
| * Horizontal scrolling interferes with embedded scenarios and predominantly |
Contributor
There was a problem hiding this comment.
Perhaps replace this with a file-level comment explaining why this file exists?
dbdedd2 to
f2c16b5
Compare
f2c16b5 to
4ac3003
Compare
Contributor
|
@erwinmombay Once this is merged, can you provide instructions for how to test with the golden file? I'll have to do a before / after check for #12512. |
Member
Author
|
@rsimha-amp just need to regenerate the css golden file and we can take a look at the diff of the file and evaluate if everything is safe. (there are some options that need to change i think like the field i pointed out in https://github.com/ampproject/amphtml/blob/master/build-system/tasks/create-golden-css/index.js#L23) |
Contributor
|
Got it. Tested and updated golden file. Thanks! |
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
* add create-golden-css task * add explaination why main.css exists and what it's used for
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create golden css files so we can see what changes from css transformation dependency changes like postcss, cssnano, etc on upgrade