Move react-dates, etc. from devDependencies to dependencies#12571
Merged
rsimha merged 1 commit intoampproject:masterfrom Jan 4, 2018
rsimha:2017-12-21-ReactDates
Merged
Move react-dates, etc. from devDependencies to dependencies#12571rsimha merged 1 commit intoampproject:masterfrom rsimha:2017-12-21-ReactDates
rsimha merged 1 commit intoampproject:masterfrom
rsimha:2017-12-21-ReactDates
Conversation
Contributor
Author
|
/to @erwinmombay @cvializ |
Contributor
Author
|
It's possible that the only package that needs to move to Will let @cvializ comment further. |
Contributor
Author
|
@cvializ Ping. |
Member
|
@rsimha-amp @cvializ might be on vacation, if i remember correctly what he told me |
Contributor
Author
|
@erwinmombay Calendar didn't seem to suggest that, but you may be right. Since there's no upcoming release soon, we can leave this until after the holidays :) |
Contributor
Author
|
Rebased. Bumping this. |
cvializ
approved these changes
Jan 4, 2018
Contributor
cvializ
left a comment
There was a problem hiding this comment.
I don't see any issues with that, LGTM
Contributor
Author
|
@cvializ Thanks for checking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to the discussion in #12472 (review)
In #12016 and #12456, @cvializ added a bunch of packages to
devDependencieswhile writing a new date picker component for the AMP runtime. It's possible that some of those should actually go intodependencies. See these diffs for the full list of packages that were added.https://github.com/ampproject/amphtml/pull/12016/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2.
https://github.com/ampproject/amphtml/pull/12456/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2
This PR moves the packages required by the date picker from
devDependenciestodependenciesand reverts them to their originally added versions.Follows up #11368, #12016, #12456, and #12472
Partial fix for #12181