[BEAM-12511] Add ability to use withResult without statement.#17
Merged
daria-malkova merged 36 commits intomasterfrom Sep 8, 2021
Merged
[BEAM-12511] Add ability to use withResult without statement.#17daria-malkova merged 36 commits intomasterfrom
daria-malkova merged 36 commits intomasterfrom
Conversation
checkstyle errors spotless restore nullness check suppression spotless supress nullness warning in checkpointmark''
…s in the MonitoringInfo (urn and labels).
Fixing typo: istall => install
There was a problem hiding this comment.
It's comment still actual?
Author
There was a problem hiding this comment.
I don't quite understand what the comment meant. So I can't say for sure whether it is relevant or not.
There was a problem hiding this comment.
Could we use checkNotNull?
Author
There was a problem hiding this comment.
I used "checkArgument" according to the style of others checks in this module.
Comment on lines
1253
to
1501
There was a problem hiding this comment.
Could we use checkNotNull?
Author
There was a problem hiding this comment.
I used "checkArgument" according to the style of others checks in this module.
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
Outdated
Show resolved
Hide resolved
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
Outdated
Show resolved
Hide resolved
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
That really auto generated class?
Author
There was a problem hiding this comment.
No, this class automatically generates a preparedStatementSetter.
There was a problem hiding this comment.
So maybe rename it in something like PreparedStatementSetterGenerator?
Author
There was a problem hiding this comment.
This is not a generator, Since its instance is already a "PreparedStatementSetter" but not an object that generates "PreparedStatementSetter".
Vendored gRPC 1.36.0 was using a log4j version with security issues. gRPC does not declare log4j dependency. It uses java.util.logging for logging. Therefore removing the dependency.
…quest and MonitoringInfosMetadataRequest/Response support to Java SDK.
…ionality (apache#14806) [BEAM-11289] [Python] Integrate Google Cloud Recommendations AI functionality
… unnecessary log4j-api dependency
@jrmccluskey noticed that the current instructions assume the `go test ./...` work at beam root. This hasn't been true since the katas were added. Instructions have been added to make the current Go version support for development clearer.
* [BEAM-12548] Add EqualsList functionality, corresponding unit tests. Also refactors equals_test.go to use better naming conventions * [BEAM-12548] Add clarifying comment to EqualsList
601bd82 to
0b52275
Compare
* Add MatchContinuously PTransform * Add MatchContinuously PTransform * Add MatchContinuously PTransform * Add MatchContinuously PTransform
…ob (apache#15107) * [BEAM-10955] Testing could not find Flink job * [BEAM-10955] Add waitJobToBeReady call, test fix for Flink job not found flakiness * [BEAM-10955] Remove unused import * [BEAM-10955] Discard changes in website folder, remove loop used for testing
…AT64, INT64 BigQuery types [BEAM-10176] Support STRUCT, FLOAT64, INT64 BigQuery types
…pache#15112) * [BEAM-12548] Add examples of Equals and EqualsList to equals_test.go * [BEAM-12548] Update EqualsList failure example to use a helper for unwrapping the error * [BEAM-12548] Update helper and example to follow better go practices
…to detect a compatible logger internally
…tadata (apache#15028) * Adds a Kafka external read transform for reading from Kafka with metadata * updates * Fixes the example * Updates URNs * Addresses reviewer comments * Changes the default to preserve backwards compatiblity
…ect which logger is available automatically
…/ return_type warning
* [BEAM-12513] Update initial sections of BPG for Go * [BEAM-12513] Reformat code to be easier to find * [BEAM-12513] Add scoping and additional comments. Co-authored-by: Jack McCluskey <34928439+jrmccluskey@users.noreply.github.com>
…ific project id property * [BEAM-12468] added bigquery specific project id property * [BEAM-12468] add unit tests Signed-off-by: Ricki Purnomo <rpurnomo@corelogic.com> Co-authored-by: Ricki Purnomo <rpurnomo@corelogic.com> Co-authored-by: Shan Lin Tsai <stsai@corelogic.com> Co-authored-by: Dave Miller <davemiller@corelogic.com> * [BEAM-12468] fix spotless checks Signed-off-by: Ricki Purnomo <rpurnomo@corelogic.com> Co-authored-by: Ricki Purnomo <rpurnomo@corelogic.com> Co-authored-by: Nikita Petunin <npetunin@corelogic.com> Co-authored-by: Shan Lin Tsai <stsai@corelogic.com> Co-authored-by: stsai-clgx <51134904+stsai-clgx@users.noreply.github.com> Co-authored-by: Ricki Purnomo <rpurnomo@corelogic.com> Co-authored-by: Shan Lin Tsai <stsai@corelogic.com> Co-authored-by: Dave Miller <davemiller@corelogic.com>
…ngInfosRequest/Response InstructionRequest and MonitoringInfosMetadataRequest/Response support to Java SDK. [BEAM-11994] Add HarnessMonitoringInfosRequest/Response InstructionRequest and MonitoringInfosMetadataRequest/Response support to Java SDK.
27f2f6b to
82f883b
Compare
…ement and preparedStatementSetter.
82f883b to
312df3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to use "JdbcIO.Write.withResults" without statement and preparedStatementSetter.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.