[BEAM-12468] added bigquery specific project id property#14980
Merged
pabloem merged 3 commits intoapache:masterfrom Jul 2, 2021
Merged
[BEAM-12468] added bigquery specific project id property#14980pabloem merged 3 commits intoapache:masterfrom
pabloem merged 3 commits intoapache:masterfrom
Conversation
Member
|
Run Java PreCommit |
2 similar comments
Member
|
Run Java PreCommit |
Member
|
Run Java PreCommit |
Member
|
This looks good actually. Is there any chance you could add a unit test for it? Some of these calls are hard to test, so it's not mandatory, but it would be great to have one. |
Signed-off-by: Ricki Purnomo <rpurnomo@corelogic.com> Co-authored-by: Ricki Purnomo <rpurnomo@corelogic.com> Co-authored-by: Shan Lin Tsai <stsai@corelogic.com> Co-authored-by: Dave Miller <davemiller@corelogic.com>
Member
|
thanks a lot for adding the tests! and an annotation for them too. It's great. The RAT test failure is because the new annotation file needs the Apache License header at the top of it (you can copy from any other file). To fix spotless checks you can run Once the tests are passing, I'll merge the change. Thanks! |
Signed-off-by: Ricki Purnomo <rpurnomo@corelogic.com> Co-authored-by: Ricki Purnomo <rpurnomo@corelogic.com> Co-authored-by: Nikita Petunin <npetunin@corelogic.com> Co-authored-by: Shan Lin Tsai <stsai@corelogic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional property for BigQuery to set an alternative project ID (other than main project ID in GcpOptions)