[BEAM-8473] Fix generator send_type / return_type warning#15061
Merged
udim merged 1 commit intoapache:masterfrom Jul 2, 2021
alexkoay:generator_hint
Merged
[BEAM-8473] Fix generator send_type / return_type warning#15061udim merged 1 commit intoapache:masterfrom alexkoay:generator_hint
udim merged 1 commit intoapache:masterfrom
alexkoay:generator_hint
Conversation
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## master #15061 +/- ##
==========================================
+ Coverage 83.76% 84.23% +0.46%
==========================================
Files 439 441 +2
Lines 59132 61480 +2348
==========================================
+ Hits 49534 51786 +2252
- Misses 9598 9694 +96
Continue to review full report at Codecov.
|
Member
|
Run Python PreCommit |
udim
approved these changes
Jun 30, 2021
Member
|
Run Python PreCommit |
1 similar comment
Member
|
Run Python PreCommit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the generator warning when None is used -- it was checking for None, while the typehint actually returns NoneType.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.