[BEAM-12569] Expose ReadAllFromTFRecord as public in tfrecordio#15114
Merged
aaltay merged 1 commit intoapache:masterfrom Jul 2, 2021
Merged
[BEAM-12569] Expose ReadAllFromTFRecord as public in tfrecordio#15114aaltay merged 1 commit intoapache:masterfrom
aaltay merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
Hey @aaltay and @charlesccychen , please review this. cc: @xinyuiscool |
aaltay
approved these changes
Jul 1, 2021
Member
|
Run Python PreCommit |
Codecov Report
@@ Coverage Diff @@
## master #15114 +/- ##
==========================================
- Coverage 83.79% 83.78% -0.02%
==========================================
Files 441 441
Lines 59530 59559 +29
==========================================
+ Hits 49886 49901 +15
- Misses 9644 9658 +14
Continue to review full report at Codecov.
|
Contributor
|
Run Python PreCommit |
1 similar comment
Contributor
|
Run Python PreCommit |
dxichen
pushed a commit
to linkedin/beam
that referenced
this pull request
Aug 9, 2021
RB=2681671 G=samza-reviewers R=xiliu A=xiliu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tfrecordio module provides ReadAllFromTFRecord class but doesn't publicly expose it. Using it causes the following error-
AttributeError: module 'apache_beam.io' has no attribute 'ReadAllFromTFRecord'
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.