[BEAM-10937] Tour of Beam Windowing notebook#14962
Merged
aaltay merged 2 commits intoapache:masterfrom Jul 2, 2021
Merged
Conversation
aaltay
requested changes
Jun 8, 2021
Contributor
|
Overall looks great. Gardening project, moon phases, the notebook has got personality and I like it a lot :) Some comments as I was going through the notebook:
|
Member
|
What is the next step on this PR? Could you address the open comments? |
Author
Thanks, done.
Changed
Changed
Changed
I actually ended up inlining the data on each snippet. It makes each sample a little more self contained, and simplified some indirection. It also makes it easier for people to modify the inputs and see how it affects things. |
Author
aaltay
approved these changes
Jul 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Windowing notebook for the Tour of Beam.
R: @aaltay
FYI: @anguillanneuf
Staged:
Notebook: https://colab.research.google.com/github/davidcavazos/beam/blob/tour-of-beam/examples/notebooks/tour-of-beam/windowing.ipynb
Page entry: http://apache-beam-website-pull-requests.storage.googleapis.com/14962/get-started/tour-of-beam/index.html
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.