[BEAM-12548] Add EqualsList functionality to PAssert#15110
Merged
lostluck merged 4 commits intoapache:masterfrom Jun 30, 2021
Merged
[BEAM-12548] Add EqualsList functionality to PAssert#15110lostluck merged 4 commits intoapache:masterfrom
lostluck merged 4 commits intoapache:masterfrom
Conversation
…Also refactors equals_test.go to use better naming conventions
Contributor
Author
|
R: @lostluck |
lostluck
approved these changes
Jun 30, 2021
Contributor
lostluck
left a comment
There was a problem hiding this comment.
One comment, after which this is good to be merged in. Thanks!
Contributor
|
Thank you! Welcome to being a Beam Contributor. I'll merge once the precommits pass. (They should, since it was only a comment change.) |
Contributor
|
Run GoPortable PreCommit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements EqualsList, a testing helper to compare the contents of a PCollection to the contents of an array or slice. Also adds corresponding unit tests and refactors equals_test.go to use more precise naming conventions.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.