Rip out owner pays fee and xrpl abandon#5550
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5550 +/- ##
=======================================
Coverage 78.4% 78.4%
=======================================
Files 816 816
Lines 71733 71730 -3
Branches 8598 8598
=======================================
- Hits 56238 56237 -1
+ Misses 15495 15493 -2
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
ximinez
requested changes
Jul 18, 2025
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
…ee-and-XRPL_ABANDON' into a1q123456/rip-out-owner-pays-fee-and-XRPL_ABANDON
ximinez
requested changes
Jul 21, 2025
Co-authored-by: Ed Hennis <ed@ripple.com>
bthomee
approved these changes
Jul 23, 2025
ximinez
added a commit
that referenced
this pull request
Jul 24, 2025
…to ximinez/lending-refactoring-3 * XRPLF/ximinez/lending-refactoring-2: refactor: Update rocksdb (#5568) Switch instrumentation workflow to use dependencies (#5607) chore: Rename conan profile to `default` (#5599) Include `network_id` in validations and subscription stream responses (#5579) Add support for `DomainID` in `MPTokenIssuance` transactions (#5509) chore: Remove unused code after flow cross retirement (#5575) Remove obsolete owner pays fee feature and XRPL_ABANDON stanza (#5550) refactor: Makes HashRouter flags more type-safe (#5371) Fix clang-format CI job (#5598)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
As discussed, if a feature is never voted on then it should be safe to remove.