Include network_id in subscription stream response#5579
Merged
bthomee merged 6 commits intoXRPLF:developfrom Jul 23, 2025
Merged
Include network_id in subscription stream response#5579bthomee merged 6 commits intoXRPLF:developfrom
network_id in subscription stream response#5579bthomee merged 6 commits intoXRPLF:developfrom
Conversation
…is commit also includes unit tests to validate the response fields
… Update unit tests to validate response of ledger-subscription-stream
network_id in subscription stream response
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5579 +/- ##
=======================================
Coverage 78.8% 78.8%
=======================================
Files 814 814
Lines 71163 71205 +42
Branches 8354 8333 -21
=======================================
+ Hits 56042 56105 +63
+ Misses 15121 15100 -21
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
godexsoft
approved these changes
Jul 18, 2025
Contributor
godexsoft
left a comment
There was a problem hiding this comment.
Looks good. Here is an issue in Clio that will implement this in the future: XRPLF/clio#2350
Collaborator
Author
|
Thanks for the quick review guys 🙇♂️ |
Collaborator
Author
|
Thanks for the reviews 🙇♂️ @a1q123456 @godexsoft @PeterChen13579 |
Collaborator
Author
|
Hello, I'd prefer this to be the commit message: |
ximinez
added a commit
that referenced
this pull request
Jul 24, 2025
…to ximinez/lending-refactoring-3 * XRPLF/ximinez/lending-refactoring-2: refactor: Update rocksdb (#5568) Switch instrumentation workflow to use dependencies (#5607) chore: Rename conan profile to `default` (#5599) Include `network_id` in validations and subscription stream responses (#5579) Add support for `DomainID` in `MPTokenIssuance` transactions (#5509) chore: Remove unused code after flow cross retirement (#5575) Remove obsolete owner pays fee feature and XRPL_ABANDON stanza (#5550) refactor: Makes HashRouter flags more type-safe (#5371) Fix clang-format CI job (#5598)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR aims to include
network_idvalue inside thevalidationsand theledgersubscription stream. This helps downstream consumers disambiguate between different XRPL networks. Appropriate unit tests have been updated to this effect.The benefits of this feature have been voiced in this Issue Description. As a concrete example, the proposed change will remove a lot of cruft from the technical design of Validator-History-Service (VHS).
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
Public API: New feature (new methods and/or new fields)
New field (
network_id) has been added to two of the subscription streams. This is not a breaking change. None of the existing API surface is impacted by this PR.Public API: Breaking change (in general, breaking changes should only impact the next api_version)
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)Peer protocol change (must be backward compatible or bump the peer protocol version)
I do not expect any significant changes to the performance. This change only adds a new field into the WebSocket stream API.
Appropriate tests have been updated in this PR. I don't see the need for any future work (or) additional tests.
However, should this PR be approved, we will need to update the documentation of the
subscribecommand to reflect the new response fields.