Add support for DomainID in MPTokenIssuance transactions#5509
Merged
Add support for DomainID in MPTokenIssuance transactions#5509
DomainID in MPTokenIssuance transactions#5509Conversation
DomainID in MPTokenIssuance transactions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5509 +/- ##
=======================================
Coverage 78.8% 78.8%
=======================================
Files 814 814
Lines 71163 71201 +38
Branches 8354 8331 -23
=======================================
+ Hits 56042 56106 +64
+ Misses 15121 15095 -26
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
300fe81 to
b486cdf
Compare
gregtatcam
reviewed
Jul 1, 2025
13ae4bd to
87282f2
Compare
gregtatcam
reviewed
Jul 2, 2025
vlntb
reviewed
Jul 23, 2025
vlntb
reviewed
Jul 23, 2025
vlntb
reviewed
Jul 23, 2025
vlntb
reviewed
Jul 23, 2025
Contributor
vlntb
left a comment
There was a problem hiding this comment.
Looks good.
Couple of nit comments. Happy to approve otherwise.
vlntb
approved these changes
Jul 23, 2025
ximinez
added a commit
that referenced
this pull request
Jul 24, 2025
…to ximinez/lending-refactoring-3 * XRPLF/ximinez/lending-refactoring-2: refactor: Update rocksdb (#5568) Switch instrumentation workflow to use dependencies (#5607) chore: Rename conan profile to `default` (#5599) Include `network_id` in validations and subscription stream responses (#5579) Add support for `DomainID` in `MPTokenIssuance` transactions (#5509) chore: Remove unused code after flow cross retirement (#5575) Remove obsolete owner pays fee feature and XRPL_ABANDON stanza (#5550) refactor: Makes HashRouter flags more type-safe (#5371) Fix clang-format CI job (#5598)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Add support for
DomainIDto existing transactionsMPTokenIssuanceCreateandMPTokenIssuanceSetContext of Change
In #5224 we added
DomainIDas an access control mechanism forSingleAssetVault. The actual implementation of this feature lies inMPTokenandMPTokenIssuance, hence it makes sense to enable the use ofDomainIDalso inMPTokenIssuanceCreateandMPTokenIssuanceSet, following same rules as in Vault:MPTokenIssuanceCreateandMPTokenIssuanceSetcan only setDomainIDif flagMPTRequireAuthis setMPTokenIssuanceCreaterequires thatDomainIDbe a non-zero, uint256 numberMPTokenIssuanceSetallowsDomainIDto be zero (or empty) in which case it will removeDomainIDfrom theMPTokenIssuanceobjectThe change is amendment-gated by
SingleAssetVault.This is a non-breaking change because
SingleAssetVaultamendment isSupported::no, i.e. at this moment considered a work in progress, which cannot be enabled on the network.Type of Change
.gitignore, formatting, dropping support for older tooling)