Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5568 +/- ##
=========================================
- Coverage 78.8% 78.8% -0.0%
=========================================
Files 814 814
Lines 71204 71204
Branches 8335 8335
=========================================
- Hits 56103 56102 -1
- Misses 15101 15102 +1 see 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@ximinez can you please take this PR for a spin on your Windows machine, to make sure it builds fine? Although it builds on the Windows CI runners, the |
ximinez
approved these changes
Jul 24, 2025
Collaborator
ximinez
left a comment
There was a problem hiding this comment.
Builds and runs tests successfully in my Windows environment, in all configurations that I usually use.
ximinez
added a commit
that referenced
this pull request
Jul 24, 2025
…to ximinez/lending-refactoring-3 * XRPLF/ximinez/lending-refactoring-2: refactor: Update rocksdb (#5568) Switch instrumentation workflow to use dependencies (#5607) chore: Rename conan profile to `default` (#5599) Include `network_id` in validations and subscription stream responses (#5579) Add support for `DomainID` in `MPTokenIssuance` transactions (#5509) chore: Remove unused code after flow cross retirement (#5575) Remove obsolete owner pays fee feature and XRPL_ABANDON stanza (#5550) refactor: Makes HashRouter flags more type-safe (#5371) Fix clang-format CI job (#5598)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR updates RocksDB to its latest version. RocksDB is backward-compatible, so even though this is a major version bump, databases created with previous versions will continue to function.
The external RocksDB folder is removed, as the latest version available via Conan Center no longer needs custom patches.
Context of Change
Updating dependencies is now possible due to the switch to Conan 2.
Type of Change
.gitignore, formatting, dropping support for older tooling)