Add XRPL_ABANDON and use it to abandon OwnerPaysFee#5510
Merged
Conversation
Bronek
reviewed
Jun 25, 2025
Bronek
reviewed
Jun 25, 2025
Bronek
reviewed
Jun 25, 2025
Bronek
reviewed
Jun 25, 2025
Bronek
reviewed
Jun 25, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5510 +/- ##
=======================================
Coverage 79.1% 79.1%
=======================================
Files 817 817
Lines 71704 71706 +2
Branches 8235 8240 +5
=======================================
+ Hits 56725 56731 +6
+ Misses 14979 14975 -4
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
ecfbe28 to
033b8cc
Compare
Bronek
approved these changes
Jun 26, 2025
a1q123456
added a commit
that referenced
this pull request
Jul 10, 2025
This reverts commit df6daf0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
As a follow up PR for #5435, we want to have a separate macro to describe the case where a feature has never been implemented properly and has never been enabled. This PR adds XRPL_ABANDON and moves OnwerPaysFee in features.macro to it's the abandoned section.
Context of Change
This PR makes it clear that OwnerPaysFee is an abandoned feature and we can use this macro for other features in the future.
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
There's no API impact