Skip to content

Conversation

@salhus
Copy link
Contributor

@salhus salhus commented Jun 8, 2022

There are some situations when the WAMIT output files do not have the $A_\infty$ term. Like discussed here,
image

This PR modifies the readWAMIT.m and writeBEMIOH5.m files to use the last term of the added-mass as a substitute instead.

kmruehl and others added 3 commits May 20, 2022 11:16
@salhus salhus requested review from dav-og and nathanmtom June 8, 2022 22:40
@nathanmtom
Copy link

@salhus Thanks for trying to find a way to address the situations where the infinite frequency added mass is not calculated in WAMIT with the appropriate free surface boundary condition.

I am wondering why you chose to take the highest frequency added mass to represent the infinite frequency added mass? In the 'radiationIRF.m', lines 68-82 we use the expression for the inverse Fourier Transform of the time domain IRF to estimate the infinite frequency for NEMOH as the code also has issues with solving for the infinite frequency added mass.

My thought was that this process could also be used for cases where WAMIT does not report the infinite frequency added mass, but perhaps you have thoughts on this.

mancellin and others added 3 commits June 29, 2022 09:23
* Update tutorials to fix OSWEC inertia

* Update terminology.rst

* Update tutorials.rst

changed OSWEC Iyy and added note

Co-authored-by: Kelley Ruehl <kmruehl@sandia.gov>
…h | Add 2021b to MATLAB versions (#862)

* Split docs CI into test and build jobs

This PR splits the docs CI workflow into two independent jobs. The
first "test" job checks the current branch with any warnings
triggering a failure. The second jobs builds and deploys the
production docs, allowing any warnings to pass. This allows the
commit author to see any new issues they may be adding to the docs
while not stopping the docs being published.

* Try to get color output in log

* Remove redundant steps for branch test

* Fix duplicate targets using anonymous references

* Cancel previous runs if new commits are made

* Fix spelling mistake to test concurrency

* Limit concurrency to pull requests for the unit tests

This is to ensure all commits on the master and dev branches are
tested, which will be important if we are going to measure
coverage using an external service like codecov.

* Fix another spelling mistake

* Add R2021b to explicit MATLAB versions tested
@kmruehl kmruehl added the BEM/BEMIO related to BEMIO or BEM hydro data label Jun 29, 2022
kmruehl and others added 5 commits June 29, 2022 09:46
* Moved simulationClass.outputDir to public.

* Replaced paths with fullfile paths in CompareBEMIO.m. The paths didd not work on Mac due to file separator.

* Update line 38 in reaadAQWA.m so it works on a Mac.

* change filesep in BEMIO examples, update readAQWA fileparts

* Update stopWecSim.m

Replaced hardcoded 'output' string with simu.outputDir.

* Removed clc and close all from initializeWecSim.

It should be up to the user to clear the command windows and close the figures.

Co-authored-by: Lermart96 <anders.brandt@oceanharvesting.com>
Co-authored-by: akeeste <akeeste@sandia.gov>
* Update stopWecSim.m

* Update initializeWecSim.m

* Update wecSimPCT.m
@kmruehl
Copy link
Collaborator

kmruehl commented Jul 1, 2022

@salhus can you convert this to a draft until it's ready for review?

@salhus salhus marked this pull request as draft July 6, 2022 14:52
@kmruehl kmruehl closed this Jul 13, 2022
@kmruehl kmruehl reopened this Jul 13, 2022
akeeste and others added 5 commits July 27, 2022 19:36
* update to v5.0 citation

* moving citation page to release notes

* adding some news articles

Co-authored-by: kmruehl <kmruehl@sandia.gov>
@salhus salhus closed this Aug 24, 2022
@salhus salhus deleted the Ainf_fix branch September 8, 2022 17:53
kmruehl pushed a commit that referenced this pull request Sep 21, 2022
* Calculation_of_Ainf_using_radiationIRF.m

This PR follows #880 and #938
If the added-mass infinity was missing from the BEM run, radiationIRF function calculates the Added-mass at infinity.
However, this only happens for non-WAMIT BEM codes.
This PR generates the added-mass at infinity, if it is missing from the BEM run regardless of the BEM code.

* check_normalizeBEM

* check_for_modified_readWAMIT

* only_change_radiationIRF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BEM/BEMIO related to BEMIO or BEM hydro data

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants