-
Notifications
You must be signed in to change notification settings - Fork 184
Ainf fixes for hydro and h5 files #880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
adding dev and master build status to README
|
@salhus Thanks for trying to find a way to address the situations where the infinite frequency added mass is not calculated in WAMIT with the appropriate free surface boundary condition. I am wondering why you chose to take the highest frequency added mass to represent the infinite frequency added mass? In the 'radiationIRF.m', lines 68-82 we use the expression for the inverse Fourier Transform of the time domain IRF to estimate the infinite frequency for NEMOH as the code also has issues with solving for the infinite frequency added mass. My thought was that this process could also be used for cases where WAMIT does not report the infinite frequency added mass, but perhaps you have thoughts on this. |
* Update tutorials to fix OSWEC inertia * Update terminology.rst * Update tutorials.rst changed OSWEC Iyy and added note Co-authored-by: Kelley Ruehl <kmruehl@sandia.gov>
…h | Add 2021b to MATLAB versions (#862) * Split docs CI into test and build jobs This PR splits the docs CI workflow into two independent jobs. The first "test" job checks the current branch with any warnings triggering a failure. The second jobs builds and deploys the production docs, allowing any warnings to pass. This allows the commit author to see any new issues they may be adding to the docs while not stopping the docs being published. * Try to get color output in log * Remove redundant steps for branch test * Fix duplicate targets using anonymous references * Cancel previous runs if new commits are made * Fix spelling mistake to test concurrency * Limit concurrency to pull requests for the unit tests This is to ensure all commits on the master and dev branches are tested, which will be important if we are going to measure coverage using an external service like codecov. * Fix another spelling mistake * Add R2021b to explicit MATLAB versions tested
* Moved simulationClass.outputDir to public. * Replaced paths with fullfile paths in CompareBEMIO.m. The paths didd not work on Mac due to file separator. * Update line 38 in reaadAQWA.m so it works on a Mac. * change filesep in BEMIO examples, update readAQWA fileparts * Update stopWecSim.m Replaced hardcoded 'output' string with simu.outputDir. * Removed clc and close all from initializeWecSim. It should be up to the user to clear the command windows and close the figures. Co-authored-by: Lermart96 <anders.brandt@oceanharvesting.com> Co-authored-by: akeeste <akeeste@sandia.gov>
* Update stopWecSim.m * Update initializeWecSim.m * Update wecSimPCT.m
|
@salhus can you convert this to a draft until it's ready for review? |
* update to v5.0 citation * moving citation page to release notes * adding some news articles Co-authored-by: kmruehl <kmruehl@sandia.gov>
* Calculation_of_Ainf_using_radiationIRF.m This PR follows #880 and #938 If the added-mass infinity was missing from the BEM run, radiationIRF function calculates the Added-mass at infinity. However, this only happens for non-WAMIT BEM codes. This PR generates the added-mass at infinity, if it is missing from the BEM run regardless of the BEM code. * check_normalizeBEM * check_for_modified_readWAMIT * only_change_radiationIRF
There are some situations when the WAMIT output files do not have the$A_\infty$ term. Like discussed here,

This PR modifies the readWAMIT.m and writeBEMIOH5.m files to use the last term of the added-mass as a substitute instead.