Skip to content

Conversation

@yuyihsiang
Copy link
Contributor

Fixed a few bugs, which cause WEC-Sim to crash when running wecSimPCT:

  • "initializeWecSim.m": Change the project directory and move the "temp" inside the pctDir folder so that each WEC-Sim run won't interfere.
  • "stopWecSim.m": Move the command cd (['..' filesep pctDir filesep '..' filesep]); inside the "if simu.saveWorkspace==1" if loop. The command is only needed when WEC-Sim writes out the output file.
  • "wecSimPCT.m" : Remove the pctDirs after the simulation.

@yuyihsiang yuyihsiang changed the title wecSimPCT fix wecSimPCT Fix (Master) May 23, 2022
@kmruehl kmruehl self-assigned this Jun 29, 2022
@kmruehl kmruehl added MCR/PCT multiple condition runs (wecSimMCR) and/or parallel computing toolbox (wecSimPCT) Bug bug in WEC-Sim source, high priority labels Jun 29, 2022
Copy link
Collaborator

@kmruehl kmruehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuyihsiang. I haven't been able to reproduce this bug, so we think it may be a MAC OS bug, but I was able to run this version without issue, so I'll go ahead and merge it.

@kmruehl kmruehl merged commit f9ac900 into WEC-Sim:master Jul 1, 2022
@akeeste akeeste mentioned this pull request Jul 1, 2022
akeeste added a commit that referenced this pull request Jul 1, 2022
* Update README.md

adding dev and master build status to README

* adding v5.0 release notes

* Fix typo in docs. (#898)

* Update documentation tutorials to fix OSWEC inertia (#894)

* Update tutorials to fix OSWEC inertia

* Update terminology.rst

* Update tutorials.rst

changed OSWEC Iyy and added note

Co-authored-by: Kelley Ruehl <kmruehl@sandia.gov>

* CI: Split docs jobs | Add color to docs logs | Cancel runs on new push | Add 2021b to MATLAB versions (#862)

* Split docs CI into test and build jobs

This PR splits the docs CI workflow into two independent jobs. The
first "test" job checks the current branch with any warnings
triggering a failure. The second jobs builds and deploys the
production docs, allowing any warnings to pass. This allows the
commit author to see any new issues they may be adding to the docs
while not stopping the docs being published.

* Try to get color output in log

* Remove redundant steps for branch test

* Fix duplicate targets using anonymous references

* Cancel previous runs if new commits are made

* Fix spelling mistake to test concurrency

* Limit concurrency to pull requests for the unit tests

This is to ensure all commits on the master and dev branches are
tested, which will be important if we are going to measure
coverage using an external service like codecov.

* Fix another spelling mistake

* Add R2021b to explicit MATLAB versions tested

* resolve code struc table bug

* [Bug fix] Mac path fixes and make outputDir public (#874)

* Moved simulationClass.outputDir to public.

* Replaced paths with fullfile paths in CompareBEMIO.m. The paths didd not work on Mac due to file separator.

* Update line 38 in reaadAQWA.m so it works on a Mac.

* change filesep in BEMIO examples, update readAQWA fileparts

* Update stopWecSim.m

Replaced hardcoded 'output' string with simu.outputDir.

* Removed clc and close all from initializeWecSim.

It should be up to the user to clear the command windows and close the figures.

Co-authored-by: Lermart96 <anders.brandt@oceanharvesting.com>
Co-authored-by: akeeste <akeeste@sandia.gov>

* resolving doc language bug

* wecSimPCT Fix (Master) (#870)

* Update stopWecSim.m

* Update initializeWecSim.m

* Update wecSimPCT.m

* Fix image bug in PTO-Sim in Library Browser (#896)

Co-authored-by: Kelley Ruehl <kmruehl@sandia.gov>
Co-authored-by: Matthieu Ancellin <31126826+mancellin@users.noreply.github.com>
Co-authored-by: jtgrasb <87095491+jtgrasb@users.noreply.github.com>
Co-authored-by: Mathew Topper <damm_horse@yahoo.co.uk>
Co-authored-by: Ahmed Rashid <32479811+ahmedmetin@users.noreply.github.com>
Co-authored-by: Lermart96 <anders.brandt@oceanharvesting.com>
Co-authored-by: yuyihsiang <yyu@nycu.edu.tw>
Co-authored-by: Jorge Leon <72461917+jleonqu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug bug in WEC-Sim source, high priority MCR/PCT multiple condition runs (wecSimMCR) and/or parallel computing toolbox (wecSimPCT)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants