Skip to content

Conversation

@jtgrasb
Copy link
Contributor

@jtgrasb jtgrasb commented Jun 24, 2022

This fix is in response to Issue #890 and simply updates the documentation to show the y-component of inertia for the OSWEC rather than the x.

@jtgrasb
Copy link
Contributor Author

jtgrasb commented Jun 27, 2022

Also adds units kg-m^2 to added mass to clarify units for added inertia (addressing Issue #891).

@dforbush2 dforbush2 self-assigned this Jun 29, 2022
changed OSWEC Iyy and added note
@kmruehl kmruehl merged commit ae31e9b into WEC-Sim:master Jun 29, 2022
@kmruehl
Copy link
Collaborator

kmruehl commented Jun 29, 2022

@jtgrasb this is merged, you may want to delete your branch now

@jtgrasb jtgrasb deleted the OSWEC_Inertia branch June 29, 2022 17:40
@akeeste akeeste mentioned this pull request Jun 29, 2022
akeeste added a commit that referenced this pull request Jul 1, 2022
* Update README.md

adding dev and master build status to README

* adding v5.0 release notes

* Fix typo in docs. (#898)

* Update documentation tutorials to fix OSWEC inertia (#894)

* Update tutorials to fix OSWEC inertia

* Update terminology.rst

* Update tutorials.rst

changed OSWEC Iyy and added note

Co-authored-by: Kelley Ruehl <kmruehl@sandia.gov>

* CI: Split docs jobs | Add color to docs logs | Cancel runs on new push | Add 2021b to MATLAB versions (#862)

* Split docs CI into test and build jobs

This PR splits the docs CI workflow into two independent jobs. The
first "test" job checks the current branch with any warnings
triggering a failure. The second jobs builds and deploys the
production docs, allowing any warnings to pass. This allows the
commit author to see any new issues they may be adding to the docs
while not stopping the docs being published.

* Try to get color output in log

* Remove redundant steps for branch test

* Fix duplicate targets using anonymous references

* Cancel previous runs if new commits are made

* Fix spelling mistake to test concurrency

* Limit concurrency to pull requests for the unit tests

This is to ensure all commits on the master and dev branches are
tested, which will be important if we are going to measure
coverage using an external service like codecov.

* Fix another spelling mistake

* Add R2021b to explicit MATLAB versions tested

* resolve code struc table bug

* [Bug fix] Mac path fixes and make outputDir public (#874)

* Moved simulationClass.outputDir to public.

* Replaced paths with fullfile paths in CompareBEMIO.m. The paths didd not work on Mac due to file separator.

* Update line 38 in reaadAQWA.m so it works on a Mac.

* change filesep in BEMIO examples, update readAQWA fileparts

* Update stopWecSim.m

Replaced hardcoded 'output' string with simu.outputDir.

* Removed clc and close all from initializeWecSim.

It should be up to the user to clear the command windows and close the figures.

Co-authored-by: Lermart96 <anders.brandt@oceanharvesting.com>
Co-authored-by: akeeste <akeeste@sandia.gov>

* resolving doc language bug

* wecSimPCT Fix (Master) (#870)

* Update stopWecSim.m

* Update initializeWecSim.m

* Update wecSimPCT.m

* Fix image bug in PTO-Sim in Library Browser (#896)

Co-authored-by: Kelley Ruehl <kmruehl@sandia.gov>
Co-authored-by: Matthieu Ancellin <31126826+mancellin@users.noreply.github.com>
Co-authored-by: jtgrasb <87095491+jtgrasb@users.noreply.github.com>
Co-authored-by: Mathew Topper <damm_horse@yahoo.co.uk>
Co-authored-by: Ahmed Rashid <32479811+ahmedmetin@users.noreply.github.com>
Co-authored-by: Lermart96 <anders.brandt@oceanharvesting.com>
Co-authored-by: yuyihsiang <yyu@nycu.edu.tw>
Co-authored-by: Jorge Leon <72461917+jleonqu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation related to docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants