-
Notifications
You must be signed in to change notification settings - Fork 184
CI: Split docs jobs | Add color to docs logs | Cancel runs on new push | Add 2021b to MATLAB versions #862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR splits the docs CI workflow into two independent jobs. The first "test" job checks the current branch with any warnings triggering a failure. The second jobs builds and deploys the production docs, allowing any warnings to pass. This allows the commit author to see any new issues they may be adding to the docs while not stopping the docs being published.
This is to ensure all commits on the master and dev branches are tested, which will be important if we are going to measure coverage using an external service like codecov.
Collaborator
|
Thanks @H0R5E, merging now |
Merged
akeeste
added a commit
that referenced
this pull request
Jul 1, 2022
* Update README.md adding dev and master build status to README * adding v5.0 release notes * Fix typo in docs. (#898) * Update documentation tutorials to fix OSWEC inertia (#894) * Update tutorials to fix OSWEC inertia * Update terminology.rst * Update tutorials.rst changed OSWEC Iyy and added note Co-authored-by: Kelley Ruehl <kmruehl@sandia.gov> * CI: Split docs jobs | Add color to docs logs | Cancel runs on new push | Add 2021b to MATLAB versions (#862) * Split docs CI into test and build jobs This PR splits the docs CI workflow into two independent jobs. The first "test" job checks the current branch with any warnings triggering a failure. The second jobs builds and deploys the production docs, allowing any warnings to pass. This allows the commit author to see any new issues they may be adding to the docs while not stopping the docs being published. * Try to get color output in log * Remove redundant steps for branch test * Fix duplicate targets using anonymous references * Cancel previous runs if new commits are made * Fix spelling mistake to test concurrency * Limit concurrency to pull requests for the unit tests This is to ensure all commits on the master and dev branches are tested, which will be important if we are going to measure coverage using an external service like codecov. * Fix another spelling mistake * Add R2021b to explicit MATLAB versions tested * resolve code struc table bug * [Bug fix] Mac path fixes and make outputDir public (#874) * Moved simulationClass.outputDir to public. * Replaced paths with fullfile paths in CompareBEMIO.m. The paths didd not work on Mac due to file separator. * Update line 38 in reaadAQWA.m so it works on a Mac. * change filesep in BEMIO examples, update readAQWA fileparts * Update stopWecSim.m Replaced hardcoded 'output' string with simu.outputDir. * Removed clc and close all from initializeWecSim. It should be up to the user to clear the command windows and close the figures. Co-authored-by: Lermart96 <anders.brandt@oceanharvesting.com> Co-authored-by: akeeste <akeeste@sandia.gov> * resolving doc language bug * wecSimPCT Fix (Master) (#870) * Update stopWecSim.m * Update initializeWecSim.m * Update wecSimPCT.m * Fix image bug in PTO-Sim in Library Browser (#896) Co-authored-by: Kelley Ruehl <kmruehl@sandia.gov> Co-authored-by: Matthieu Ancellin <31126826+mancellin@users.noreply.github.com> Co-authored-by: jtgrasb <87095491+jtgrasb@users.noreply.github.com> Co-authored-by: Mathew Topper <damm_horse@yahoo.co.uk> Co-authored-by: Ahmed Rashid <32479811+ahmedmetin@users.noreply.github.com> Co-authored-by: Lermart96 <anders.brandt@oceanharvesting.com> Co-authored-by: yuyihsiang <yyu@nycu.edu.tw> Co-authored-by: Jorge Leon <72461917+jleonqu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the CI workflows in 4 ways:
I also fixed the issue with the docs added in #847.