-
Notifications
You must be signed in to change notification settings - Fork 184
Update the WEC-Sim Theory Documentation to Clarify Wave Power Calculation #847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pulling Dev into Nathan's Branch
Adding more text, images, and implementation details.
Continuing to update the development pages for the Morison Element implementation.
|
@H0R5E I can't figure out what is causing the docs to trigger the following warning: We need to merge this PR, so I'm going to remove the |
|
@kmruehl, I see the issue. I think the ideal solution is split this into two, with a stricter check stage and a more permissive build stage. In this way the CI will tell you if something is wrong but won't prevent the docs from building if you choose to merge the docs in a broken state. What do you think? |
|
@H0R5E I'm okay with that suggestion. I think failing on a warning is a bit restrictive, but I'm open to this middle ground solution. |
Issue #836 highlighted an issue in the calculation of wave power within WEC-Sim for regular waves that were not in deepwater. In order to improve the user understand of wave power calculated within WEC-Sim additional documentation in the regular and irregular theory sections have been added.