-
Notifications
You must be signed in to change notification settings - Fork 184
Calculation_of_Ainf_using_radiationIRF.m #946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculation_of_Ainf_using_radiationIRF.m #946
Conversation
This PR follows #880 and #938 If the added-mass infinity was missing from the BEM run, radiationIRF function calculates the Added-mass at infinity. However, this only happens for non-WAMIT BEM codes. This PR generates the added-mass at infinity, if it is missing from the BEM run regardless of the BEM code.
nathanmtom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@salhus Thanks for updating your branch and the tests are now passing.
I approve this pull request as it is a minor change and should not impact our normal workflow given the change was to update the code to catch cases when WAMIT does not output an infinite frequency added mass value.
|
Dear salhus and dav-og
|
|
Dear salhus |
|
Thanks @hachikoi1 ! |
|
Dear salhus |



This PR follows #880 and #938
If the added-mass infinity was missing from the BEM run, radiationIRF function calculates the Added-mass at infinity. However, this only happens for non-WAMIT BEM codes. This PR generates the added-mass at infinity, if it is missing from the BEM run regardless of the BEM code.