feat: add Moonshot model configurations #869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WalkthroughExpanded the Moonshot provider’s models from empty to 14 defined entries (Kimi K2, Kimi Latest, Moonshot V1, Kimi Thinking, including vision variants) with fixed parameters. The identical 14-model block appears twice in the same file. No function signatures or control flow were changed. Changes
Sequence Diagram(s)sequenceDiagram
participant UI as UI
participant Presenter as Config Presenter
participant Provider as Moonshot Provider Config
UI->>Presenter: Request model config for modelId
Presenter->>Provider: Lookup model by match rules
alt ModelId matches one of 14 entries
Provider-->>Presenter: Return matching model settings
else No match
Provider-->>Presenter: Return default/empty settings
end
Presenter-->>UI: Provide resolved settings
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/presenter/configPresenter/providerModelSettings.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (7)
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development-setup.mdc)
**/*.{js,jsx,ts,tsx}: 使用 OxLint 进行代码检查
Log和注释使用英文书写
Files:
src/main/presenter/configPresenter/providerModelSettings.ts
src/{main,renderer}/**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/electron-best-practices.mdc)
src/{main,renderer}/**/*.ts: Use context isolation for improved security
Implement proper inter-process communication (IPC) patterns
Optimize application startup time with lazy loading
Implement proper error handling and logging for debugging
Files:
src/main/presenter/configPresenter/providerModelSettings.ts
src/main/**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/electron-best-practices.mdc)
Use Electron's built-in APIs for file system and native dialogs
Files:
src/main/presenter/configPresenter/providerModelSettings.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/error-logging.mdc)
**/*.{ts,tsx}: 始终使用 try-catch 处理可能的错误
提供有意义的错误信息
记录详细的错误日志
优雅降级处理
日志应包含时间戳、日志级别、错误代码、错误描述、堆栈跟踪（如适用）、相关上下文信息
日志级别应包括 ERROR、WARN、INFO、DEBUG
不要吞掉错误
提供用户友好的错误信息
实现错误重试机制
避免记录敏感信息
使用结构化日志
设置适当的日志级别
Files:
src/main/presenter/configPresenter/providerModelSettings.ts
src/main/**/*.{ts,js,tsx,jsx}
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
主进程代码放在
src/main
Files:
src/main/presenter/configPresenter/providerModelSettings.ts
**/*.{ts,tsx,js,vue}
📄 CodeRabbit inference engine (CLAUDE.md)
Use English for all logs and comments
Files:
src/main/presenter/configPresenter/providerModelSettings.ts
**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (CLAUDE.md)
Enable and adhere to strict TypeScript typing (avoid implicit any, prefer precise types)
Files:
src/main/presenter/configPresenter/providerModelSettings.ts
🧠 Learnings (1)
📚 Learning: 2025-09-06T03:07:23.794Z
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-09-06T03:07:23.794Z
Learning: Applies to src/main/presenter/configPresenter/providers.ts : Add provider configuration entries in src/main/presenter/configPresenter/providers.ts
Applied to files:
src/main/presenter/configPresenter/providerModelSettings.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build-check (x64)
🔇 Additional comments (2)
src/main/presenter/configPresenter/providerModelSettings.ts (2)
677-686: Confirm capabilities for 'kimi-thinking-preview'Set as vision=true and functionCall=false. Please confirm that Kimi Thinking Preview actually supports vision and disallows tool/functions for Moonshot’s current API; adjust if needed.
Would you like me to open a follow-up to sync maxTokens/contextLength and capability flags with Moonshot’s latest docs?
532-687: Nice coverage of Moonshot SKUsGood breadth across K2, Latest, V1, and Vision variants, and consistent fields populated.
Comment on lines
+532
to
+687
| models: [ | ||
| { | ||
| id: 'kimi-k2-0905-preview', | ||
| name: 'Kimi K2 0905 Preview', | ||
| temperature: 0.7, | ||
| maxTokens: 65536, | ||
| contextLength: 262144, | ||
| match: ['kimi-k2-0905-preview'], | ||
| vision: false, | ||
| functionCall: true, | ||
| reasoning: false | ||
| }, | ||
| { | ||
| id: 'kimi-k2-0711-preview', | ||
| name: 'Kimi K2 0711 Preview', | ||
| temperature: 0.7, | ||
| maxTokens: 65536, | ||
| contextLength: 131072, | ||
| match: ['kimi-k2-0711-preview'], | ||
| vision: false, | ||
| functionCall: true, | ||
| reasoning: false | ||
| }, | ||
| { | ||
| id: 'kimi-k2-turbo-preview', | ||
| name: 'Kimi K2 Turbo Preview', | ||
| temperature: 0.7, | ||
| maxTokens: 65536, | ||
| contextLength: 262144, | ||
| match: ['kimi-k2-turbo-preview'], | ||
| vision: false, | ||
| functionCall: true, | ||
| reasoning: false | ||
| }, | ||
| { | ||
| id: 'kimi-latest', | ||
| name: 'Kimi Latest', | ||
| temperature: 0.7, | ||
| maxTokens: 65536, | ||
| contextLength: 131072, | ||
| match: ['kimi-latest'], | ||
| vision: true, | ||
| functionCall: true, | ||
| reasoning: false | ||
| }, | ||
| { | ||
| id: 'kimi-latest-8k', | ||
| name: 'Kimi Latest 8K', | ||
| temperature: 0.7, | ||
| maxTokens: 4096, | ||
| contextLength: 8192, | ||
| match: ['kimi-latest-8k'], | ||
| vision: true, | ||
| functionCall: true, | ||
| reasoning: false | ||
| }, | ||
| { | ||
| id: 'kimi-latest-32k', | ||
| name: 'Kimi Latest 32K', | ||
| temperature: 0.7, | ||
| maxTokens: 16384, | ||
| contextLength: 32768, | ||
| match: ['kimi-latest-32k'], | ||
| vision: true, | ||
| functionCall: true, | ||
| reasoning: false | ||
| }, | ||
| { | ||
| id: 'kimi-latest-128k', | ||
| name: 'Kimi Latest 128K', | ||
| temperature: 0.7, | ||
| maxTokens: 65536, | ||
| contextLength: 131072, | ||
| match: ['kimi-latest-128k'], | ||
| vision: true, | ||
| functionCall: true, | ||
| reasoning: false | ||
| }, | ||
| { | ||
| id: 'moonshot-v1-8k', | ||
| name: 'Moonshot V1 8K', | ||
| temperature: 0.7, | ||
| maxTokens: 4096, | ||
| contextLength: 8192, | ||
| match: ['moonshot-v1-8k'], | ||
| vision: false, | ||
| functionCall: true, | ||
| reasoning: false | ||
| }, | ||
| { | ||
| id: 'moonshot-v1-32k', | ||
| name: 'Moonshot V1 32K', | ||
| temperature: 0.7, | ||
| maxTokens: 16384, | ||
| contextLength: 32768, | ||
| match: ['moonshot-v1-32k'], | ||
| vision: false, | ||
| functionCall: true, | ||
| reasoning: false | ||
| }, | ||
| { | ||
| id: 'moonshot-v1-128k', | ||
| name: 'Moonshot V1 128K', | ||
| temperature: 0.7, | ||
| maxTokens: 65536, | ||
| contextLength: 131072, | ||
| match: ['moonshot-v1-128k'], | ||
| vision: false, | ||
| functionCall: true, | ||
| reasoning: false | ||
| }, | ||
| { | ||
| id: 'moonshot-v1-8k-vision-preview', | ||
| name: 'Moonshot V1 8K Vision Preview', | ||
| temperature: 0.7, | ||
| maxTokens: 4096, | ||
| contextLength: 8192, | ||
| match: ['moonshot-v1-8k-vision-preview'], | ||
| vision: true, | ||
| functionCall: true, | ||
| reasoning: false | ||
| }, | ||
| { | ||
| id: 'moonshot-v1-32k-vision-preview', | ||
| name: 'Moonshot V1 32K Vision Preview', | ||
| temperature: 0.7, | ||
| maxTokens: 16384, | ||
| contextLength: 32768, | ||
| match: ['moonshot-v1-32k-vision-preview'], | ||
| vision: true, | ||
| functionCall: true, | ||
| reasoning: false | ||
| }, | ||
| { | ||
| id: 'moonshot-v1-128k-vision-preview', | ||
| name: 'Moonshot V1 128K Vision Preview', | ||
| temperature: 0.7, | ||
| maxTokens: 65536, | ||
| contextLength: 131072, | ||
| match: ['moonshot-v1-128k-vision-preview'], | ||
| vision: true, | ||
| functionCall: true, | ||
| reasoning: false | ||
| }, | ||
| { | ||
| id: 'kimi-thinking-preview', | ||
| name: 'Kimi Thinking Preview', | ||
| temperature: 0.7, | ||
| maxTokens: 65536, | ||
| contextLength: 131072, | ||
| match: ['kimi-thinking-preview'], | ||
| vision: true, | ||
| functionCall: false, | ||
| reasoning: true | ||
| } | ||
| ] |
Contributor
There was a problem hiding this comment.
🛠️ Refactor suggestion
Prefer exact/most-specific matching over substring order-dependence
Relying on includes() + array order is fragile and caused the above bugs. Improve matcher to:
- prefer exact matches; 2) else pick the candidate with the longest match string. Backward compatible with shorter aliases like 'deepseek-r1-0528'.
Apply outside this hunk in getProviderSpecificModelConfig():
@@ export function getProviderSpecificModelConfig(
- // 遍历该提供商的模型数组，查找匹配的模型配置
- for (const config of providerSetting.models) {
- // 检查是否有任何匹配条件符合
- if (config.match.some((matchStr) => lowerModelId.includes(matchStr.toLowerCase()))) {
- return {
- maxTokens: config.maxTokens,
- contextLength: config.contextLength,
- temperature: config.temperature, // 保持可选，某些模型不支持
- vision: config.vision || false,
- functionCall: config.functionCall || false,
- reasoning: config.reasoning || false,
- type: config.type || ModelType.Chat,
- reasoningEffort: config.reasoningEffort,
- verbosity: config.verbosity,
- maxCompletionTokens: config.maxCompletionTokens,
- thinkingBudget: config.thinkingBudget,
- enableSearch: config.enableSearch ?? false,
- forcedSearch: config.forcedSearch ?? false,
- searchStrategy: config.searchStrategy || 'turbo'
- }
- }
- }
+ // Build match candidates, prefer exact, else longest match
+ const candidates = providerSetting.models.flatMap((cfg) =>
+ (cfg.match || []).map((m) => ({
+ cfg,
+ mLower: m.toLowerCase(),
+ mLen: m.length
+ }))
+ ).filter(({ mLower }) => lowerModelId.includes(mLower))
+
+ // Prefer exact match first
+ const exact = candidates.find(({ mLower }) => lowerModelId === mLower)
+ const best = exact ??
+ candidates.sort((a, b) => b.mLen - a.mLen)[0]
+
+ if (best) {
+ const config = best.cfg
+ return {
+ maxTokens: config.maxTokens,
+ contextLength: config.contextLength,
+ temperature: config.temperature,
+ vision: config.vision || false,
+ functionCall: config.functionCall || false,
+ reasoning: config.reasoning || false,
+ type: config.type || ModelType.Chat,
+ reasoningEffort: config.reasoningEffort,
+ verbosity: config.verbosity,
+ maxCompletionTokens: config.maxCompletionTokens,
+ thinkingBudget: config.thinkingBudget,
+ enableSearch: config.enableSearch ?? false,
+ forcedSearch: config.forcedSearch ?? false,
+ searchStrategy: config.searchStrategy || 'turbo'
+ }
+ }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| models: [ | |
| { | |
| id: 'kimi-k2-0905-preview', | |
| name: 'Kimi K2 0905 Preview', | |
| temperature: 0.7, | |
| maxTokens: 65536, | |
| contextLength: 262144, | |
| match: ['kimi-k2-0905-preview'], | |
| vision: false, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'kimi-k2-0711-preview', | |
| name: 'Kimi K2 0711 Preview', | |
| temperature: 0.7, | |
| maxTokens: 65536, | |
| contextLength: 131072, | |
| match: ['kimi-k2-0711-preview'], | |
| vision: false, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'kimi-k2-turbo-preview', | |
| name: 'Kimi K2 Turbo Preview', | |
| temperature: 0.7, | |
| maxTokens: 65536, | |
| contextLength: 262144, | |
| match: ['kimi-k2-turbo-preview'], | |
| vision: false, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'kimi-latest', | |
| name: 'Kimi Latest', | |
| temperature: 0.7, | |
| maxTokens: 65536, | |
| contextLength: 131072, | |
| match: ['kimi-latest'], | |
| vision: true, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'kimi-latest-8k', | |
| name: 'Kimi Latest 8K', | |
| temperature: 0.7, | |
| maxTokens: 4096, | |
| contextLength: 8192, | |
| match: ['kimi-latest-8k'], | |
| vision: true, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'kimi-latest-32k', | |
| name: 'Kimi Latest 32K', | |
| temperature: 0.7, | |
| maxTokens: 16384, | |
| contextLength: 32768, | |
| match: ['kimi-latest-32k'], | |
| vision: true, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'kimi-latest-128k', | |
| name: 'Kimi Latest 128K', | |
| temperature: 0.7, | |
| maxTokens: 65536, | |
| contextLength: 131072, | |
| match: ['kimi-latest-128k'], | |
| vision: true, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'moonshot-v1-8k', | |
| name: 'Moonshot V1 8K', | |
| temperature: 0.7, | |
| maxTokens: 4096, | |
| contextLength: 8192, | |
| match: ['moonshot-v1-8k'], | |
| vision: false, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'moonshot-v1-32k', | |
| name: 'Moonshot V1 32K', | |
| temperature: 0.7, | |
| maxTokens: 16384, | |
| contextLength: 32768, | |
| match: ['moonshot-v1-32k'], | |
| vision: false, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'moonshot-v1-128k', | |
| name: 'Moonshot V1 128K', | |
| temperature: 0.7, | |
| maxTokens: 65536, | |
| contextLength: 131072, | |
| match: ['moonshot-v1-128k'], | |
| vision: false, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'moonshot-v1-8k-vision-preview', | |
| name: 'Moonshot V1 8K Vision Preview', | |
| temperature: 0.7, | |
| maxTokens: 4096, | |
| contextLength: 8192, | |
| match: ['moonshot-v1-8k-vision-preview'], | |
| vision: true, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'moonshot-v1-32k-vision-preview', | |
| name: 'Moonshot V1 32K Vision Preview', | |
| temperature: 0.7, | |
| maxTokens: 16384, | |
| contextLength: 32768, | |
| match: ['moonshot-v1-32k-vision-preview'], | |
| vision: true, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'moonshot-v1-128k-vision-preview', | |
| name: 'Moonshot V1 128K Vision Preview', | |
| temperature: 0.7, | |
| maxTokens: 65536, | |
| contextLength: 131072, | |
| match: ['moonshot-v1-128k-vision-preview'], | |
| vision: true, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'kimi-thinking-preview', | |
| name: 'Kimi Thinking Preview', | |
| temperature: 0.7, | |
| maxTokens: 65536, | |
| contextLength: 131072, | |
| match: ['kimi-thinking-preview'], | |
| vision: true, | |
| functionCall: false, | |
| reasoning: true | |
| } | |
| ] | |
| export function getProviderSpecificModelConfig( | |
| providerSetting: ProviderSetting, | |
| modelId: string | |
| ) { | |
| const lowerModelId = modelId.toLowerCase() | |
| // Build match candidates, prefer exact, else longest match | |
| const candidates = providerSetting.models | |
| .flatMap((cfg) => | |
| (cfg.match || []).map((m) => ({ | |
| cfg, | |
| mLower: m.toLowerCase(), | |
| mLen: m.length | |
| })) | |
| ) | |
| .filter(({ mLower }) => lowerModelId.includes(mLower)) | |
| // Prefer exact match first | |
| const exact = candidates.find(({ mLower }) => lowerModelId === mLower) | |
| const best = exact ?? candidates.sort((a, b) => b.mLen - a.mLen)[0] | |
| if (best) { | |
| const config = best.cfg | |
| return { | |
| maxTokens: config.maxTokens, | |
| contextLength: config.contextLength, | |
| temperature: config.temperature, | |
| vision: config.vision || false, | |
| functionCall: config.functionCall || false, | |
| reasoning: config.reasoning || false, | |
| type: config.type || ModelType.Chat, | |
| reasoningEffort: config.reasoningEffort, | |
| verbosity: config.verbosity, | |
| maxCompletionTokens: config.maxCompletionTokens, | |
| thinkingBudget: config.thinkingBudget, | |
| enableSearch: config.enableSearch ?? false, | |
| forcedSearch: config.forcedSearch ?? false, | |
| searchStrategy: config.searchStrategy || 'turbo' | |
| } | |
| } | |
| // (fallback logic unchanged…) | |
| } |
🤖 Prompt for AI Agents
In src/main/presenter/configPresenter/providerModelSettings.ts around lines 532
to 687, the model-matching logic currently relies on includes() plus array order
which is fragile; change getProviderSpecificModelConfig() so it first searches
for an exact match (modelId === candidate) and returns that if found; if no
exact match, filter candidates that are substrings of the modelId and pick the
one with the longest match string (max length) to prefer most-specific aliases;
keep behavior backward-compatible for short aliases by falling back to the
previous selection when lengths tie or no candidates match.
Comment on lines
+567
to
+609
| id: 'kimi-latest', | ||
| name: 'Kimi Latest', | ||
| temperature: 0.7, | ||
| maxTokens: 65536, | ||
| contextLength: 131072, | ||
| match: ['kimi-latest'], | ||
| vision: true, | ||
| functionCall: true, | ||
| reasoning: false | ||
| }, | ||
| { | ||
| id: 'kimi-latest-8k', | ||
| name: 'Kimi Latest 8K', | ||
| temperature: 0.7, | ||
| maxTokens: 4096, | ||
| contextLength: 8192, | ||
| match: ['kimi-latest-8k'], | ||
| vision: true, | ||
| functionCall: true, | ||
| reasoning: false | ||
| }, | ||
| { | ||
| id: 'kimi-latest-32k', | ||
| name: 'Kimi Latest 32K', | ||
| temperature: 0.7, | ||
| maxTokens: 16384, | ||
| contextLength: 32768, | ||
| match: ['kimi-latest-32k'], | ||
| vision: true, | ||
| functionCall: true, | ||
| reasoning: false | ||
| }, | ||
| { | ||
| id: 'kimi-latest-128k', | ||
| name: 'Kimi Latest 128K', | ||
| temperature: 0.7, | ||
| maxTokens: 65536, | ||
| contextLength: 131072, | ||
| match: ['kimi-latest-128k'], | ||
| vision: true, | ||
| functionCall: true, | ||
| reasoning: false | ||
| }, |
Contributor
There was a problem hiding this comment.
🛠️ Refactor suggestion
Fix substring matching collisions: 'kimi-latest' shadows its -8k/-32k/-128k variants
getProviderSpecificModelConfig uses includes() for matching. Because 'kimi-latest' appears before 'kimi-latest-8k/-32k/-128k', selecting e.g. 'kimi-latest-32k' will match the earlier 'kimi-latest' block and return wrong limits/features.
Minimal fix (reorder: put specific variants before the generic one):
@@
- {
- id: 'kimi-latest',
- name: 'Kimi Latest',
- temperature: 0.7,
- maxTokens: 65536,
- contextLength: 131072,
- match: ['kimi-latest'],
- vision: true,
- functionCall: true,
- reasoning: false
- },
{
id: 'kimi-latest-8k',
name: 'Kimi Latest 8K',
@@
{
id: 'kimi-latest-32k',
name: 'Kimi Latest 32K',
@@
{
id: 'kimi-latest-128k',
name: 'Kimi Latest 128K',
@@
+ {
+ id: 'kimi-latest',
+ name: 'Kimi Latest',
+ temperature: 0.7,
+ maxTokens: 65536,
+ contextLength: 131072,
+ match: ['kimi-latest'],
+ vision: true,
+ functionCall: true,
+ reasoning: false
+ },Alternatively (preferred), harden the matcher to prefer exact/longest matches (see separate comment).
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| id: 'kimi-latest', | |
| name: 'Kimi Latest', | |
| temperature: 0.7, | |
| maxTokens: 65536, | |
| contextLength: 131072, | |
| match: ['kimi-latest'], | |
| vision: true, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'kimi-latest-8k', | |
| name: 'Kimi Latest 8K', | |
| temperature: 0.7, | |
| maxTokens: 4096, | |
| contextLength: 8192, | |
| match: ['kimi-latest-8k'], | |
| vision: true, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'kimi-latest-32k', | |
| name: 'Kimi Latest 32K', | |
| temperature: 0.7, | |
| maxTokens: 16384, | |
| contextLength: 32768, | |
| match: ['kimi-latest-32k'], | |
| vision: true, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'kimi-latest-128k', | |
| name: 'Kimi Latest 128K', | |
| temperature: 0.7, | |
| maxTokens: 65536, | |
| contextLength: 131072, | |
| match: ['kimi-latest-128k'], | |
| vision: true, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'kimi-latest-8k', | |
| name: 'Kimi Latest 8K', | |
| temperature: 0.7, | |
| maxTokens: 4096, | |
| contextLength: 8192, | |
| match: ['kimi-latest-8k'], | |
| vision: true, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'kimi-latest-32k', | |
| name: 'Kimi Latest 32K', | |
| temperature: 0.7, | |
| maxTokens: 16384, | |
| contextLength: 32768, | |
| match: ['kimi-latest-32k'], | |
| vision: true, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'kimi-latest-128k', | |
| name: 'Kimi Latest 128K', | |
| temperature: 0.7, | |
| maxTokens: 65536, | |
| contextLength: 131072, | |
| match: ['kimi-latest-128k'], | |
| vision: true, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'kimi-latest', | |
| name: 'Kimi Latest', | |
| temperature: 0.7, | |
| maxTokens: 65536, | |
| contextLength: 131072, | |
| match: ['kimi-latest'], | |
| vision: true, | |
| functionCall: true, | |
| reasoning: false | |
| }, |
🤖 Prompt for AI Agents
In src/main/presenter/configPresenter/providerModelSettings.ts around lines
567-609, the model entry for 'kimi-latest' appears before its '-8k/-32k/-128k'
variants so the current includes()-based matching will match the generic
'kimi-latest' first and return incorrect config for specific variants; fix by
either moving the specific variant entries ('kimi-latest-128k',
'kimi-latest-32k', 'kimi-latest-8k') before the generic 'kimi-latest' entry, or,
preferably, change the matching logic in getProviderSpecificModelConfig to
prefer exact or longest matches (e.g., check exact equality first, then fallback
to includes, or sort candidate match strings by length descending and choose the
longest includes match) so specific models are selected over the generic one.
Comment on lines
+611
to
+675
| id: 'moonshot-v1-8k', | ||
| name: 'Moonshot V1 8K', | ||
| temperature: 0.7, | ||
| maxTokens: 4096, | ||
| contextLength: 8192, | ||
| match: ['moonshot-v1-8k'], | ||
| vision: false, | ||
| functionCall: true, | ||
| reasoning: false | ||
| }, | ||
| { | ||
| id: 'moonshot-v1-32k', | ||
| name: 'Moonshot V1 32K', | ||
| temperature: 0.7, | ||
| maxTokens: 16384, | ||
| contextLength: 32768, | ||
| match: ['moonshot-v1-32k'], | ||
| vision: false, | ||
| functionCall: true, | ||
| reasoning: false | ||
| }, | ||
| { | ||
| id: 'moonshot-v1-128k', | ||
| name: 'Moonshot V1 128K', | ||
| temperature: 0.7, | ||
| maxTokens: 65536, | ||
| contextLength: 131072, | ||
| match: ['moonshot-v1-128k'], | ||
| vision: false, | ||
| functionCall: true, | ||
| reasoning: false | ||
| }, | ||
| { | ||
| id: 'moonshot-v1-8k-vision-preview', | ||
| name: 'Moonshot V1 8K Vision Preview', | ||
| temperature: 0.7, | ||
| maxTokens: 4096, | ||
| contextLength: 8192, | ||
| match: ['moonshot-v1-8k-vision-preview'], | ||
| vision: true, | ||
| functionCall: true, | ||
| reasoning: false | ||
| }, | ||
| { | ||
| id: 'moonshot-v1-32k-vision-preview', | ||
| name: 'Moonshot V1 32K Vision Preview', | ||
| temperature: 0.7, | ||
| maxTokens: 16384, | ||
| contextLength: 32768, | ||
| match: ['moonshot-v1-32k-vision-preview'], | ||
| vision: true, | ||
| functionCall: true, | ||
| reasoning: false | ||
| }, | ||
| { | ||
| id: 'moonshot-v1-128k-vision-preview', | ||
| name: 'Moonshot V1 128K Vision Preview', | ||
| temperature: 0.7, | ||
| maxTokens: 65536, | ||
| contextLength: 131072, | ||
| match: ['moonshot-v1-128k-vision-preview'], | ||
| vision: true, | ||
| functionCall: true, | ||
| reasoning: false | ||
| }, |
Contributor
There was a problem hiding this comment.
🛠️ Refactor suggestion
Fix collisions between 'moonshot-v1-k' and 'moonshot-v1-k-vision-preview'
Because of includes(), the non-vision entries ('moonshot-v1-8k/32k/128k') precede the '...-vision-preview' ones, so choosing a vision model will match the earlier non-vision block and incorrectly set vision=false.
Minimal fix (reorder: place vision-preview blocks before the non-vision ones):
@@
- {
- id: 'moonshot-v1-8k',
- name: 'Moonshot V1 8K',
- temperature: 0.7,
- maxTokens: 4096,
- contextLength: 8192,
- match: ['moonshot-v1-8k'],
- vision: false,
- functionCall: true,
- reasoning: false
- },
- {
- id: 'moonshot-v1-32k',
- name: 'Moonshot V1 32K',
- temperature: 0.7,
- maxTokens: 16384,
- contextLength: 32768,
- match: ['moonshot-v1-32k'],
- vision: false,
- functionCall: true,
- reasoning: false
- },
- {
- id: 'moonshot-v1-128k',
- name: 'Moonshot V1 128K',
- temperature: 0.7,
- maxTokens: 65536,
- contextLength: 131072,
- match: ['moonshot-v1-128k'],
- vision: false,
- functionCall: true,
- reasoning: false
- },
{
id: 'moonshot-v1-8k-vision-preview',
name: 'Moonshot V1 8K Vision Preview',
@@
{
id: 'moonshot-v1-32k-vision-preview',
name: 'Moonshot V1 32K Vision Preview',
@@
{
id: 'moonshot-v1-128k-vision-preview',
name: 'Moonshot V1 128K Vision Preview',
@@
+ {
+ id: 'moonshot-v1-8k',
+ name: 'Moonshot V1 8K',
+ temperature: 0.7,
+ maxTokens: 4096,
+ contextLength: 8192,
+ match: ['moonshot-v1-8k'],
+ vision: false,
+ functionCall: true,
+ reasoning: false
+ },
+ {
+ id: 'moonshot-v1-32k',
+ name: 'Moonshot V1 32K',
+ temperature: 0.7,
+ maxTokens: 16384,
+ contextLength: 32768,
+ match: ['moonshot-v1-32k'],
+ vision: false,
+ functionCall: true,
+ reasoning: false
+ },
+ {
+ id: 'moonshot-v1-128k',
+ name: 'Moonshot V1 128K',
+ temperature: 0.7,
+ maxTokens: 65536,
+ contextLength: 131072,
+ match: ['moonshot-v1-128k'],
+ vision: false,
+ functionCall: true,
+ reasoning: false
+ },📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| id: 'moonshot-v1-8k', | |
| name: 'Moonshot V1 8K', | |
| temperature: 0.7, | |
| maxTokens: 4096, | |
| contextLength: 8192, | |
| match: ['moonshot-v1-8k'], | |
| vision: false, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'moonshot-v1-32k', | |
| name: 'Moonshot V1 32K', | |
| temperature: 0.7, | |
| maxTokens: 16384, | |
| contextLength: 32768, | |
| match: ['moonshot-v1-32k'], | |
| vision: false, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'moonshot-v1-128k', | |
| name: 'Moonshot V1 128K', | |
| temperature: 0.7, | |
| maxTokens: 65536, | |
| contextLength: 131072, | |
| match: ['moonshot-v1-128k'], | |
| vision: false, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'moonshot-v1-8k-vision-preview', | |
| name: 'Moonshot V1 8K Vision Preview', | |
| temperature: 0.7, | |
| maxTokens: 4096, | |
| contextLength: 8192, | |
| match: ['moonshot-v1-8k-vision-preview'], | |
| vision: true, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'moonshot-v1-32k-vision-preview', | |
| name: 'Moonshot V1 32K Vision Preview', | |
| temperature: 0.7, | |
| maxTokens: 16384, | |
| contextLength: 32768, | |
| match: ['moonshot-v1-32k-vision-preview'], | |
| vision: true, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'moonshot-v1-128k-vision-preview', | |
| name: 'Moonshot V1 128K Vision Preview', | |
| temperature: 0.7, | |
| maxTokens: 65536, | |
| contextLength: 131072, | |
| match: ['moonshot-v1-128k-vision-preview'], | |
| vision: true, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'moonshot-v1-8k-vision-preview', | |
| name: 'Moonshot V1 8K Vision Preview', | |
| temperature: 0.7, | |
| maxTokens: 4096, | |
| contextLength: 8192, | |
| match: ['moonshot-v1-8k-vision-preview'], | |
| vision: true, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'moonshot-v1-32k-vision-preview', | |
| name: 'Moonshot V1 32K Vision Preview', | |
| temperature: 0.7, | |
| maxTokens: 16384, | |
| contextLength: 32768, | |
| match: ['moonshot-v1-32k-vision-preview'], | |
| vision: true, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'moonshot-v1-128k-vision-preview', | |
| name: 'Moonshot V1 128K Vision Preview', | |
| temperature: 0.7, | |
| maxTokens: 65536, | |
| contextLength: 131072, | |
| match: ['moonshot-v1-128k-vision-preview'], | |
| vision: true, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'moonshot-v1-8k', | |
| name: 'Moonshot V1 8K', | |
| temperature: 0.7, | |
| maxTokens: 4096, | |
| contextLength: 8192, | |
| match: ['moonshot-v1-8k'], | |
| vision: false, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'moonshot-v1-32k', | |
| name: 'Moonshot V1 32K', | |
| temperature: 0.7, | |
| maxTokens: 16384, | |
| contextLength: 32768, | |
| match: ['moonshot-v1-32k'], | |
| vision: false, | |
| functionCall: true, | |
| reasoning: false | |
| }, | |
| { | |
| id: 'moonshot-v1-128k', | |
| name: 'Moonshot V1 128K', | |
| temperature: 0.7, | |
| maxTokens: 65536, | |
| contextLength: 131072, | |
| match: ['moonshot-v1-128k'], | |
| vision: false, | |
| functionCall: true, | |
| reasoning: false | |
| }, |
🤖 Prompt for AI Agents
In src/main/presenter/configPresenter/providerModelSettings.ts around lines 611
to 675 the current ordering places the non-vision Moonshot entries
('moonshot-v1-8k', 'moonshot-v1-32k', 'moonshot-v1-128k') before their
'-vision-preview' counterparts, causing includes() to match the non-vision entry
first and incorrectly set vision=false for vision models; fix by reordering
these blocks so each '-vision-preview' entry appears before its corresponding
non-vision entry (i.e., move the three vision-preview objects above the three
non-vision objects) ensuring the includes() check hits the vision variants
first.
zerob13
approved these changes
Sep 8, 2025
zerob13
added a commit
that referenced
this pull request
Sep 9, 2025
* fix: chat confg need sync to new value when change model in chat (#823) * fix: gemini nano banana not read image from chatinput * fix: remove file-type ,this will mark html as audio (#824) * fix: Solve the problem of the window becoming larger when dragging floating button under Windows (#826) * fix: improve OpenAI compatible provider compatibility with third-party services * chore: update vue-renderer-markdown to v0.0.35 (#827) * refactor: remove custom-prompts-server and decouple prompts from MCP lifecycle (#829) - Remove custom-prompts-server service entirely including configuration - Implement data source merging in MCP store to load prompts from both config and MCP - Add upgrade migration logic for versions < 0.3.5 to clean up old configurations - Ensure @ operations work independently of MCP state through config data source - Update CLAUDE.md with prompt management guidelines The @ prompt functionality now works completely independently of MCP, loading custom prompts directly from config storage while maintaining full compatibility with existing MCP prompt sources. * chore: add better log for mcp tool name * feat: ux update (#831) * feat: ux update * chore: format * feat: setting provider ux update (#832) * feat: add current datetime to system prompt - Add current date and time information to user's system prompt when not empty - Include complete datetime with timezone, year, month, day, hour, minute, second - Apply to both preparePromptContent and buildContinueToolCallContext methods - Update token calculation to use processed system prompt for accuracy - Skip datetime addition for image generation models and empty prompts * refactor: extract system prompt datetime enhancement to common method - Add enhanceSystemPromptWithDateTime private method to reduce code duplication - Update both preparePromptContent and buildContinueToolCallContext to use common method - Improve code maintainability and ensure consistency across all system prompt processing - Add comprehensive JSDoc documentation for the new method * fix(markdown): auto-wrap hide scroll (#833) * feat: add enable_thinking parameter support for siliconcloud (#835) * chore: bump deps (#834) * chore: bump up deps * fix: change win arm to wasm32 sharp * chore: revert sharp config * feat: drop windows arm support * fix(coderabbitai): remove action for windows arm64 * refactor: adjust scroll-to-bottom button glow effect (#837) * feat: add mutual exclusive confirmation dialogs for DeepSeek-V3.1 (#838) * feat: add sanitizeText utility for clipboard data handling (#843) * feat: support canary upgrade (#840) * feat: support canary upgrade * feat: add update channel selection for stable/canary versions - Add update channel configuration to config presenter - Implement dynamic URL switching for version checks and downloads - Add UI selector in AboutUsSettings for channel selection - Support stable and canary update channels with different endpoints - Add internationalization support for channel selection * chore: change contributors charts to openomy * refactor: improve update channel handling and network resilience - Sanitize update channel input to prevent invalid values - Add 10-second timeout to version check requests to prevent hanging - Treat unknown channels as 'upgrade' (stable) for robustness - Improve error handling for network timeouts and invalid channels * feat: implement thinking parameter support for doubao models (#842) * feat: implement dedicated DashScope provider with enable_thinking support (#844) * feat: implement dedicated DashScope provider with enable_thinking support * refactor: remove unnecessary API key status check methods from DashscopeProvider * fix: prioritize provider.id over apiType in createProviderInstance (#846) * feat: add qwen3 thinking budget support (#848) * feat: add qwen3 thinking budget support * fix: add missing gemini.onlySupported key in zh-CN locale * refactor: merge duplicate silicon case statements in provider creation * feat: add qwen3 thinking budget support in ChatConfig (#849) * refactor(types): 🚀split monolithic presenter.d.ts into strict per-domain *.presenter.d.ts + typed core layer (#847) * docs: Add strong-typed message architecture and implementation guidelines - Update message-architecture.md with strong-typed design, remove compatibility compromises - Add event-to-UI mapping table and rendering checklist for contract compliance - Create presenter-split-plan.md for type system refactoring - Add implementation-tasks.md with phased rollout plan - Create .cursor/rules/provider-guidelines.mdc for provider implementation guidance This establishes a foundation for strong-typed, maintainable message architecture without legacy compatibility debt. * types(core): add strong-typed core types and barrel exports\n\n- Add usage.ts (UsageStats, RateLimitInfo)\n- Add llm-events.ts (discriminated union + factories + guards)\n- Add agent-events.ts (LLMAgentEvent*, shared types)\n- Add chat.ts (Message/AssistantMessageBlock/UserMessageContent)\n- Add mcp.ts (MCP content/response/definition)\n- Add types/index.d.ts barrel exports\n\nNo compatibility shims included by design. * refactor(types): move legacy presenters and add @shared/presenter stub; keep legacy exports in types/index to maintain build\n\n- Move legacy presenters to src/shared/types/presenters/legacy.presenters.d.ts\n- Add src/shared/presenter.d.ts re-export stub\n- Temporarily export only legacy presenters from types/index.d.ts to avoid type mismatches\n- Update implementation-tasks.md (Stage 2 done)\n\nNext: progressive import updates to new cores, then flip barrel to new types and delete legacy. * refactor(types): alias legacy core message types to strong-typed core (B-plan)\n\n- legacy.presenters.d.ts now re-exports ChatMessage/ChatMessageContent/LLMAgentEvent/LLMAgentEventData/LLMCoreStreamEvent from core\n- Prepares for flipping interfaces without changing import sites * docs(tasks): mark Phase 3 as completed\n\n- Successfully implemented B-plan approach with type aliasing\n- Unified core message types (ChatMessage, LLMAgentEvent, LLMCoreStreamEvent)\n- Created core model types and maintained build compatibility\n- All type checks passing with no breaking changes * fix(types): revert to legacy-only exports and fix MESSAGE_ROLE\n\n- Revert types/index.d.ts to only export legacy presenters\n- Remove 'function' from MESSAGE_ROLE to match core definition\n- Maintain build stability while preserving type unification work * feat(provider): implement factory functions for LLMCoreStreamEvent\n\n- Replace all manual event creation with createStreamEvent factory functions\n- Ensures type safety and consistent event structure\n- Updated OpenAICompatibleProvider with strong-typed events:\n - text, reasoning, toolCallStart, toolCallChunk, toolCallEnd\n - error, usage, stop, imageData events\n- All type checks passing\n- Phase 4.1 completed: Provider now outputs LLMCoreStreamEvent with factory construction * feat(provider): update OllamaProvider with factory functions\n\n- Replace all manual event creation with createStreamEvent factory functions\n- Ensures consistent tool_call_start → tool_call_chunk → tool_call_end sequence\n- Updated all event types: text, reasoning, toolCall*, usage, stop, error\n- Maintains proper tool call ID aggregation and sequencing\n- Phase 4.2 completed: Tool call sequences now strictly follow start/chunk/end pattern * docs(tasks): update Phase 4 progress\n\n- Completed Provider strong-typed event output with factory functions\n- Completed tool_call_* strict start/chunk/end sequences\n- Completed usage event sent before stop in all providers\n- Updated implementation tasks document with current progress * feat(phase4): complete Provider strong-typed event integration\n\n- Added factory functions import to AwsBedrockProvider\n- Updated error handling to use createStreamEvent.error() + createStreamEvent.stop('error')\n- Created comprehensive unit tests for LLMCoreStreamEvent factory functions\n- Tests validate: event creation, tool call sequences, error+stop patterns, type guards\n- All 12 core event tests passing ✅\n\n## Phase 4 Completed:\n- ✅ Provider strong-typed event output (factory construction)\n- ✅ tool_call_* strict start/chunk/end sequences with ID aggregation\n- ✅ Usage events sent before stop in all providers\n- ✅ Rate limit events (handled at Presenter layer)\n- ✅ Unified error + stop event patterns\n- ✅ Comprehensive unit tests for sequences/fields/boundaries * feat(phase5): complete Agent & UI alignment ## Phase 5 Completed: Agent & UI Alignment ✅ ### 1. Agent Layer Enhancement - ✅ Agent consumes only CoreEvent and outputs LLMAgentEvent - ✅ Strict separation of response/error/end event types - ✅ Added rate_limit event handling in Agent layer - ✅ Maintained proper event transformation pipeline ### 2. UI Layer Unification - ✅ Removed standalone tool_call_permission type - ✅ Unified to action + action_type pattern - ✅ Updated all UI components and thread presenter logic - ✅ Preserved backward compatibility with conditional rendering ### 3. Renderer Mapping & Testing - ✅ Created comprehensive renderer contract tests (17 tests) - ✅ Added message block data structure snapshot tests (14 tests) - ✅ Validated event-to-UI block mapping compliance - ✅ Ensured consistent status transitions and type safety ### Key Technical Achievements: - **Type Safety**: All event transformations now type-safe - **Consistency**: Unified action_type handling across codebase - **Testing**: 31 new tests covering contracts and snapshots - **Architecture**: Clean separation between Agent/UI concerns - **Quality**: All lint, format, and type checks passing ✅ ### Files Modified: - Agent layer: llmProviderPresenter/index.ts - UI components: MessageItemAssistant.vue - Thread logic: threadPresenter/index.ts - Type definitions: shared/chat.d.ts - Tests: rendererContract.test.ts, messageBlockSnapshot.test.ts Ready for Phase 6: Quality & Tools 🚀 * feat(phase6): complete Quality & Tools phase ## Phase 6 Completed: Quality & Tools ✅ ### 1. Table-Driven Contract Tests - ✅ Created comprehensive event mapping contract tests (25 test cases) - ✅ Validated all event types from architecture mapping table - ✅ Verified status transitions and type constraints - ✅ Added tool call ID aggregation and lifecycle validation - ✅ Implemented error recovery pattern testing ### 2. Performance Evaluation & Stress Testing - ✅ Large text content processing (50KB < 10ms) - ✅ Large reasoning content handling (100KB < 15ms) - ✅ Large image data processing (1MB < 20ms) - ✅ Batch image processing (100 images < 50ms) - ✅ High-frequency event processing (1000 events < 100ms) - ✅ Mixed event type handling (500 events < 80ms) - ✅ Memory leak prevention (5000 events < 500ms) - ✅ Extreme parameter handling (10KB params < 5ms) - ✅ Concurrent processing simulation (10 workers < 100ms) ### Key Technical Achievements: - **Comprehensive Testing**: 67 tests passing across all scenarios - **Performance Validation**: All benchmarks meet performance targets - **Type Safety**: Full TypeScript compliance (0 errors) - **Code Quality**: Lint and format checks passing ✅ - **Architecture Compliance**: All mapping table rules verified - **Stress Testing**: System handles extreme loads efficiently ### Test Coverage Summary: - Event mapping contract tests: 25 tests ✅ - Renderer contract tests: 17 tests ✅ - Performance evaluation tests: 9 tests ✅ - Core event factory tests: 12 tests ✅ - Message block snapshot tests: 14 tests ✅ - Shell integration tests: 8 tests ✅ ### Files Added: - test/renderer/message/eventMappingTable.test.ts (comprehensive mapping validation) - test/renderer/message/performanceEvaluation.test.ts (stress & performance testing) Ready for production deployment with full quality assurance! 🚀 * fix(providers): complete strong-typed event integration across all providers * fix(vitest): modify test case * fix: default settings * chore: update doc * fix(ci): remove duplicate check in pr ci * feat: add pnpm cache for pr check * fix(ci): pr check with pnpm cache * fix(ci): change cache key to package.json * ci: remove pnpm cache * feat: add glow breathing effect to scroll-to-bottom button (#850) * feat: add glow breathing effect to scroll-to-bottom button * fix: ensure exclusive display between MessageList and ArtifactDialog * fix: refine MessageList–ArtifactDialog interaction logic; correct z-order between dialog and ArtifactDialog * chore: prettier .vue * feat: add web search support with configurable options for dashscope (#851) * feat: add web search support with configurable options for dashscope * fix: correct qwen model parameters to match official documentation * feat: add web search support with configurable options for dashscope (#852) * feat: add web search support with configurable options for dashscope * fix: correct qwen model parameters to match official documentation * feat: add search configuration support to ChatConfig components * fix: fix enableSearch state sync and parameter passing issues * fix: preserve search settings during data import * feat: add dashscope commercial models to enable_thinking support (#853) * feat: add search capability icon for model list (#854) * feat: add search capability icon for model list * fix: clear search settings when creating new conversation * feat(markdown): Thinking panel now supports LaTeX compilation for mathematical formulas & markdown performance optimization (#857) * feat(markdown): 思考栏支持数学公式latex编译显示 & markdown 性能优化 close: #845 * chore: lint * chore(ai): update claude code rules and agents * fix(ui): revert Dialog z-index to z-50 to fix dropdown visibility Reverts DialogContent z-index from z-[100] back to z-50 to resolve issue where Select and EmojiPicker dropdowns were not appearing. This maintains proper layering hierarchy without breaking other UI components. * feat: upgrade vue-renderer-markdown & vue-use-monaco (#862) 1. ignore math-block warning 2. Compatible with the syntax issues of mermaid produced by AI, greatly reducing the probability of mermaid rendering errors * feat(dashscope): add qwen3-max-preview model (#865) * fix: mcp params support more types (#861) * feat(mcp): enhance tool parameter display with enum type support - Add enum parameter type detection and enhanced display - Show enum parameters with distinct blue badge styling (enum(string), array[enum(string)]) - Display allowed values for both direct enum and array item enum parameters - Add i18n support for "allowedValues" and "arrayItemValues" labels - Maintain consistent UI design with existing parameter display patterns - Improve developer experience when debugging MCP tools with constrained parameters * fix: enum params support * fix(context-menu): handle local file paths in image save functionality - Fix URL parsing error when saving images from local file paths - Add proper handling for http/https URLs, file:// URLs, and direct file paths - Use fs.promises for reading local files instead of net.fetch for invalid URLs - Prevent "Failed to parse URL from" error when saving local images * fix(context-menu): improve URL handling robustness in image save - Add try-catch around net.fetch to handle invalid URLs gracefully - Implement fallback methods for file:// URLs and local file paths - Add debug logging to track source URL values for troubleshooting - Prevent "Failed to parse URL from" errors with comprehensive URL validation * fix(context-menu): handle empty srcURL in image save functionality - Add comprehensive URL detection when srcURL is empty - Implement fallback URL sources (linkURL, pageURL) for better compatibility - Add debug logging to track all available context menu parameters - Prevent "Failed to parse URL from" errors caused by empty URLs - Provide clear error message when no valid URL can be found * chore: format code * fix: ai review * fix: prevent @ symbol remaining when deleting mentions (#867) * Merge commit from fork * feat: implement separated system and custom prompt management (#868) * feat: implement separated system and custom prompt management * style: code fmt * fix: add migration for legacy default_system_prompt to system_prompts * feat: add Moonshot model configurations (#869) * refactor: translate all cn comments and log to en (#871) * refactor: translate all cn comments and log to en * fix: revert translate in params * feat: add reasoning support for Grok thinking models (#873) * feat: add reasoning support for Grok thinking models * fix: code lint * fix: escaping character issue --------- Co-authored-by: zerob13 <zerob13@gmail.com> --------- Co-authored-by: hllshiro <40970081+hllshiro@users.noreply.github.com> Co-authored-by: yyhhyyyyyy <yyhhyyyyyy8@gmail.com> Co-authored-by: xiaomo <wegi866@gmail.com> Co-authored-by: Simon He <57086651+Simon-He95@users.noreply.github.com> Co-authored-by: luy <12696648@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add Moonshot model configurations
Summary by CodeRabbit