Skip to content

Conversation

@zerob13
Copy link
Collaborator

@zerob13 zerob13 commented Sep 3, 2025

  • bump deps

Summary by CodeRabbit

  • Chores

    • Bumped many dependencies and devDependencies across AI integrations, networking, document parsing, desktop runtime, UI/build tooling, and developer tooling.
  • Build

    • Simplified Windows CI build matrix to x64 only (arm64 variant removed).
  • Release

    • Windows ARM64 artifact publishing/copying disabled in release/deploy workflows.
  • Performance

    • Upstream library updates may yield incremental stability and performance improvements.
  • Security

    • Includes recent patch-level updates to reduce potential third-party vulnerabilities.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 3, 2025

Walkthrough

Updated dependency and devDependency versions in package.json (minor/patch bumps); disabled Windows ARM64 artifact builds/handling across CI: simplified Windows build matrix in .github/workflows/build.yml and commented-out ARM64 artifact copy blocks in .github/workflows/deploycdn.yml and .github/workflows/release.yml. No runtime code or exported API changes.

Changes

Cohort / File(s) Summary of Changes
Dependencies
package.json
Bumped versions for existing dependencies and devDependencies (multiple minor/patch upgrades; no additions or removals). Examples: bedrock & bedrock-runtime → 3.879.0, @google/genai → 1.16.0, axios → 1.11.0, cheerio → 1.1.2, dayjs → 1.11.18, openai → 5.18.0, undici → 7.15.0, zod → 3.25.76; dev tooling bumps include vite → 7.1.4, vue → 3.5.21, mermaid → 11.10.1, @electron/notarize → 3.1.0, etc.
CI — build matrix
.github/workflows/build.yml
Removed arm64 from Windows arch matrix and dropped the win-arm64 include entry; Windows build now only targets x64.
CI — artifact deploy
.github/workflows/deploycdn.yml
Commented-out/disabled blocks that handled deepchat-win-arm64 artifacts and copy steps to CDN upgrade2/winarm and download2 — Windows ARM64 executables no longer copied.
CI — release asset prep
.github/workflows/release.yml
Commented-out/disabled block that copied artifacts from artifacts/deepchat-win-arm64 to release_assets (.exe/.msi/.zip) — Windows ARM64 artifacts are omitted from release assets.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Dev as Developer
  participant CI as CI Runner
  participant Build as Build Job
  participant Artifacts as Artifacts Store
  participant CDN as deploycdn Job
  participant Release as release Job

  Dev->>CI: push changes
  CI->>Build: run build matrix (win-x64, linux, mac)
  note right of Build #DDEEFF: win-arm64 removed
  Build-->>Artifacts: upload artifacts (no win-arm64)
  Artifacts->>CDN: process & copy artifact sets
  note right of CDN #F6F8E9: win-arm64 copy steps commented out
  Artifacts->>Release: prepare release assets
  note right of Release #FFF4E6: win-arm64 asset copy commented out
  Release-->>Dev: release assets ready
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • chore: bump deps #721 — Overlapping dependency version bumps (e.g., @google/genai, @modelcontextprotocol/sdk, openai, vite, vue); likely related.

Poem

I thump my feet on versioned ground,
Bumps all snug, no logic found.
ARM64 sleeps, CI trims its pace,
Packages rise — the build keeps grace.
Hop, hop — a tidy, quieter race 🥕

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/bump-up-safe-deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
package.json (2)

69-69: Consider consolidating HTTP clients (axios vs undici/fetch) to reduce surface area.

We now depend on axios, undici, and SDKs that use fetch. If feasible, standardize on fetch/undici for Node and keep axios only where browser/XHR is required to trim bundle size and avoid adapter edge cases between Electron main/renderer.

Also applies to: 94-94, 87-87


60-61: AWS SDK v3 bump: ensure per-client timeouts/retries are set (avoid long-hanging requests).

If not already centralized, set request timeouts and reasonable retry strategy on Bedrock clients to avoid Electron main-thread stalls.

Provide a shared factory, e.g., createBedrockClient({requestHandler: new NodeHttpHandler({requestTimeout: ms})}).

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0842a78 and 297dd64.

📒 Files selected for processing (1)
  • package.json (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build-check (x64)
🔇 Additional comments (5)
package.json (5)

101-106: No changes needed – notarize import matches v3.x API
The import { notarize } from '@electron/notarize' and subsequent calls align with the v3.0+ documentation (§API uses named notarize export) (packages.electronjs.org)


128-129: Install dependencies and verify type-check & SSR/hydration assumptions

After running pnpm install, execute pnpm run typecheck:web and ensure no vue-tsc errors occur. Also scan your src/ for any defineComponent, withDefaults, or defineModel usages and confirm that component types, SSR, and hydration behaviors remain correct.


137-141: Commit the pnpm lockfile and re-run dependency audits
No pnpm-lock.yaml was found after these bumps—run pnpm install to generate and commit the lockfile, then execute pnpm audit --prod and pnpm audit --dev and confirm there are no advisories for axios, minimatch, yaml, zod, cheerio, undici, openai. Applies also to the other bumped sections (package.json lines 166–167, 97, 71).


59-98: Verify LLM client API usage against bumped SDKs

  • No legacy OpenAI (ChatCompletion/Completions) or Anthropic (anthropic.completions) calls were found.
  • Detected numerous this.ollama.generate() and this.ollama.chat() calls in ollamaProvider.ts—confirm these methods remain valid in ollama@0.5.17.
  • Check your uses of @google/genai for any renamed or removed endpoints after the upgrade.
  • (Optional) Run pnpm install && pnpm dedupe to reconcile lockfile changes.

153-156: Verify Vite dev build

Config files load without syntax errors—please run the Vite dev server (e.g. npm run dev or npx vite dev --config electron.vite.config.ts) to confirm PostCSS/Tailwind integration works correctly with Vite 7.1.4.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (4)
.github/workflows/build.yml (4)

66-74: Remove stale exclude for win-arm64 unpacked dir

Since Windows arm64 is no longer built, this exclude is dead weight.

Apply:

       path: |
         dist/*
         !dist/win-unpacked
-        !dist/win-arm64-unpacked

35-39: Speed up CI: enable pnpm cache

Enable pnpm cache in pnpm/action-setup to cut install time.

Apply in each job:

-      - name: Setup pnpm
-        uses: pnpm/action-setup@v2
-        with:
-          version: 10.12.1
+      - name: Setup pnpm
+        uses: pnpm/action-setup@v2
+        with:
+          version: 10.12.1
+          cache: true

Also applies to: 92-96, 147-150


97-108: Duplicate install on Linux may be redundant

You run pnpm install, then install:sharp, then pnpm install again (without env). If not needed for native rebuilds, drop the second install to save minutes.

Example:

       - name: Install dependencies
         run: pnpm install

       - name: Configure pnpm workspace for Linux ${{ matrix.arch }}
         run: pnpm run install:sharp
         env:
           TARGET_OS: linux
           TARGET_ARCH: ${{ matrix.arch }}

-      - name: Install dependencies
-        run: pnpm install

151-162: Same duplicate install pattern on macOS

Mirror the Linux adjustment if the second install isn’t required.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 297dd64 and eb2677d.

📒 Files selected for processing (1)
  • .github/workflows/build.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build-check (x64)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (5)
.github/workflows/deploycdn.yml (3)

58-61: Win ARM64 disabled but still surfaced in structure/summary — align outputs.

You’ve commented out Win ARM64 copies, but we still:

  • create upgrade2/winarm (Line 31), and
  • advertise a Win ARM64 folder in the summary (Lines 136–137).

This can confuse operators and users. Either drop winarm entirely for now or clearly mark it as disabled.

Apply one of the following diffs.

Option A — remove winarm entirely until it’s re-enabled:

-          mkdir -p cdn_upload/upgrade2/v${{ github.event.inputs.version }}/{linuxx64,macarm,macx64,winx64,winarm}
+          mkdir -p cdn_upload/upgrade2/v${{ github.event.inputs.version }}/{linuxx64,macarm,macx64,winx64}
@@
-          echo "  - winarm/ (所有 Windows ARM64 文件)"
+          :

Option B — keep dir but clarify it’s disabled in the summary:

@@
-          echo "  - winarm/ (所有 Windows ARM64 文件)"
+          echo "  - winarm/ (Windows ARM64 已暂时停用:当前无文件)"

Also applies to: 31-31, 136-137


96-99: Consistent handling for download2: clarify or remove Win ARM64 section.

Win ARM64 executables are not copied anymore. If you keep the platform listed elsewhere, consider adding a matching note for download2 or omit it consistently.


58-61: Prefer a feature flag over commented blocks.

Instead of commented code, gate these blocks with an input/env (default false) so re-enabling is one click.

Example sketch:

@@
   workflow_dispatch:
     inputs:
       workflow_id:
         description: 'Build workflow run ID to use for artifacts'
         required: true
         type: string
+      include_win_arm64:
+        description: 'Include Windows ARM64 artifacts'
+        required: false
+        type: boolean
+        default: false
@@
-          #if [ -d "artifacts/deepchat-win-arm64" ]; then
-          #  echo "Processing Windows arm64 artifacts..."
-          #  cp -r artifacts/deepchat-win-arm64/* cdn_upload/upgrade2/v${{ github.event.inputs.version }}/winarm/ 2>/dev/null || true
-          #fi
+          if [ "${{ github.event.inputs.include_win_arm64 }}" = "true" ] && [ -d "artifacts/deepchat-win-arm64" ]; then
+            echo "Processing Windows arm64 artifacts..."
+            cp -r artifacts/deepchat-win-arm64/* cdn_upload/upgrade2/v${{ github.event.inputs.version }}/winarm/ 2>/dev/null || true
+          fi
@@
-          #if [ -d "artifacts/deepchat-win-arm64" ]; then
-          #  echo "Processing Windows arm64 executables..."
-          #  cp artifacts/deepchat-win-arm64/*.exe cdn_upload/download2/v${{ github.event.inputs.version }}/ 2>/dev/null || true
-          #fi
+          if [ "${{ github.event.inputs.include_win_arm64 }}" = "true" ] && [ -d "artifacts/deepchat-win-arm64" ]; then
+            echo "Processing Windows arm64 executables..."
+            cp artifacts/deepchat-win-arm64/*.exe cdn_upload/download2/v${{ github.event.inputs.version }}/ 2>/dev/null || true
+          fi

Also applies to: 96-99

.github/workflows/release.yml (2)

55-59: Win ARM64 release assets disabled — good. Consider a toggle for quick re-enable.

Mirrors deploycdn.yml. A small input/env flag keeps the workflow clean and avoids commented code drift.

Example sketch:

@@
   workflow_dispatch:
     inputs:
       workflow_id:
         description: 'Build workflow run ID to use for artifacts'
         required: true
         type: string
       prerelease:
         description: 'Is this a prerelease?'
         required: true
         type: boolean
         default: false
+      include_win_arm64:
+        description: 'Include Windows ARM64 assets'
+        type: boolean
+        default: false
@@
-          #if [ -d "artifacts/deepchat-win-arm64" ]; then
-          #  cp artifacts/deepchat-win-arm64/*.exe release_assets/ 2>/dev/null || true
-          #  cp artifacts/deepchat-win-arm64/*.msi release_assets/ 2>/dev/null || true
-          #  cp artifacts/deepchat-win-arm64/*.zip release_assets/ 2>/dev/null || true
-          #fi
+          if [ "${{ github.event.inputs.include_win_arm64 }}" = "true" ] && [ -d "artifacts/deepchat-win-arm64" ]; then
+            cp artifacts/deepchat-win-arm64/*.exe release_assets/ 2>/dev/null || true
+            cp artifacts/deepchat-win-arm64/*.msi release_assets/ 2>/dev/null || true
+            cp artifacts/deepchat-win-arm64/*.zip release_assets/ 2>/dev/null || true
+          fi

33-41: Version extraction hard-depends on Linux x64 tarball.

If a Linux x64 .tar.gz is ever missing but other artifacts exist, the release fails. Consider extracting from any matching artifact to make this more robust.

Example:

-          VERSION_FILE=$(find artifacts/deepchat-linux-x64 -name "DeepChat-*.tar.gz" | head -n 1)
+          VERSION_FILE=$(find artifacts -regex '.*/DeepChat-[0-9]\+\.[0-9]\+\.[0-9]\+.*\.\(tar\.gz\|dmg\|zip\|AppImage\)' | head -n 1)
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between eb2677d and ce26a1e.

📒 Files selected for processing (2)
  • .github/workflows/deploycdn.yml (2 hunks)
  • .github/workflows/release.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build-check (x64)
🔇 Additional comments (2)
.github/workflows/deploycdn.yml (1)

117-124: Sanity-check: action-qiniu-upload uploads only files, so empty winarm dirs are harmless.

No action needed; just noting that empty dirs won’t create stray objects. If you want zero noise in logs, remove the dir as suggested above.

.github/workflows/release.yml (1)

83-91: Nice: draft release with explicit file glob.

This cleanly avoids leaking old assets across runs.

@zerob13 zerob13 merged commit 20f302e into dev Sep 3, 2025
2 checks passed
zerob13 added a commit that referenced this pull request Sep 9, 2025
* fix: chat confg need sync to new value when change model in chat (#823)

* fix: gemini nano banana not read image from chatinput

* fix: remove file-type ,this will mark html as audio (#824)

* fix: Solve the problem of the window becoming larger when dragging floating button under Windows (#826)

* fix: improve OpenAI compatible provider compatibility with third-party services

* chore: update vue-renderer-markdown to v0.0.35 (#827)

* refactor: remove custom-prompts-server and decouple prompts from MCP lifecycle (#829)

- Remove custom-prompts-server service entirely including configuration
- Implement data source merging in MCP store to load prompts from both config and MCP
- Add upgrade migration logic for versions < 0.3.5 to clean up old configurations
- Ensure @ operations work independently of MCP state through config data source
- Update CLAUDE.md with prompt management guidelines

The @ prompt functionality now works completely independently of MCP,
loading custom prompts directly from config storage while maintaining
full compatibility with existing MCP prompt sources.

* chore: add better log for mcp tool name

* feat: ux update (#831)

* feat: ux update

* chore: format

* feat: setting provider ux update (#832)

* feat: add current datetime to system prompt

- Add current date and time information to user's system prompt when not empty
- Include complete datetime with timezone, year, month, day, hour, minute, second
- Apply to both preparePromptContent and buildContinueToolCallContext methods
- Update token calculation to use processed system prompt for accuracy
- Skip datetime addition for image generation models and empty prompts

* refactor: extract system prompt datetime enhancement to common method

- Add enhanceSystemPromptWithDateTime private method to reduce code duplication
- Update both preparePromptContent and buildContinueToolCallContext to use common method
- Improve code maintainability and ensure consistency across all system prompt processing
- Add comprehensive JSDoc documentation for the new method

* fix(markdown): auto-wrap hide scroll (#833)

* feat: add enable_thinking parameter support for siliconcloud (#835)

* chore: bump deps (#834)

* chore: bump up deps

* fix: change win arm to wasm32 sharp

* chore: revert sharp config

* feat: drop windows arm support

* fix(coderabbitai): remove action for windows arm64

* refactor: adjust scroll-to-bottom button glow effect (#837)

* feat: add mutual exclusive confirmation dialogs for DeepSeek-V3.1 (#838)

* feat: add sanitizeText utility for clipboard data handling (#843)

* feat: support canary upgrade (#840)

* feat: support canary upgrade

* feat: add update channel selection for stable/canary versions

- Add update channel configuration to config presenter
- Implement dynamic URL switching for version checks and downloads
- Add UI selector in AboutUsSettings for channel selection
- Support stable and canary update channels with different endpoints
- Add internationalization support for channel selection

* chore: change contributors charts to openomy

* refactor: improve update channel handling and network resilience

- Sanitize update channel input to prevent invalid values
- Add 10-second timeout to version check requests to prevent hanging
- Treat unknown channels as 'upgrade' (stable) for robustness
- Improve error handling for network timeouts and invalid channels

* feat: implement thinking parameter support for doubao models (#842)

* feat: implement dedicated DashScope provider with enable_thinking support (#844)

* feat: implement dedicated DashScope provider with enable_thinking support

* refactor: remove unnecessary API key status check methods from DashscopeProvider

* fix: prioritize provider.id over apiType in createProviderInstance (#846)

* feat: add qwen3 thinking budget support (#848)

* feat: add qwen3 thinking budget support

* fix: add missing gemini.onlySupported key in zh-CN locale

* refactor: merge duplicate silicon case statements in provider creation

* feat: add qwen3 thinking budget support in ChatConfig (#849)

* refactor(types): 🚀split monolithic presenter.d.ts into strict per-domain *.presenter.d.ts + typed core layer  (#847)

* docs: Add strong-typed message architecture and implementation guidelines

- Update message-architecture.md with strong-typed design, remove compatibility compromises
- Add event-to-UI mapping table and rendering checklist for contract compliance
- Create presenter-split-plan.md for type system refactoring
- Add implementation-tasks.md with phased rollout plan
- Create .cursor/rules/provider-guidelines.mdc for provider implementation guidance

This establishes a foundation for strong-typed, maintainable message architecture without legacy compatibility debt.

* types(core): add strong-typed core types and barrel exports\n\n- Add usage.ts (UsageStats, RateLimitInfo)\n- Add llm-events.ts (discriminated union + factories + guards)\n- Add agent-events.ts (LLMAgentEvent*, shared types)\n- Add chat.ts (Message/AssistantMessageBlock/UserMessageContent)\n- Add mcp.ts (MCP content/response/definition)\n- Add types/index.d.ts barrel exports\n\nNo compatibility shims included by design.

* refactor(types): move legacy presenters and add @shared/presenter stub; keep legacy exports in types/index to maintain build\n\n- Move legacy presenters to src/shared/types/presenters/legacy.presenters.d.ts\n- Add src/shared/presenter.d.ts re-export stub\n- Temporarily export only legacy presenters from types/index.d.ts to avoid type mismatches\n- Update implementation-tasks.md (Stage 2 done)\n\nNext: progressive import updates to new cores, then flip barrel to new types and delete legacy.

* refactor(types): alias legacy core message types to strong-typed core (B-plan)\n\n- legacy.presenters.d.ts now re-exports ChatMessage/ChatMessageContent/LLMAgentEvent/LLMAgentEventData/LLMCoreStreamEvent from core\n- Prepares for flipping interfaces without changing import sites

* docs(tasks): mark Phase 3 as completed\n\n- Successfully implemented B-plan approach with type aliasing\n- Unified core message types (ChatMessage, LLMAgentEvent, LLMCoreStreamEvent)\n- Created core model types and maintained build compatibility\n- All type checks passing with no breaking changes

* fix(types): revert to legacy-only exports and fix MESSAGE_ROLE\n\n- Revert types/index.d.ts to only export legacy presenters\n- Remove 'function' from MESSAGE_ROLE to match core definition\n- Maintain build stability while preserving type unification work

* feat(provider): implement factory functions for LLMCoreStreamEvent\n\n- Replace all manual event creation with createStreamEvent factory functions\n- Ensures type safety and consistent event structure\n- Updated OpenAICompatibleProvider with strong-typed events:\n  - text, reasoning, toolCallStart, toolCallChunk, toolCallEnd\n  - error, usage, stop, imageData events\n- All type checks passing\n- Phase 4.1 completed: Provider now outputs LLMCoreStreamEvent with factory construction

* feat(provider): update OllamaProvider with factory functions\n\n- Replace all manual event creation with createStreamEvent factory functions\n- Ensures consistent tool_call_start → tool_call_chunk → tool_call_end sequence\n- Updated all event types: text, reasoning, toolCall*, usage, stop, error\n- Maintains proper tool call ID aggregation and sequencing\n- Phase 4.2 completed: Tool call sequences now strictly follow start/chunk/end pattern

* docs(tasks): update Phase 4 progress\n\n- Completed Provider strong-typed event output with factory functions\n- Completed tool_call_* strict start/chunk/end sequences\n- Completed usage event sent before stop in all providers\n- Updated implementation tasks document with current progress

* feat(phase4): complete Provider strong-typed event integration\n\n- Added factory functions import to AwsBedrockProvider\n- Updated error handling to use createStreamEvent.error() + createStreamEvent.stop('error')\n- Created comprehensive unit tests for LLMCoreStreamEvent factory functions\n- Tests validate: event creation, tool call sequences, error+stop patterns, type guards\n- All 12 core event tests passing ✅\n\n## Phase 4 Completed:\n- ✅ Provider strong-typed event output (factory construction)\n- ✅ tool_call_* strict start/chunk/end sequences with ID aggregation\n- ✅ Usage events sent before stop in all providers\n- ✅ Rate limit events (handled at Presenter layer)\n- ✅ Unified error + stop event patterns\n- ✅ Comprehensive unit tests for sequences/fields/boundaries

* feat(phase5): complete Agent & UI alignment

## Phase 5 Completed: Agent & UI Alignment ✅

### 1. Agent Layer Enhancement
- ✅ Agent consumes only CoreEvent and outputs LLMAgentEvent
- ✅ Strict separation of response/error/end event types
- ✅ Added rate_limit event handling in Agent layer
- ✅ Maintained proper event transformation pipeline

### 2. UI Layer Unification
- ✅ Removed standalone tool_call_permission type
- ✅ Unified to action + action_type pattern
- ✅ Updated all UI components and thread presenter logic
- ✅ Preserved backward compatibility with conditional rendering

### 3. Renderer Mapping & Testing
- ✅ Created comprehensive renderer contract tests (17 tests)
- ✅ Added message block data structure snapshot tests (14 tests)
- ✅ Validated event-to-UI block mapping compliance
- ✅ Ensured consistent status transitions and type safety

### Key Technical Achievements:
- **Type Safety**: All event transformations now type-safe
- **Consistency**: Unified action_type handling across codebase
- **Testing**: 31 new tests covering contracts and snapshots
- **Architecture**: Clean separation between Agent/UI concerns
- **Quality**: All lint, format, and type checks passing ✅

### Files Modified:
- Agent layer: llmProviderPresenter/index.ts
- UI components: MessageItemAssistant.vue
- Thread logic: threadPresenter/index.ts
- Type definitions: shared/chat.d.ts
- Tests: rendererContract.test.ts, messageBlockSnapshot.test.ts

Ready for Phase 6: Quality & Tools 🚀

* feat(phase6): complete Quality & Tools phase

## Phase 6 Completed: Quality & Tools ✅

### 1. Table-Driven Contract Tests
- ✅ Created comprehensive event mapping contract tests (25 test cases)
- ✅ Validated all event types from architecture mapping table
- ✅ Verified status transitions and type constraints
- ✅ Added tool call ID aggregation and lifecycle validation
- ✅ Implemented error recovery pattern testing

### 2. Performance Evaluation & Stress Testing
- ✅ Large text content processing (50KB < 10ms)
- ✅ Large reasoning content handling (100KB < 15ms)
- ✅ Large image data processing (1MB < 20ms)
- ✅ Batch image processing (100 images < 50ms)
- ✅ High-frequency event processing (1000 events < 100ms)
- ✅ Mixed event type handling (500 events < 80ms)
- ✅ Memory leak prevention (5000 events < 500ms)
- ✅ Extreme parameter handling (10KB params < 5ms)
- ✅ Concurrent processing simulation (10 workers < 100ms)

### Key Technical Achievements:
- **Comprehensive Testing**: 67 tests passing across all scenarios
- **Performance Validation**: All benchmarks meet performance targets
- **Type Safety**: Full TypeScript compliance (0 errors)
- **Code Quality**: Lint and format checks passing ✅
- **Architecture Compliance**: All mapping table rules verified
- **Stress Testing**: System handles extreme loads efficiently

### Test Coverage Summary:
- Event mapping contract tests: 25 tests ✅
- Renderer contract tests: 17 tests ✅
- Performance evaluation tests: 9 tests ✅
- Core event factory tests: 12 tests ✅
- Message block snapshot tests: 14 tests ✅
- Shell integration tests: 8 tests ✅

### Files Added:
- test/renderer/message/eventMappingTable.test.ts (comprehensive mapping validation)
- test/renderer/message/performanceEvaluation.test.ts (stress & performance testing)

Ready for production deployment with full quality assurance! 🚀

* fix(providers): complete strong-typed event integration across all providers

* fix(vitest): modify test case

* fix: default settings

* chore: update doc

* fix(ci): remove duplicate check in pr ci

* feat: add pnpm cache for pr check

* fix(ci): pr check with pnpm cache

* fix(ci): change cache key to package.json

* ci: remove pnpm cache

* feat: add glow breathing effect to scroll-to-bottom button (#850)

* feat: add glow breathing effect to scroll-to-bottom button

* fix: ensure exclusive display between MessageList and ArtifactDialog

* fix: refine MessageList–ArtifactDialog interaction logic; correct z-order between dialog and ArtifactDialog

* chore: prettier .vue

* feat: add web search support with configurable options for dashscope (#851)

* feat: add web search support with configurable options for dashscope

* fix: correct qwen model parameters to match official documentation

* feat: add web search support with configurable options for dashscope (#852)

* feat: add web search support with configurable options for dashscope

* fix: correct qwen model parameters to match official documentation

* feat: add search configuration support to ChatConfig components

* fix: fix enableSearch state sync and parameter passing issues

* fix: preserve search settings during data import

* feat: add dashscope commercial models to enable_thinking support (#853)

* feat: add search capability icon for model list (#854)

* feat: add search capability icon for model list

* fix: clear search settings when creating new conversation

* feat(markdown): Thinking panel now supports LaTeX compilation for mathematical formulas & markdown performance optimization (#857)

* feat(markdown): 思考栏支持数学公式latex编译显示 & markdown 性能优化
close: #845

* chore: lint

* chore(ai): update claude code rules and agents

* fix(ui): revert Dialog z-index to z-50 to fix dropdown visibility

Reverts DialogContent z-index from z-[100] back to z-50 to resolve issue where Select and EmojiPicker dropdowns were not appearing. This maintains proper layering hierarchy without breaking other UI components.

* feat: upgrade vue-renderer-markdown & vue-use-monaco (#862)

1. ignore math-block warning
2. Compatible with the syntax issues of mermaid produced by AI, greatly reducing the probability of mermaid rendering errors

* feat(dashscope): add qwen3-max-preview model (#865)

* fix: mcp params support more types (#861)

* feat(mcp): enhance tool parameter display with enum type support

- Add enum parameter type detection and enhanced display
- Show enum parameters with distinct blue badge styling (enum(string), array[enum(string)])
- Display allowed values for both direct enum and array item enum parameters
- Add i18n support for "allowedValues" and "arrayItemValues" labels
- Maintain consistent UI design with existing parameter display patterns
- Improve developer experience when debugging MCP tools with constrained parameters

* fix: enum params support

* fix(context-menu): handle local file paths in image save functionality

- Fix URL parsing error when saving images from local file paths
- Add proper handling for http/https URLs, file:// URLs, and direct file paths
- Use fs.promises for reading local files instead of net.fetch for invalid URLs
- Prevent "Failed to parse URL from" error when saving local images

* fix(context-menu): improve URL handling robustness in image save

- Add try-catch around net.fetch to handle invalid URLs gracefully
- Implement fallback methods for file:// URLs and local file paths
- Add debug logging to track source URL values for troubleshooting
- Prevent "Failed to parse URL from" errors with comprehensive URL validation

* fix(context-menu): handle empty srcURL in image save functionality

- Add comprehensive URL detection when srcURL is empty
- Implement fallback URL sources (linkURL, pageURL) for better compatibility
- Add debug logging to track all available context menu parameters
- Prevent "Failed to parse URL from" errors caused by empty URLs
- Provide clear error message when no valid URL can be found

* chore: format code

* fix: ai review

* fix: prevent @ symbol remaining when deleting mentions (#867)

* Merge commit from fork

* feat: implement separated system and custom prompt management (#868)

* feat: implement separated system and custom prompt management

* style: code fmt

* fix: add migration for legacy default_system_prompt to system_prompts

* feat: add Moonshot model configurations (#869)

* refactor: translate all cn comments and log to en (#871)

* refactor: translate all cn comments and log to en

* fix: revert translate in params

* feat: add reasoning support for Grok thinking models (#873)

* feat: add reasoning support for Grok thinking models

* fix: code lint

* fix: escaping character issue

---------

Co-authored-by: zerob13 <zerob13@gmail.com>

---------

Co-authored-by: hllshiro <40970081+hllshiro@users.noreply.github.com>
Co-authored-by: yyhhyyyyyy <yyhhyyyyyy8@gmail.com>
Co-authored-by: xiaomo <wegi866@gmail.com>
Co-authored-by: Simon He <57086651+Simon-He95@users.noreply.github.com>
Co-authored-by: luy <12696648@qq.com>
@zerob13 zerob13 deleted the chore/bump-up-safe-deps branch September 21, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants