Skip to content

Conversation

@yyhhyyyyyy
Copy link
Collaborator

@yyhhyyyyyy yyhhyyyyyy commented Sep 3, 2025

add mutual exclusive confirmation dialogs for DeepSeek-V3.1

CleanShot.2025-09-03.at.15.52.42.mp4

Summary by CodeRabbit

  • New Features
    • Enforced mutual exclusivity between reasoning and function calling for DeepSeek‑V3.1 models, with a confirmation dialog and on-screen warnings.
  • Bug Fixes
    • Updated DeepSeek‑V3.1 model settings to disable reasoning by default to prevent conflicts.
  • Chores
    • Added localization for the new confirmation and warning texts across en-US, fa-IR, fr-FR, ja-JP, ko-KR, ru-RU, zh-CN, zh-HK, and zh-TW.
    • Minor copy correction in French localization.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 3, 2025

Walkthrough

Updates DeepSeek-V3.1 model settings to disable reasoning by default and adds mutual-exclusion handling between reasoning and functionCall in the ModelConfigDialog UI, including a confirmation dialog. Introduces new i18n strings across multiple locales for the mutual-exclusion flow and a minor French copy fix.

Changes

Cohort / File(s) Summary
Provider model flags
src/main/presenter/configPresenter/providerModelSettings.ts
Flips reasoning from true→false for deepseek-ai/DeepSeek-V3.1 and Pro/deepseek-ai/DeepSeek-V3.1. No API/signature changes.
Settings UI mutual exclusion
src/renderer/src/components/settings/ModelConfigDialog.vue
Adds mutual-exclusion logic between reasoning and functionCall for DeepSeek‑V3.1, with confirmation dialog, warning notes, explicit checked handlers, and new state/helpers. No prop/signature changes.
i18n additions
src/renderer/src/i18n/*/dialog.json
Adds mutualExclusive block (title, message, warningText, confirmEnable) in en-US, fa-IR, fr-FR, ja-JP, ko-KR, ru-RU, zh-CN, zh-HK, zh-TW. Also fixes a typographic apostrophe in fr-FR fork.description.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor U as User
  participant M as ModelConfigDialog
  participant A as AlertDialog

  U->>M: Toggle Reasoning or Function Call
  M->>M: Detect model == DeepSeek-V3.1
  alt Opposite feature already enabled
    M->>A: Open confirmation (mutualExclusive.*)
    alt User confirms
      A-->>M: confirm
      M->>M: Enable requested feature<br/>Disable opposite feature
      M-->>U: Update switches
    else User cancels
      A-->>M: cancel
      M-->>U: No change
    end
  else No conflict or other models
    M->>M: Apply toggle normally
    M-->>U: Update switches
  end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested reviewers

  • zerob13
  • deepinfect

Poem

A twitch of whiskers, switch goes click—
Reasoning hops, calls must stick.
DeepSeek’s paths diverge in two,
Pick one trail, the other shoo.
Carrot-confirm, we choose our role—
One bun-feature per warren goal. 🥕🐇

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/dialog-mutual-exclusive-support

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/renderer/src/components/settings/ModelConfigDialog.vue (1)

400-419: Enforce invariant on load/save to handle legacy configs.

If an existing user config has both flags true for DeepSeek‑V3.1, the UI might persist an invalid combo. Sanitize on load and before save.

@@
-    const modelConfig = await settingsStore.getModelConfig(props.modelId, props.providerId)
-    config.value = { ...modelConfig }
+    const modelConfig = await settingsStore.getModelConfig(props.modelId, props.providerId)
+    config.value = { ...modelConfig }
+    // Enforce mutual exclusivity for DeepSeek‑V3.1 on load (prefer disabling reasoning to align with defaults)
+    if (isDeepSeekV31Model.value && config.value.functionCall && config.value.reasoning) {
+      config.value.reasoning = false
+    }
@@
-    await settingsStore.setModelConfig(props.modelId, props.providerId, config.value)
+    // Enforce mutual exclusivity again before persisting
+    const cfg = { ...config.value }
+    if (isDeepSeekV31Model.value && cfg.functionCall && cfg.reasoning) {
+      cfg.reasoning = false
+    }
+    await settingsStore.setModelConfig(props.modelId, props.providerId, cfg)

Also applies to: 468-472

🧹 Nitpick comments (10)
src/renderer/src/i18n/zh-CN/dialog.json (1)

29-42: Polish CN copy for consistency and clarity (“功能” usage, wording of limitation).

Minor CN copy nits: unify “功能” suffix usage and prefer “由于…的限制” over “限制要求”.

-      "reasoning": "开启推理能力将自动关闭函数调用功能。这是 DeepSeek-V3.1 模型的限制要求,两个功能无法同时使用。是否继续?",
-      "functionCall": "开启函数调用将自动关闭推理能力功能。这是 DeepSeek-V3.1 模型的限制要求,两个功能无法同时使用。是否继续?"
+      "reasoning": "开启推理能力将自动关闭函数调用。由于 DeepSeek‑V3.1 模型的限制,两个功能无法同时使用。是否继续?",
+      "functionCall": "开启函数调用将自动关闭推理能力。由于 DeepSeek‑V3.1 模型的限制,两个功能无法同时使用。是否继续?"
@@
-      "reasoning": "注意:开启推理能力将自动关闭函数调用功能,这是 DeepSeek-V3.1 模型的限制要求。",
-      "functionCall": "注意:开启函数调用将自动关闭推理能力,这是 DeepSeek-V3.1 模型的限制要求。"
+      "reasoning": "注意:开启推理能力将自动关闭函数调用,因 DeepSeek‑V3.1 模型的限制所致。",
+      "functionCall": "注意:开启函数调用将自动关闭推理能力,因 DeepSeek‑V3.1 模型的限制所致。"
src/renderer/src/i18n/zh-HK/dialog.json (1)

29-42: Polish HK copy; unify “功能” suffix and limitation phrasing.

Keep terminology consistent with existing file; small Traditional Chinese tweaks.

-      "reasoning": "開啟推理能力將自動關閉函數調用功能。這是 DeepSeek-V3.1 模型的限制要求,兩個功能無法同時使用。是否繼續?",
-      "functionCall": "開啟函數調用將自動關閉推理能力功能。這是 DeepSeek-V3.1 模型的限制要求,兩個功能無法同時使用。是否繼續?"
+      "reasoning": "開啟推理能力將自動關閉函數調用。由於 DeepSeek‑V3.1 模型的限制,兩個功能無法同時使用。是否繼續?",
+      "functionCall": "開啟函數調用將自動關閉推理能力。由於 DeepSeek‑V3.1 模型的限制,兩個功能無法同時使用。是否繼續?"
@@
-      "reasoning": "注意:開啟推理能力將自動關閉函數調用功能,這是 DeepSeek-V3.1 模型的限制要求。",
-      "functionCall": "注意:開啟函數調用將自動關閉推理能力,這是 DeepSeek-V3.1 模型的限制要求。"
+      "reasoning": "注意:開啟推理能力將自動關閉函數調用,為 DeepSeek‑V3.1 模型之限制。",
+      "functionCall": "注意:開啟函數調用將自動關閉推理能力,為 DeepSeek‑V3.1 模型之限制。"
src/renderer/src/i18n/ja-JP/dialog.json (1)

29-42: Natural Japanese phrasing (“仕様上の制約”).

“制限要件” sounds stiff; suggest “仕様上の制約”. Also slight punctuation polish.

-      "reasoning": "推論機能を有効にすると、関数呼び出し機能が自動的に無効になります。これはDeepSeek-V3.1モデルの制限要件であり、両機能を同時に使用することはできません。続行しますか?",
-      "functionCall": "関数呼び出し機能を有効にすると、推論機能が自動的に無効になります。これはDeepSeek-V3.1モデルの制限要件であり、両機能を同時に使用することはできません。続行しますか?"
+      "reasoning": "推論機能を有効にすると、関数呼び出し機能が自動的に無効になります。これは DeepSeek‑V3.1 モデルの仕様上の制約により、両機能を同時に使用することはできません。続行しますか?",
+      "functionCall": "関数呼び出し機能を有効にすると、推論機能が自動的に無効になります。これは DeepSeek‑V3.1 モデルの仕様上の制約により、両機能を同時に使用することはできません。続行しますか?"
@@
-      "reasoning": "注意:推論機能を有効にすると関数呼び出し機能が自動的に無効になります。これはDeepSeek-V3.1モデルの制限要件です。",
-      "functionCall": "注意:関数呼び出し機能を有効にすると推論機能が自動的に無効になります。これはDeepSeek-V3.1モデルの制限要件です。"
+      "reasoning": "注意:推論機能を有効にすると関数呼び出し機能が自動的に無効になります。これは DeepSeek‑V3.1 モデルの仕様上の制約です。",
+      "functionCall": "注意:関数呼び出し機能を有効にすると推論機能が自動的に無効になります。これは DeepSeek‑V3.1 モデルの仕様上の制約です。"
src/renderer/src/i18n/en-US/dialog.json (1)

29-42: Tighten EN copy; more natural titles and consistent “limitation” wording.

“Confirm Enable …” reads awkwardly. Also unify “limitation” across message and warning.

-      "reasoning": "Confirm Enable Reasoning",
-      "functionCall": "Confirm Enable Function Calling"
+      "reasoning": "Enable Reasoning",
+      "functionCall": "Enable Function Calling"
@@
-      "reasoning": "Enabling reasoning will automatically disable function calling. This is a limitation of DeepSeek-V3.1 models, and both features cannot be used simultaneously. Continue?",
-      "functionCall": "Enabling function calling will automatically disable reasoning. This is a limitation of DeepSeek-V3.1 models, and both features cannot be used simultaneously. Continue?"
+      "reasoning": "Enabling reasoning will automatically disable function calling. This is a limitation of DeepSeek‑V3.1 models. Both features cannot be used simultaneously. Continue?",
+      "functionCall": "Enabling function calling will automatically disable reasoning. This is a limitation of DeepSeek‑V3.1 models. Both features cannot be used simultaneously. Continue?"
@@
-      "reasoning": "Note: Enabling reasoning will automatically disable function calling, which is a requirement of DeepSeek-V3.1 models.",
-      "functionCall": "Note: Enabling function calling will automatically disable reasoning, which is a requirement of DeepSeek-V3.1 models."
+      "reasoning": "Note: Enabling reasoning will automatically disable function calling, due to a limitation of DeepSeek‑V3.1 models.",
+      "functionCall": "Note: Enabling function calling will automatically disable reasoning, due to a limitation of DeepSeek‑V3.1 models."
src/renderer/src/components/settings/ModelConfigDialog.vue (4)

386-392: Name the action fields by intent.

Optional: rename from/to → enable/disable for self-documenting state. No functional change.

-const mutualExclusiveAction = ref<{
-  from: 'reasoning' | 'functionCall'
-  to: 'reasoning' | 'functionCall'
-} | null>(null)
+const mutualExclusiveAction = ref<{
+  enable: 'reasoning' | 'functionCall'
+  disable: 'reasoning' | 'functionCall'
+} | null>(null)

Follow-up: adjust references accordingly in handlers.


542-546: Broaden model-id match to avoid false negatives (punctuation variants).

Guard against IDs like “deepseek/v3_1” or “DeepSeek V3-1”.

-const isDeepSeekV31Model = computed(() => {
-  const modelId = props.modelId.toLowerCase()
-  return modelId.includes('deepseek-v3.1') || modelId.includes('deepseek-v3-1')
-})
+const isDeepSeekV31Model = computed(() => {
+  const id = props.modelId.toLowerCase().replace(/[^a-z0-9]/g, '')
+  return id.includes('deepseekv31')
+})

121-124: Use English for new comments to match repo guidelines.

Convert newly added Chinese comments to English.

-              <!-- DeepSeek-V3.1 互斥提示 -->
+              <!-- DeepSeek‑V3.1 mutual-exclusion notice -->
@@
-              <!-- DeepSeek-V3.1 互斥提示 -->
+              <!-- DeepSeek‑V3.1 mutual-exclusion notice -->
@@
-  <!-- DeepSeek-V3.1 互斥确认对话框 -->
+  <!-- DeepSeek‑V3.1 mutual-exclusion confirmation dialog -->
@@
-// DeepSeek-V3.1 互斥确认对话框
+// DeepSeek‑V3.1 mutual-exclusion confirmation dialog

Also applies to: 136-139, 297-297, 386-386


638-660: Offer: add telemetry for declines (optional).

If useful, emit a no-op metric when users cancel the dialog; helps UX tuning.

Want a small composable that logs accept/decline counts keyed by model/provider?

src/renderer/src/i18n/fr-FR/dialog.json (2)

29-42: Unify tone and terminology (“limitation” vs “exigence”) and tighten phrasing

Minor copy refinements for consistency and flow. Prefer “activées simultanément” (UI toggles) and use “limitation” consistently in both message and warningText. Also drop the superfluous comma before “et”.

Apply this diff:

-      "reasoning": "L'activation du raisonnement désactivera automatiquement les appels de fonction. Il s'agit d'une limitation des modèles DeepSeek-V3.1, et les deux fonctionnalités ne peuvent pas être utilisées simultanément. Continuer ?",
-      "functionCall": "L'activation des appels de fonction désactivera automatiquement le raisonnement. Il s'agit d'une limitation des modèles DeepSeek-V3.1, et les deux fonctionnalités ne peuvent pas être utilisées simultanément. Continuer ?"
+      "reasoning": "L'activation du raisonnement désactivera automatiquement les appels de fonction. C'est une limitation des modèles DeepSeek-V3.1 et les deux fonctionnalités ne peuvent pas être activées simultanément. Continuer ?",
+      "functionCall": "L'activation des appels de fonction désactivera automatiquement le raisonnement. C'est une limitation des modèles DeepSeek-V3.1 et les deux fonctionnalités ne peuvent pas être activées simultanément. Continuer ?"
@@
-      "reasoning": "Attention : L'activation du raisonnement désactivera automatiquement les appels de fonction, ce qui est une exigence des modèles DeepSeek-V3.1.",
-      "functionCall": "Attention : L'activation des appels de fonction désactivera automatiquement le raisonnement, ce qui est une exigence des modèles DeepSeek-V3.1."
+      "reasoning": "Attention : L'activation du raisonnement désactivera automatiquement les appels de fonction. C'est une limitation des modèles DeepSeek-V3.1.",
+      "functionCall": "Attention : L'activation des appels de fonction désactivera automatiquement le raisonnement. C'est une limitation des modèles DeepSeek-V3.1."

29-42: French typography nit: optional narrow no‑break space before “: ? !”

If you enforce French typographic rules, consider U+202F before “:”, “?” in these strings. Otherwise, current spacing is acceptable.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0e5b4ed and 086ab32.

📒 Files selected for processing (11)
  • src/main/presenter/configPresenter/providerModelSettings.ts (2 hunks)
  • src/renderer/src/components/settings/ModelConfigDialog.vue (7 hunks)
  • src/renderer/src/i18n/en-US/dialog.json (1 hunks)
  • src/renderer/src/i18n/fa-IR/dialog.json (1 hunks)
  • src/renderer/src/i18n/fr-FR/dialog.json (1 hunks)
  • src/renderer/src/i18n/ja-JP/dialog.json (1 hunks)
  • src/renderer/src/i18n/ko-KR/dialog.json (1 hunks)
  • src/renderer/src/i18n/ru-RU/dialog.json (1 hunks)
  • src/renderer/src/i18n/zh-CN/dialog.json (1 hunks)
  • src/renderer/src/i18n/zh-HK/dialog.json (1 hunks)
  • src/renderer/src/i18n/zh-TW/dialog.json (1 hunks)
🧰 Additional context used
📓 Path-based instructions (17)
src/renderer/src/**/*

📄 CodeRabbit inference engine (.cursor/rules/i18n.mdc)

src/renderer/src/**/*: All user-facing strings must use i18n keys (avoid hardcoded user-visible text in code)
Use the 'vue-i18n' framework for all internationalization in the renderer
Ensure all user-visible text in the renderer uses the translation system

Files:

  • src/renderer/src/components/settings/ModelConfigDialog.vue
  • src/renderer/src/i18n/fa-IR/dialog.json
  • src/renderer/src/i18n/ja-JP/dialog.json
  • src/renderer/src/i18n/zh-HK/dialog.json
  • src/renderer/src/i18n/zh-TW/dialog.json
  • src/renderer/src/i18n/ko-KR/dialog.json
  • src/renderer/src/i18n/zh-CN/dialog.json
  • src/renderer/src/i18n/ru-RU/dialog.json
  • src/renderer/src/i18n/en-US/dialog.json
  • src/renderer/src/i18n/fr-FR/dialog.json
src/renderer/**/*.{vue,ts,js,tsx,jsx}

📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)

渲染进程代码放在 src/renderer

Files:

  • src/renderer/src/components/settings/ModelConfigDialog.vue
src/renderer/src/**/*.{vue,ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/vue-best-practices.mdc)

src/renderer/src/**/*.{vue,ts,tsx,js,jsx}: Use the Composition API for better code organization and reusability
Implement proper state management with Pinia
Utilize Vue Router for navigation and route management
Leverage Vue's built-in reactivity system for efficient data handling

Files:

  • src/renderer/src/components/settings/ModelConfigDialog.vue
src/renderer/src/**/*.vue

📄 CodeRabbit inference engine (.cursor/rules/vue-best-practices.mdc)

Use scoped styles to prevent CSS conflicts between components

Files:

  • src/renderer/src/components/settings/ModelConfigDialog.vue
src/renderer/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)

src/renderer/**/*.{ts,tsx,vue}: Use descriptive variable names with auxiliary verbs (e.g., isLoading, hasError).
Use TypeScript for all code; prefer types over interfaces.
Avoid enums; use const objects instead.
Use arrow functions for methods and computed properties.
Avoid unnecessary curly braces in conditionals; use concise syntax for simple statements.

Files:

  • src/renderer/src/components/settings/ModelConfigDialog.vue
src/renderer/**/*.{vue,ts}

📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)

Implement lazy loading for routes and components.

Files:

  • src/renderer/src/components/settings/ModelConfigDialog.vue
src/renderer/**/*.{ts,vue}

📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)

src/renderer/**/*.{ts,vue}: Use useFetch and useAsyncData for data fetching.
Implement SEO best practices using Nuxt's useHead and useSeoMeta.

Use Pinia for frontend state management

Files:

  • src/renderer/src/components/settings/ModelConfigDialog.vue
src/renderer/**/*.vue

📄 CodeRabbit inference engine (CLAUDE.md)

src/renderer/**/*.vue: Use Vue 3 Composition API for all Vue components
Use Tailwind CSS with scoped styles for component styling
When creating new UI components, use Composition API with proper TypeScript typing, ensure responsive design (Tailwind), and include error/loading states

Files:

  • src/renderer/src/components/settings/ModelConfigDialog.vue
**/*.{ts,tsx,js,jsx,vue}

📄 CodeRabbit inference engine (CLAUDE.md)

Write logs and comments in English

Files:

  • src/renderer/src/components/settings/ModelConfigDialog.vue
  • src/main/presenter/configPresenter/providerModelSettings.ts
src/renderer/src/**

📄 CodeRabbit inference engine (CLAUDE.md)

Place full application UI functionality (tab content) under src/renderer/src/ organized by feature

Files:

  • src/renderer/src/components/settings/ModelConfigDialog.vue
  • src/renderer/src/i18n/fa-IR/dialog.json
  • src/renderer/src/i18n/ja-JP/dialog.json
  • src/renderer/src/i18n/zh-HK/dialog.json
  • src/renderer/src/i18n/zh-TW/dialog.json
  • src/renderer/src/i18n/ko-KR/dialog.json
  • src/renderer/src/i18n/zh-CN/dialog.json
  • src/renderer/src/i18n/ru-RU/dialog.json
  • src/renderer/src/i18n/en-US/dialog.json
  • src/renderer/src/i18n/fr-FR/dialog.json
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development-setup.mdc)

**/*.{js,jsx,ts,tsx}: 使用 OxLint 进行代码检查
Log和注释使用英文书写

Files:

  • src/main/presenter/configPresenter/providerModelSettings.ts
src/{main,renderer}/**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/electron-best-practices.mdc)

src/{main,renderer}/**/*.ts: Use context isolation for improved security
Implement proper inter-process communication (IPC) patterns
Optimize application startup time with lazy loading
Implement proper error handling and logging for debugging

Files:

  • src/main/presenter/configPresenter/providerModelSettings.ts
src/main/**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/electron-best-practices.mdc)

Use Electron's built-in APIs for file system and native dialogs

Files:

  • src/main/presenter/configPresenter/providerModelSettings.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/error-logging.mdc)

**/*.{ts,tsx}: 始终使用 try-catch 处理可能的错误
提供有意义的错误信息
记录详细的错误日志
优雅降级处理
日志应包含时间戳、日志级别、错误代码、错误描述、堆栈跟踪(如适用)、相关上下文信息
日志级别应包括 ERROR、WARN、INFO、DEBUG
不要吞掉错误
提供用户友好的错误信息
实现错误重试机制
避免记录敏感信息
使用结构化日志
设置适当的日志级别

Enable and adhere to strict TypeScript type checking across the codebase

Files:

  • src/main/presenter/configPresenter/providerModelSettings.ts
src/main/**/*.{ts,js,tsx,jsx}

📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)

主进程代码放在 src/main

Files:

  • src/main/presenter/configPresenter/providerModelSettings.ts
src/main/presenter/**/*.ts

📄 CodeRabbit inference engine (CLAUDE.md)

Maintain one Presenter per functional domain under src/main/presenter/

Files:

  • src/main/presenter/configPresenter/providerModelSettings.ts
src/main/presenter/configPresenter/**

📄 CodeRabbit inference engine (CLAUDE.md)

Centralize configuration logic under configPresenter/

Files:

  • src/main/presenter/configPresenter/providerModelSettings.ts
🧠 Learnings (3)
📚 Learning: 2025-07-21T01:46:52.880Z
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.880Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : Provider implementations should yield reasoning events in the standardized format when applicable.

Applied to files:

  • src/main/presenter/configPresenter/providerModelSettings.ts
📚 Learning: 2025-09-01T09:16:58.033Z
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-09-01T09:16:58.033Z
Learning: Applies to src/main/presenter/configPresenter/providers.ts : Add new provider configuration entries in configPresenter/providers.ts

Applied to files:

  • src/main/presenter/configPresenter/providerModelSettings.ts
📚 Learning: 2025-07-21T01:46:30.354Z
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/i18n.mdc:0-0
Timestamp: 2025-07-21T01:46:30.354Z
Learning: Applies to src/renderer/src/i18n/common.json : Shared translation keys must be placed in 'src/renderer/src/i18n/common.json'

Applied to files:

  • src/renderer/src/i18n/ko-KR/dialog.json
  • src/renderer/src/i18n/ru-RU/dialog.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build-check (x64)
🔇 Additional comments (15)
src/main/presenter/configPresenter/providerModelSettings.ts (1)

1885-1885: Approve DeepSeek-V3.1 reasoning=false & functionCall mutual-exclusion
Verification confirms both provider entries default to reasoning: false, the UI switches leverage the new mutualExclusive warning and confirmation keys, and all dialog locales include the required mutualExclusive entries. LGTM.

src/renderer/src/i18n/fa-IR/dialog.json (1)

29-42: Approve mutualExclusive dialog keys

Verified that the mutualExclusive keys (title, message, warningText, confirmEnable) are present in all dialog.json locales.

src/renderer/src/i18n/ru-RU/dialog.json (1)

29-42: RU translation block mirrors the intended key shape

Copy reads clear; keys align with other locales. LGTM.

src/renderer/src/i18n/ko-KR/dialog.json (1)

29-42: KR translation block added with correct keys

Consistent with the mutual‑exclusion UI needs. LGTM.

src/renderer/src/i18n/zh-TW/dialog.json (1)

29-42: ZH‑TW translation block added and keyed correctly

Matches the structure used in other locales. LGTM.

src/renderer/src/components/settings/ModelConfigDialog.vue (8)

121-127: Good UX: contextual warning under Function Calling.

Uses i18n and Tailwind; keeps renderer free of hardcoded strings. LGTM.


126-127: Switch handler refactor is correct.

Replacing v-model with explicit :checked + @update:checked enables interception for mutual exclusion.


136-142: Good UX: contextual warning under Reasoning.

Consistent with the Function Calling section; i18n-compliant. LGTM.


297-316: Alert dialog wiring looks solid and i18n-compliant.

Title/description derive from computed i18n keys; cancel/confirm wired to handlers. LGTM.


342-351: Imports for AlertDialog are scoped and minimal.

No unused imports; aligns with component usage. LGTM.


638-652: Core toggle logic reads correctly.

Blocks enabling when opposite feature is on for DeepSeek‑V3.1, defers to confirmation. LGTM.


667-676: Confirmation applies the invariant correctly.

Enables requested feature and disables the opposite; clears dialog state. LGTM.


678-689: Computed getters for dialog text are clean.

Return empty string when no action; keys are correct. LGTM.

src/renderer/src/i18n/fr-FR/dialog.json (2)

26-28: Fork copy text: looks good

The French phrasing reads naturally and matches intent. Nothing else to change here.


29-42: Localization key parity and usage verified: All mutualExclusive keys are present in every i18n/*/dialog.json and are consumed in ModelConfigDialog.vue.

Copy link
Collaborator

@zerob13 zerob13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zerob13 zerob13 merged commit 774ee4b into dev Sep 3, 2025
2 checks passed
zerob13 added a commit that referenced this pull request Sep 9, 2025
* fix: chat confg need sync to new value when change model in chat (#823)

* fix: gemini nano banana not read image from chatinput

* fix: remove file-type ,this will mark html as audio (#824)

* fix: Solve the problem of the window becoming larger when dragging floating button under Windows (#826)

* fix: improve OpenAI compatible provider compatibility with third-party services

* chore: update vue-renderer-markdown to v0.0.35 (#827)

* refactor: remove custom-prompts-server and decouple prompts from MCP lifecycle (#829)

- Remove custom-prompts-server service entirely including configuration
- Implement data source merging in MCP store to load prompts from both config and MCP
- Add upgrade migration logic for versions < 0.3.5 to clean up old configurations
- Ensure @ operations work independently of MCP state through config data source
- Update CLAUDE.md with prompt management guidelines

The @ prompt functionality now works completely independently of MCP,
loading custom prompts directly from config storage while maintaining
full compatibility with existing MCP prompt sources.

* chore: add better log for mcp tool name

* feat: ux update (#831)

* feat: ux update

* chore: format

* feat: setting provider ux update (#832)

* feat: add current datetime to system prompt

- Add current date and time information to user's system prompt when not empty
- Include complete datetime with timezone, year, month, day, hour, minute, second
- Apply to both preparePromptContent and buildContinueToolCallContext methods
- Update token calculation to use processed system prompt for accuracy
- Skip datetime addition for image generation models and empty prompts

* refactor: extract system prompt datetime enhancement to common method

- Add enhanceSystemPromptWithDateTime private method to reduce code duplication
- Update both preparePromptContent and buildContinueToolCallContext to use common method
- Improve code maintainability and ensure consistency across all system prompt processing
- Add comprehensive JSDoc documentation for the new method

* fix(markdown): auto-wrap hide scroll (#833)

* feat: add enable_thinking parameter support for siliconcloud (#835)

* chore: bump deps (#834)

* chore: bump up deps

* fix: change win arm to wasm32 sharp

* chore: revert sharp config

* feat: drop windows arm support

* fix(coderabbitai): remove action for windows arm64

* refactor: adjust scroll-to-bottom button glow effect (#837)

* feat: add mutual exclusive confirmation dialogs for DeepSeek-V3.1 (#838)

* feat: add sanitizeText utility for clipboard data handling (#843)

* feat: support canary upgrade (#840)

* feat: support canary upgrade

* feat: add update channel selection for stable/canary versions

- Add update channel configuration to config presenter
- Implement dynamic URL switching for version checks and downloads
- Add UI selector in AboutUsSettings for channel selection
- Support stable and canary update channels with different endpoints
- Add internationalization support for channel selection

* chore: change contributors charts to openomy

* refactor: improve update channel handling and network resilience

- Sanitize update channel input to prevent invalid values
- Add 10-second timeout to version check requests to prevent hanging
- Treat unknown channels as 'upgrade' (stable) for robustness
- Improve error handling for network timeouts and invalid channels

* feat: implement thinking parameter support for doubao models (#842)

* feat: implement dedicated DashScope provider with enable_thinking support (#844)

* feat: implement dedicated DashScope provider with enable_thinking support

* refactor: remove unnecessary API key status check methods from DashscopeProvider

* fix: prioritize provider.id over apiType in createProviderInstance (#846)

* feat: add qwen3 thinking budget support (#848)

* feat: add qwen3 thinking budget support

* fix: add missing gemini.onlySupported key in zh-CN locale

* refactor: merge duplicate silicon case statements in provider creation

* feat: add qwen3 thinking budget support in ChatConfig (#849)

* refactor(types): 🚀split monolithic presenter.d.ts into strict per-domain *.presenter.d.ts + typed core layer  (#847)

* docs: Add strong-typed message architecture and implementation guidelines

- Update message-architecture.md with strong-typed design, remove compatibility compromises
- Add event-to-UI mapping table and rendering checklist for contract compliance
- Create presenter-split-plan.md for type system refactoring
- Add implementation-tasks.md with phased rollout plan
- Create .cursor/rules/provider-guidelines.mdc for provider implementation guidance

This establishes a foundation for strong-typed, maintainable message architecture without legacy compatibility debt.

* types(core): add strong-typed core types and barrel exports\n\n- Add usage.ts (UsageStats, RateLimitInfo)\n- Add llm-events.ts (discriminated union + factories + guards)\n- Add agent-events.ts (LLMAgentEvent*, shared types)\n- Add chat.ts (Message/AssistantMessageBlock/UserMessageContent)\n- Add mcp.ts (MCP content/response/definition)\n- Add types/index.d.ts barrel exports\n\nNo compatibility shims included by design.

* refactor(types): move legacy presenters and add @shared/presenter stub; keep legacy exports in types/index to maintain build\n\n- Move legacy presenters to src/shared/types/presenters/legacy.presenters.d.ts\n- Add src/shared/presenter.d.ts re-export stub\n- Temporarily export only legacy presenters from types/index.d.ts to avoid type mismatches\n- Update implementation-tasks.md (Stage 2 done)\n\nNext: progressive import updates to new cores, then flip barrel to new types and delete legacy.

* refactor(types): alias legacy core message types to strong-typed core (B-plan)\n\n- legacy.presenters.d.ts now re-exports ChatMessage/ChatMessageContent/LLMAgentEvent/LLMAgentEventData/LLMCoreStreamEvent from core\n- Prepares for flipping interfaces without changing import sites

* docs(tasks): mark Phase 3 as completed\n\n- Successfully implemented B-plan approach with type aliasing\n- Unified core message types (ChatMessage, LLMAgentEvent, LLMCoreStreamEvent)\n- Created core model types and maintained build compatibility\n- All type checks passing with no breaking changes

* fix(types): revert to legacy-only exports and fix MESSAGE_ROLE\n\n- Revert types/index.d.ts to only export legacy presenters\n- Remove 'function' from MESSAGE_ROLE to match core definition\n- Maintain build stability while preserving type unification work

* feat(provider): implement factory functions for LLMCoreStreamEvent\n\n- Replace all manual event creation with createStreamEvent factory functions\n- Ensures type safety and consistent event structure\n- Updated OpenAICompatibleProvider with strong-typed events:\n  - text, reasoning, toolCallStart, toolCallChunk, toolCallEnd\n  - error, usage, stop, imageData events\n- All type checks passing\n- Phase 4.1 completed: Provider now outputs LLMCoreStreamEvent with factory construction

* feat(provider): update OllamaProvider with factory functions\n\n- Replace all manual event creation with createStreamEvent factory functions\n- Ensures consistent tool_call_start → tool_call_chunk → tool_call_end sequence\n- Updated all event types: text, reasoning, toolCall*, usage, stop, error\n- Maintains proper tool call ID aggregation and sequencing\n- Phase 4.2 completed: Tool call sequences now strictly follow start/chunk/end pattern

* docs(tasks): update Phase 4 progress\n\n- Completed Provider strong-typed event output with factory functions\n- Completed tool_call_* strict start/chunk/end sequences\n- Completed usage event sent before stop in all providers\n- Updated implementation tasks document with current progress

* feat(phase4): complete Provider strong-typed event integration\n\n- Added factory functions import to AwsBedrockProvider\n- Updated error handling to use createStreamEvent.error() + createStreamEvent.stop('error')\n- Created comprehensive unit tests for LLMCoreStreamEvent factory functions\n- Tests validate: event creation, tool call sequences, error+stop patterns, type guards\n- All 12 core event tests passing ✅\n\n## Phase 4 Completed:\n- ✅ Provider strong-typed event output (factory construction)\n- ✅ tool_call_* strict start/chunk/end sequences with ID aggregation\n- ✅ Usage events sent before stop in all providers\n- ✅ Rate limit events (handled at Presenter layer)\n- ✅ Unified error + stop event patterns\n- ✅ Comprehensive unit tests for sequences/fields/boundaries

* feat(phase5): complete Agent & UI alignment

## Phase 5 Completed: Agent & UI Alignment ✅

### 1. Agent Layer Enhancement
- ✅ Agent consumes only CoreEvent and outputs LLMAgentEvent
- ✅ Strict separation of response/error/end event types
- ✅ Added rate_limit event handling in Agent layer
- ✅ Maintained proper event transformation pipeline

### 2. UI Layer Unification
- ✅ Removed standalone tool_call_permission type
- ✅ Unified to action + action_type pattern
- ✅ Updated all UI components and thread presenter logic
- ✅ Preserved backward compatibility with conditional rendering

### 3. Renderer Mapping & Testing
- ✅ Created comprehensive renderer contract tests (17 tests)
- ✅ Added message block data structure snapshot tests (14 tests)
- ✅ Validated event-to-UI block mapping compliance
- ✅ Ensured consistent status transitions and type safety

### Key Technical Achievements:
- **Type Safety**: All event transformations now type-safe
- **Consistency**: Unified action_type handling across codebase
- **Testing**: 31 new tests covering contracts and snapshots
- **Architecture**: Clean separation between Agent/UI concerns
- **Quality**: All lint, format, and type checks passing ✅

### Files Modified:
- Agent layer: llmProviderPresenter/index.ts
- UI components: MessageItemAssistant.vue
- Thread logic: threadPresenter/index.ts
- Type definitions: shared/chat.d.ts
- Tests: rendererContract.test.ts, messageBlockSnapshot.test.ts

Ready for Phase 6: Quality & Tools 🚀

* feat(phase6): complete Quality & Tools phase

## Phase 6 Completed: Quality & Tools ✅

### 1. Table-Driven Contract Tests
- ✅ Created comprehensive event mapping contract tests (25 test cases)
- ✅ Validated all event types from architecture mapping table
- ✅ Verified status transitions and type constraints
- ✅ Added tool call ID aggregation and lifecycle validation
- ✅ Implemented error recovery pattern testing

### 2. Performance Evaluation & Stress Testing
- ✅ Large text content processing (50KB < 10ms)
- ✅ Large reasoning content handling (100KB < 15ms)
- ✅ Large image data processing (1MB < 20ms)
- ✅ Batch image processing (100 images < 50ms)
- ✅ High-frequency event processing (1000 events < 100ms)
- ✅ Mixed event type handling (500 events < 80ms)
- ✅ Memory leak prevention (5000 events < 500ms)
- ✅ Extreme parameter handling (10KB params < 5ms)
- ✅ Concurrent processing simulation (10 workers < 100ms)

### Key Technical Achievements:
- **Comprehensive Testing**: 67 tests passing across all scenarios
- **Performance Validation**: All benchmarks meet performance targets
- **Type Safety**: Full TypeScript compliance (0 errors)
- **Code Quality**: Lint and format checks passing ✅
- **Architecture Compliance**: All mapping table rules verified
- **Stress Testing**: System handles extreme loads efficiently

### Test Coverage Summary:
- Event mapping contract tests: 25 tests ✅
- Renderer contract tests: 17 tests ✅
- Performance evaluation tests: 9 tests ✅
- Core event factory tests: 12 tests ✅
- Message block snapshot tests: 14 tests ✅
- Shell integration tests: 8 tests ✅

### Files Added:
- test/renderer/message/eventMappingTable.test.ts (comprehensive mapping validation)
- test/renderer/message/performanceEvaluation.test.ts (stress & performance testing)

Ready for production deployment with full quality assurance! 🚀

* fix(providers): complete strong-typed event integration across all providers

* fix(vitest): modify test case

* fix: default settings

* chore: update doc

* fix(ci): remove duplicate check in pr ci

* feat: add pnpm cache for pr check

* fix(ci): pr check with pnpm cache

* fix(ci): change cache key to package.json

* ci: remove pnpm cache

* feat: add glow breathing effect to scroll-to-bottom button (#850)

* feat: add glow breathing effect to scroll-to-bottom button

* fix: ensure exclusive display between MessageList and ArtifactDialog

* fix: refine MessageList–ArtifactDialog interaction logic; correct z-order between dialog and ArtifactDialog

* chore: prettier .vue

* feat: add web search support with configurable options for dashscope (#851)

* feat: add web search support with configurable options for dashscope

* fix: correct qwen model parameters to match official documentation

* feat: add web search support with configurable options for dashscope (#852)

* feat: add web search support with configurable options for dashscope

* fix: correct qwen model parameters to match official documentation

* feat: add search configuration support to ChatConfig components

* fix: fix enableSearch state sync and parameter passing issues

* fix: preserve search settings during data import

* feat: add dashscope commercial models to enable_thinking support (#853)

* feat: add search capability icon for model list (#854)

* feat: add search capability icon for model list

* fix: clear search settings when creating new conversation

* feat(markdown): Thinking panel now supports LaTeX compilation for mathematical formulas & markdown performance optimization (#857)

* feat(markdown): 思考栏支持数学公式latex编译显示 & markdown 性能优化
close: #845

* chore: lint

* chore(ai): update claude code rules and agents

* fix(ui): revert Dialog z-index to z-50 to fix dropdown visibility

Reverts DialogContent z-index from z-[100] back to z-50 to resolve issue where Select and EmojiPicker dropdowns were not appearing. This maintains proper layering hierarchy without breaking other UI components.

* feat: upgrade vue-renderer-markdown & vue-use-monaco (#862)

1. ignore math-block warning
2. Compatible with the syntax issues of mermaid produced by AI, greatly reducing the probability of mermaid rendering errors

* feat(dashscope): add qwen3-max-preview model (#865)

* fix: mcp params support more types (#861)

* feat(mcp): enhance tool parameter display with enum type support

- Add enum parameter type detection and enhanced display
- Show enum parameters with distinct blue badge styling (enum(string), array[enum(string)])
- Display allowed values for both direct enum and array item enum parameters
- Add i18n support for "allowedValues" and "arrayItemValues" labels
- Maintain consistent UI design with existing parameter display patterns
- Improve developer experience when debugging MCP tools with constrained parameters

* fix: enum params support

* fix(context-menu): handle local file paths in image save functionality

- Fix URL parsing error when saving images from local file paths
- Add proper handling for http/https URLs, file:// URLs, and direct file paths
- Use fs.promises for reading local files instead of net.fetch for invalid URLs
- Prevent "Failed to parse URL from" error when saving local images

* fix(context-menu): improve URL handling robustness in image save

- Add try-catch around net.fetch to handle invalid URLs gracefully
- Implement fallback methods for file:// URLs and local file paths
- Add debug logging to track source URL values for troubleshooting
- Prevent "Failed to parse URL from" errors with comprehensive URL validation

* fix(context-menu): handle empty srcURL in image save functionality

- Add comprehensive URL detection when srcURL is empty
- Implement fallback URL sources (linkURL, pageURL) for better compatibility
- Add debug logging to track all available context menu parameters
- Prevent "Failed to parse URL from" errors caused by empty URLs
- Provide clear error message when no valid URL can be found

* chore: format code

* fix: ai review

* fix: prevent @ symbol remaining when deleting mentions (#867)

* Merge commit from fork

* feat: implement separated system and custom prompt management (#868)

* feat: implement separated system and custom prompt management

* style: code fmt

* fix: add migration for legacy default_system_prompt to system_prompts

* feat: add Moonshot model configurations (#869)

* refactor: translate all cn comments and log to en (#871)

* refactor: translate all cn comments and log to en

* fix: revert translate in params

* feat: add reasoning support for Grok thinking models (#873)

* feat: add reasoning support for Grok thinking models

* fix: code lint

* fix: escaping character issue

---------

Co-authored-by: zerob13 <zerob13@gmail.com>

---------

Co-authored-by: hllshiro <40970081+hllshiro@users.noreply.github.com>
Co-authored-by: yyhhyyyyyy <yyhhyyyyyy8@gmail.com>
Co-authored-by: xiaomo <wegi866@gmail.com>
Co-authored-by: Simon He <57086651+Simon-He95@users.noreply.github.com>
Co-authored-by: luy <12696648@qq.com>
@zerob13 zerob13 deleted the feat/dialog-mutual-exclusive-support branch January 6, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants