-
Notifications
You must be signed in to change notification settings - Fork 614
feat: add glow breathing effect to scroll-to-bottom button #850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughIntroduces a new glow-breathe animation for the scroll-to-bottom indicator, replaces direct state toggling with an emitted messageNavigationToggle event from TitleView handled in ChatTabView with artifact panel guard logic, and updates DialogContent to higher z-index and accepts a class prop for external styling. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant TitleView
participant ChatTabView
participant chatStore
participant artifactStore
User->>TitleView: Click "Message Navigation" button
TitleView-->>ChatTabView: emit messageNavigationToggle
alt artifact panel open
ChatTabView->>artifactStore: set isOpen = false
ChatTabView->>chatStore: set isMessageNavigationOpen = true
else artifact panel closed
ChatTabView->>chatStore: toggle isMessageNavigationOpen
end
Note over ChatTabView,chatStore: Large screens show navigation only when<br/>chatStore.isMessageNavigationOpen && !artifactStore.isOpen
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
src/renderer/src/components/message/MessageList.vue (2)
461-475: Match animation name, add delay for depth, and translate comment.Staggering the after-layer subtly improves the glow; ensure English comment.
- animation: glow-breathe 2s ease-in-out infinite; + animation: message-list-glow-breathe 2s ease-in-out infinite; + will-change: transform, opacity; + animation-delay: 0.2s; @@ - /* opacity: 0.6; 已被 animation 覆盖 */ + /* Opacity is controlled by the animation */
477-485: Remove unused rotate-glow keyframes (or translate comment).Dead CSS adds noise; safe to delete since no references remain. If you keep it, use an English note.
-/* 原始 rotate-glow 动画,不需要可删除 */ -@keyframes rotate-glow { - from { - transform: rotate(0deg); - } - to { - transform: rotate(360deg); - } -} +/* (removed) Legacy rotate-glow keyframes were unused */
🧹 Nitpick comments (1)
src/renderer/src/components/message/MessageList.vue (1)
446-459: Update animation name and hint compositor.Switch to the prefixed keyframe and add will-change for smoother rendering.
- animation: glow-breathe 2s ease-in-out infinite; + animation: message-list-glow-breathe 2s ease-in-out infinite; + will-change: transform, opacity;
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
src/renderer/src/components/message/MessageList.vue(3 hunks)
🧰 Additional context used
📓 Path-based instructions (10)
src/renderer/src/**/*
📄 CodeRabbit inference engine (.cursor/rules/i18n.mdc)
src/renderer/src/**/*: All user-facing strings must use i18n keys (avoid hardcoded user-visible text in code)
Use the 'vue-i18n' framework for all internationalization in the renderer
Ensure all user-visible text in the renderer uses the translation system
Files:
src/renderer/src/components/message/MessageList.vue
src/renderer/**/*.{vue,ts,js,tsx,jsx}
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
渲染进程代码放在
src/renderer
Files:
src/renderer/src/components/message/MessageList.vue
src/renderer/src/**/*.{vue,ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/vue-best-practices.mdc)
src/renderer/src/**/*.{vue,ts,tsx,js,jsx}: Use the Composition API for better code organization and reusability
Implement proper state management with Pinia
Utilize Vue Router for navigation and route management
Leverage Vue's built-in reactivity system for efficient data handling
Files:
src/renderer/src/components/message/MessageList.vue
src/renderer/src/**/*.vue
📄 CodeRabbit inference engine (.cursor/rules/vue-best-practices.mdc)
Use scoped styles to prevent CSS conflicts between components
Files:
src/renderer/src/components/message/MessageList.vue
src/renderer/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)
src/renderer/**/*.{ts,tsx,vue}: Use descriptive variable names with auxiliary verbs (e.g., isLoading, hasError).
Use TypeScript for all code; prefer types over interfaces.
Avoid enums; use const objects instead.
Use arrow functions for methods and computed properties.
Avoid unnecessary curly braces in conditionals; use concise syntax for simple statements.
Files:
src/renderer/src/components/message/MessageList.vue
src/renderer/**/*.{vue,ts}
📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)
Implement lazy loading for routes and components.
Files:
src/renderer/src/components/message/MessageList.vue
src/renderer/**/*.{ts,vue}
📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)
src/renderer/**/*.{ts,vue}: Use useFetch and useAsyncData for data fetching.
Implement SEO best practices using Nuxt's useHead and useSeoMeta.Use Pinia for frontend state management
Files:
src/renderer/src/components/message/MessageList.vue
src/renderer/**/*.vue
📄 CodeRabbit inference engine (CLAUDE.md)
src/renderer/**/*.vue: Use Vue 3 Composition API for all Vue components
Use Tailwind CSS with scoped styles for component styling
When creating new UI components, use Composition API with proper TypeScript typing, ensure responsive design (Tailwind), and include error/loading states
Files:
src/renderer/src/components/message/MessageList.vue
**/*.{ts,tsx,js,jsx,vue}
📄 CodeRabbit inference engine (CLAUDE.md)
Write logs and comments in English
Files:
src/renderer/src/components/message/MessageList.vue
src/renderer/src/**
📄 CodeRabbit inference engine (CLAUDE.md)
Place full application UI functionality (tab content) under src/renderer/src/ organized by feature
Files:
src/renderer/src/components/message/MessageList.vue
🧠 Learnings (1)
📓 Common learnings
Learnt from: neoragex2002
PR: ThinkInAIXYZ/deepchat#550
File: src/main/presenter/mcpPresenter/inMemoryServers/meetingServer.ts:258-324
Timestamp: 2025-06-21T15:53:34.641Z
Learning: User neoragex2002 prefers concise, brief responses rather than chatty or verbose communication. Avoid lengthy explanations, excessive enthusiasm, or ASCII art in responses.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build-check (x64)
| /* 定义发光呼吸动画 */ | ||
| @keyframes glow-breathe { | ||
| 0% { | ||
| opacity: 0.6; | ||
| transform: scale(1); | ||
| } | ||
| 50% { | ||
| opacity: 1; | ||
| transform: scale(1.05); | ||
| } | ||
| 100% { | ||
| opacity: 0.6; | ||
| transform: scale(1); | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Prefix keyframe name (global in scoped SFC) and use English comment.
Keyframes are global even in scoped styles; prefix to avoid collisions. Also align comments with repo guideline (English).
-/* 定义发光呼吸动画 */
-@keyframes glow-breathe {
+/* Glow breathing animation */
+@keyframes message-list-glow-breathe {Optional A11Y (reduced motion):
@media (prefers-reduced-motion: reduce) {
.scroll-to-bottom-loading-container::before,
.scroll-to-bottom-loading-container::after {
animation: none;
opacity: 0.6;
}
}🤖 Prompt for AI Agents
In src/renderer/src/components/message/MessageList.vue around lines 430-445 the
CSS @keyframes name and comment are problematic: keyframes are global in scoped
SFCs and the comment should be English. Rename the keyframe to a repo-prefixed
unique name (e.g., msglist-glow-breathe) and update the comment to English
(e.g., "Define glowing breathing animation"); update any references to the old
name accordingly. Also add a prefers-reduced-motion media rule to disable the
animation for users who request reduced motion (as suggested) and ensure
selectors match the animation targets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/renderer/src/views/ChatTabView.vue (1)
117-124: Localizable title: replace hardcoded "New Chat" with i18n.Per renderer i18n guideline, user-visible text must use translation keys.
Apply:
@@ -import { defineAsyncComponent } from 'vue' +import { defineAsyncComponent } from 'vue' +import { useI18n } from 'vue-i18n' @@ const langStore = useLanguageStore() const chatViewRef = ref() +const { t } = useI18n() @@ if (activeThread) { title.value = activeThread.title } else { - title.value = 'New Chat' + title.value = t('chat.newChatTitle') }Add
chat.newChatTitleto your locale files (e.g., en):{ "chat": { "newChatTitle": "New Chat" } }
🧹 Nitpick comments (4)
src/renderer/src/views/ChatTabView.vue (4)
126-144: Simplify watchers; avoid deep watch on whole threads array.Watching
threadsdeeply is heavier than needed. Watch the active title directly.@@ -// 监听活动会话变化 -watch( - () => chatStore.activeThread, - () => { - updateTitle() - }, - { immediate: true } -) - -// 监听会话标题变化 -watch( - () => chatStore.threads, - () => { - if (chatStore.activeThread) { - updateTitle() - } - }, - { deep: true } -) +// Update document title when active thread or its title changes +watch( + () => chatStore.activeThread?.title, + () => updateTitle(), + { immediate: true } +)
151-160: Optional: auto-close navigation when ArtifactDialog opens on large screens.Prevents store/UI divergence if the dialog opens while navigation is open.
@@ onClickOutside(sidebarRef, (event) => { @@ }) +// Keep state consistent with large-screen dialog visibility +watch([isLargeScreen, () => artifactStore.isOpen], ([lg, isOpen]) => { + if (lg && isOpen && chatStore.isMessageNavigationOpen) { + chatStore.isMessageNavigationOpen = false + } +})
11-12: Use English for comments.Repo guideline requires comments/logs in English. Please translate the Chinese inline comments.
Also applies to: 35-41, 43-45, 50-50, 63-76, 88-90
230-256: Scope component styles; move global scrollbar CSS to a shared stylesheet.Guideline: component styles should be scoped to avoid cross-component bleed. The scrollbar rules are global and should live in a central CSS.
-<style> +<style scoped> .bg-grid-pattern { background-image: linear-gradient(to right, #000 1px, transparent 1px), linear-gradient(to bottom, #000 1px, transparent 1px); background-size: 20px 20px; } - -/* 添加全局样式 */ -::-webkit-scrollbar { - width: 8px; - height: 8px; -} - -::-webkit-scrollbar-track { - background: transparent; -} - -::-webkit-scrollbar-thumb { - background: #d1d5db80; - border-radius: 4px; -} - -::-webkit-scrollbar-thumb:hover { - background: #9ca3af80; -} </style>Create a global stylesheet (e.g.,
src/renderer/src/styles/scrollbar.css) and import it once (e.g., inmain.tsorApp.vue):/* scrollbar.css */ ::-webkit-scrollbar { width: 8px; height: 8px; } ::-webkit-scrollbar-track { background: transparent; } ::-webkit-scrollbar-thumb { background: #d1d5db80; border-radius: 4px; } ::-webkit-scrollbar-thumb:hover { background: #9ca3af80; }// main.ts import '@/styles/scrollbar.css'
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
src/renderer/src/views/ChatTabView.vue(1 hunks)
🧰 Additional context used
📓 Path-based instructions (10)
src/renderer/src/**/*
📄 CodeRabbit inference engine (.cursor/rules/i18n.mdc)
src/renderer/src/**/*: All user-facing strings must use i18n keys (avoid hardcoded user-visible text in code)
Use the 'vue-i18n' framework for all internationalization in the renderer
Ensure all user-visible text in the renderer uses the translation system
Files:
src/renderer/src/views/ChatTabView.vue
src/renderer/**/*.{vue,ts,js,tsx,jsx}
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
渲染进程代码放在
src/renderer
Files:
src/renderer/src/views/ChatTabView.vue
src/renderer/src/**/*.{vue,ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/vue-best-practices.mdc)
src/renderer/src/**/*.{vue,ts,tsx,js,jsx}: Use the Composition API for better code organization and reusability
Implement proper state management with Pinia
Utilize Vue Router for navigation and route management
Leverage Vue's built-in reactivity system for efficient data handling
Files:
src/renderer/src/views/ChatTabView.vue
src/renderer/src/**/*.vue
📄 CodeRabbit inference engine (.cursor/rules/vue-best-practices.mdc)
Use scoped styles to prevent CSS conflicts between components
Files:
src/renderer/src/views/ChatTabView.vue
src/renderer/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)
src/renderer/**/*.{ts,tsx,vue}: Use descriptive variable names with auxiliary verbs (e.g., isLoading, hasError).
Use TypeScript for all code; prefer types over interfaces.
Avoid enums; use const objects instead.
Use arrow functions for methods and computed properties.
Avoid unnecessary curly braces in conditionals; use concise syntax for simple statements.
Files:
src/renderer/src/views/ChatTabView.vue
src/renderer/**/*.{vue,ts}
📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)
Implement lazy loading for routes and components.
Files:
src/renderer/src/views/ChatTabView.vue
src/renderer/**/*.{ts,vue}
📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)
src/renderer/**/*.{ts,vue}: Use useFetch and useAsyncData for data fetching.
Implement SEO best practices using Nuxt's useHead and useSeoMeta.Use Pinia for frontend state management
Files:
src/renderer/src/views/ChatTabView.vue
src/renderer/**/*.vue
📄 CodeRabbit inference engine (CLAUDE.md)
src/renderer/**/*.vue: Use Vue 3 Composition API for all Vue components
Use Tailwind CSS with scoped styles for component styling
When creating new UI components, use Composition API with proper TypeScript typing, ensure responsive design (Tailwind), and include error/loading states
Files:
src/renderer/src/views/ChatTabView.vue
**/*.{ts,tsx,js,jsx,vue}
📄 CodeRabbit inference engine (CLAUDE.md)
Write logs and comments in English
Files:
src/renderer/src/views/ChatTabView.vue
src/renderer/src/**
📄 CodeRabbit inference engine (CLAUDE.md)
Place full application UI functionality (tab content) under src/renderer/src/ organized by feature
Files:
src/renderer/src/views/ChatTabView.vue
🧠 Learnings (1)
📓 Common learnings
Learnt from: neoragex2002
PR: ThinkInAIXYZ/deepchat#550
File: src/main/presenter/mcpPresenter/inMemoryServers/meetingServer.ts:258-324
Timestamp: 2025-06-21T15:53:34.641Z
Learning: User neoragex2002 prefers concise, brief responses rather than chatty or verbose communication. Avoid lengthy explanations, excessive enthusiasm, or ASCII art in responses.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build-check (x64)
🔇 Additional comments (1)
src/renderer/src/views/ChatTabView.vue (1)
52-52: Good guard to prevent overlap with ArtifactDialog on large screens.The added
!artifactStore.isOpen && isLargeScreenis correct and consistent with the margin rule above.Please confirm UX across breakpoints: if the user opens the ArtifactDialog while the navigation is open, do we want the store flag to remain
true(hidden by the guard) or be auto-closed to avoid state drift?
…rder between dialog and ArtifactDialog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (6)
src/renderer/src/components/TitleView.vue (4)
45-53: Event-driven toggle: good moveSwitching to an emitted event instead of mutating store state here is cleaner and keeps concerns in the parent. Consider adding accessible labels (with i18n) to the button.
Example:
- <Button + <Button class="w-7 h-7 rounded-md relative !p-0" size="icon" variant="outline" :class="{ 'bg-accent': chatStore.isMessageNavigationOpen }" - @click="onMessageNavigationButtonClick" + :aria-label="t('chat.messageNavigation.toggle')" + :title="t('chat.messageNavigation.toggle')" + @click="onMessageNavigationButtonClick" >
112-113: Type the emit for better TS safetyPrefer a typed
defineEmitsto catch event name typos and payload shapes at compile time.-const emit = defineEmits(['messageNavigationToggle']); +const emit = defineEmits<{ + (e: 'messageNavigationToggle'): void +}>()
288-292: Inline the emit to drop a trivial handler (optional)This handler only forwards the event; you can inline it in the template to reduce surface area.
-// 新增的事件处理函数 -const onMessageNavigationButtonClick = () => { - emit('messageNavigationToggle'); -}; +// Handler removed — inline emit in template insteadAnd in the template:
-@click="onMessageNavigationButtonClick" +@click="emit('messageNavigationToggle')"
1-496: Fix Prettier warningsCI flagged formatting issues. Please run Prettier to keep CI green.
prettier --write src/renderer/src/components/TitleView.vuesrc/renderer/src/components/ui/dialog/DialogContent.vue (2)
30-31: z-index layering: ensure content is above overlay regardless of DOM orderSetting both overlay and content to the same z-index relies on document order. To be robust, bump content above overlay.
- <DialogOverlay - class="fixed inset-0 z-[100] bg-black/80 data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0" + <DialogOverlay + class="fixed inset-0 z-[100] bg-black/80 data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0" /> ... - 'fixed left-1/2 top-1/2 z-[100] grid w-full max-w-lg -translate-x-1/2 -translate-y-1/2 gap-4 border bg-background p-6 shadow-lg duration-200 data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[state=closed]:slide-out-to-left-1/2 data-[state=closed]:slide-out-to-top-[48%] data-[state=open]:slide-in-from-left-1/2 data-[state=open]:slide-in-from-top-[48%] sm:rounded-lg', + 'fixed left-1/2 top-1/2 z-[101] grid w-full max-w-lg -translate-x-1/2 -translate-y-1/2 gap-4 border bg-background p-6 shadow-lg duration-200 data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[state=closed]:slide-out-to-left-1/2 data-[state=closed]:slide-out-to-top-[48%] data-[state=open]:slide-in-from-left-1/2 data-[state=open]:slide-in-from-top-[48%] sm:rounded-lg',Also applies to: 36-37
1-25: Localize the “Close” label for a11yRenderer strings should use i18n. Replace the hardcoded “Close” (screen-reader text) with
t(...).<script setup lang="ts"> import { cn } from '@/lib/utils' import { Cross2Icon } from '@radix-icons/vue' +import { useI18n } from 'vue-i18n' ... -const props = defineProps<DialogContentProps & { class?: HTMLAttributes['class'] }>() +const props = defineProps<DialogContentProps & { class?: HTMLAttributes['class'] }>() const emits = defineEmits<DialogContentEmits>() +const { t } = useI18n() </script>- <span class="sr-only">Close</span> + <span class="sr-only">{{ t('common.close') }}</span>Also applies to: 43-48
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
src/renderer/src/components/TitleView.vue(3 hunks)src/renderer/src/components/ui/dialog/DialogContent.vue(1 hunks)src/renderer/src/views/ChatTabView.vue(3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- src/renderer/src/views/ChatTabView.vue
🧰 Additional context used
📓 Path-based instructions (10)
src/renderer/src/**/*
📄 CodeRabbit inference engine (.cursor/rules/i18n.mdc)
src/renderer/src/**/*: All user-facing strings must use i18n keys (avoid hardcoded user-visible text in code)
Use the 'vue-i18n' framework for all internationalization in the renderer
Ensure all user-visible text in the renderer uses the translation system
Files:
src/renderer/src/components/TitleView.vuesrc/renderer/src/components/ui/dialog/DialogContent.vue
src/renderer/**/*.{vue,ts,js,tsx,jsx}
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
渲染进程代码放在
src/renderer
Files:
src/renderer/src/components/TitleView.vuesrc/renderer/src/components/ui/dialog/DialogContent.vue
src/renderer/src/**/*.{vue,ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/vue-best-practices.mdc)
src/renderer/src/**/*.{vue,ts,tsx,js,jsx}: Use the Composition API for better code organization and reusability
Implement proper state management with Pinia
Utilize Vue Router for navigation and route management
Leverage Vue's built-in reactivity system for efficient data handling
Files:
src/renderer/src/components/TitleView.vuesrc/renderer/src/components/ui/dialog/DialogContent.vue
src/renderer/src/**/*.vue
📄 CodeRabbit inference engine (.cursor/rules/vue-best-practices.mdc)
Use scoped styles to prevent CSS conflicts between components
Files:
src/renderer/src/components/TitleView.vuesrc/renderer/src/components/ui/dialog/DialogContent.vue
src/renderer/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)
src/renderer/**/*.{ts,tsx,vue}: Use descriptive variable names with auxiliary verbs (e.g., isLoading, hasError).
Use TypeScript for all code; prefer types over interfaces.
Avoid enums; use const objects instead.
Use arrow functions for methods and computed properties.
Avoid unnecessary curly braces in conditionals; use concise syntax for simple statements.
Files:
src/renderer/src/components/TitleView.vuesrc/renderer/src/components/ui/dialog/DialogContent.vue
src/renderer/**/*.{vue,ts}
📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)
Implement lazy loading for routes and components.
Files:
src/renderer/src/components/TitleView.vuesrc/renderer/src/components/ui/dialog/DialogContent.vue
src/renderer/**/*.{ts,vue}
📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)
src/renderer/**/*.{ts,vue}: Use useFetch and useAsyncData for data fetching.
Implement SEO best practices using Nuxt's useHead and useSeoMeta.Use Pinia for frontend state management
Files:
src/renderer/src/components/TitleView.vuesrc/renderer/src/components/ui/dialog/DialogContent.vue
src/renderer/**/*.vue
📄 CodeRabbit inference engine (CLAUDE.md)
src/renderer/**/*.vue: Use Vue 3 Composition API for all Vue components
Use Tailwind CSS with scoped styles for component styling
When creating new UI components, use Composition API with proper TypeScript typing, ensure responsive design (Tailwind), and include error/loading states
Files:
src/renderer/src/components/TitleView.vuesrc/renderer/src/components/ui/dialog/DialogContent.vue
**/*.{ts,tsx,js,jsx,vue}
📄 CodeRabbit inference engine (CLAUDE.md)
Write logs and comments in English
Files:
src/renderer/src/components/TitleView.vuesrc/renderer/src/components/ui/dialog/DialogContent.vue
src/renderer/src/**
📄 CodeRabbit inference engine (CLAUDE.md)
Place full application UI functionality (tab content) under src/renderer/src/ organized by feature
Files:
src/renderer/src/components/TitleView.vuesrc/renderer/src/components/ui/dialog/DialogContent.vue
🧠 Learnings (3)
📓 Common learnings
Learnt from: neoragex2002
PR: ThinkInAIXYZ/deepchat#550
File: src/main/presenter/mcpPresenter/inMemoryServers/meetingServer.ts:258-324
Timestamp: 2025-06-21T15:53:34.641Z
Learning: User neoragex2002 prefers concise, brief responses rather than chatty or verbose communication. Avoid lengthy explanations, excessive enthusiasm, or ASCII art in responses.
📚 Learning: 2025-07-21T01:46:52.880Z
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.880Z
Learning: Applies to src/main/presenter/llmProviderPresenter/streamEvents.ts : Standardized stream events should conform to the `LLMCoreStreamEvent` interface, ideally defined in a shared file such as `src/main/presenter/llmProviderPresenter/streamEvents.ts`.
Applied to files:
src/renderer/src/components/TitleView.vue
📚 Learning: 2025-07-21T01:46:52.880Z
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.880Z
Learning: Applies to src/main/presenter/llmProviderPresenter/index.ts : The main Agent loop should send standardized `STREAM_EVENTS` (`RESPONSE`, `END`, `ERROR`) to the frontend via `eventBus`.
Applied to files:
src/renderer/src/components/TitleView.vue
🪛 GitHub Actions: PR Check
src/renderer/src/components/TitleView.vue
[warning] 1-1: Prettier formatting issues found in file TitleView.vue. Run 'prettier --write' to fix.
🔇 Additional comments (1)
src/renderer/src/components/ui/dialog/DialogContent.vue (1)
35-39: External class passthrough looks goodMerging
props.classviacnis correct and keeps the API flexible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
src/renderer/src/views/ChatTabView.vue (2)
120-127: Internationalize user-facing title (“New Chat”)Renderer strings must use vue-i18n. Replace the hardcoded title with a translation.
-import { computed, watch, ref } from 'vue' +import { computed, watch, ref } from 'vue' +import { useI18n } from 'vue-i18n' ... -const chatViewRef = ref() +const chatViewRef = ref() +const { t } = useI18n() ... - if (activeThread) { - title.value = activeThread.title - } else { - title.value = 'New Chat' - } + if (activeThread) { + title.value = activeThread.title + } else { + title.value = t('chat.new') // define key in locales + }
242-268: Scope styles per guidelines; move global scrollbar CSSComponent styles should be scoped. Move global scrollbar rules to a global stylesheet (e.g., src/renderer/src/styles/scrollbar.css) and import once in your app layout.
Option A (preferred):
- Remove this style block.
- Add the rules to a global CSS file and import it in the app entry/layout.
Option B:
- If you must keep here, mark as scoped and wrap globals explicitly:
-<style> +<style scoped> .bg-grid-pattern { ... } -/* 添加全局样式 */ -::-webkit-scrollbar { ... } -::-webkit-scrollbar-track { ... } -::-webkit-scrollbar-thumb { ... } -::-webkit-scrollbar-thumb:hover { ... } +:global(html)::-webkit-scrollbar { ... } +:global(html)::-webkit-scrollbar-track { ... } +:global(html)::-webkit-scrollbar-thumb { ... } +:global(html)::-webkit-scrollbar-thumb:hover { ... } </style>
🧹 Nitpick comments (3)
src/renderer/src/views/ChatTabView.vue (3)
55-55: Deduplicate the visibility predicate with a computedThe same condition appears in multiple places (margin class at Line 7 and here). Centralize it to avoid drift.
Example:
const isMessageNavVisible = computed( () => chatStore.isMessageNavigationOpen && !artifactStore.isOpen && isLargeScreen.value )Then:
- v-show="chatStore.isMessageNavigationOpen && !artifactStore.isOpen && isLargeScreen" + v-show="isMessageNavVisible"And reuse isMessageNavVisible in the class at Line 7.
216-224: Prefer store actions over direct state mutationMove this UI state orchestration into Pinia actions (e.g., artifactStore.close(), chatStore.toggleMessageNavigation()) for traceability and to keep side effects in one place.
- if (artifactStore.isOpen) { - artifactStore.isOpen = false - chatStore.isMessageNavigationOpen = true - } else { - chatStore.isMessageNavigationOpen = !chatStore.isMessageNavigationOpen - } + if (artifactStore.isOpen) { + artifactStore.close() + chatStore.openMessageNavigation() + } else { + chatStore.toggleMessageNavigation() + }
11-21: Use English for comments per repo guidelinesSeveral inline comments are in Chinese. Please convert to concise English for consistency.
Also applies to: 35-41, 66-76, 91-93, 119-121
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
src/renderer/src/components/TitleView.vue(3 hunks)src/renderer/src/views/ChatTabView.vue(3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- src/renderer/src/components/TitleView.vue
🧰 Additional context used
📓 Path-based instructions (10)
src/renderer/src/**/*
📄 CodeRabbit inference engine (.cursor/rules/i18n.mdc)
src/renderer/src/**/*: All user-facing strings must use i18n keys (avoid hardcoded user-visible text in code)
Use the 'vue-i18n' framework for all internationalization in the renderer
Ensure all user-visible text in the renderer uses the translation system
Files:
src/renderer/src/views/ChatTabView.vue
src/renderer/**/*.{vue,ts,js,tsx,jsx}
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
渲染进程代码放在
src/renderer
Files:
src/renderer/src/views/ChatTabView.vue
src/renderer/src/**/*.{vue,ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/vue-best-practices.mdc)
src/renderer/src/**/*.{vue,ts,tsx,js,jsx}: Use the Composition API for better code organization and reusability
Implement proper state management with Pinia
Utilize Vue Router for navigation and route management
Leverage Vue's built-in reactivity system for efficient data handling
Files:
src/renderer/src/views/ChatTabView.vue
src/renderer/src/**/*.vue
📄 CodeRabbit inference engine (.cursor/rules/vue-best-practices.mdc)
Use scoped styles to prevent CSS conflicts between components
Files:
src/renderer/src/views/ChatTabView.vue
src/renderer/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)
src/renderer/**/*.{ts,tsx,vue}: Use descriptive variable names with auxiliary verbs (e.g., isLoading, hasError).
Use TypeScript for all code; prefer types over interfaces.
Avoid enums; use const objects instead.
Use arrow functions for methods and computed properties.
Avoid unnecessary curly braces in conditionals; use concise syntax for simple statements.
Files:
src/renderer/src/views/ChatTabView.vue
src/renderer/**/*.{vue,ts}
📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)
Implement lazy loading for routes and components.
Files:
src/renderer/src/views/ChatTabView.vue
src/renderer/**/*.{ts,vue}
📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)
src/renderer/**/*.{ts,vue}: Use useFetch and useAsyncData for data fetching.
Implement SEO best practices using Nuxt's useHead and useSeoMeta.Use Pinia for frontend state management
Files:
src/renderer/src/views/ChatTabView.vue
src/renderer/**/*.vue
📄 CodeRabbit inference engine (CLAUDE.md)
src/renderer/**/*.vue: Use Vue 3 Composition API for all Vue components
Use Tailwind CSS with scoped styles for component styling
When creating new UI components, use Composition API with proper TypeScript typing, ensure responsive design (Tailwind), and include error/loading states
Files:
src/renderer/src/views/ChatTabView.vue
**/*.{ts,tsx,js,jsx,vue}
📄 CodeRabbit inference engine (CLAUDE.md)
Write logs and comments in English
Files:
src/renderer/src/views/ChatTabView.vue
src/renderer/src/**
📄 CodeRabbit inference engine (CLAUDE.md)
Place full application UI functionality (tab content) under src/renderer/src/ organized by feature
Files:
src/renderer/src/views/ChatTabView.vue
🧠 Learnings (1)
📓 Common learnings
Learnt from: neoragex2002
PR: ThinkInAIXYZ/deepchat#550
File: src/main/presenter/mcpPresenter/inMemoryServers/meetingServer.ts:258-324
Timestamp: 2025-06-21T15:53:34.641Z
Learning: User neoragex2002 prefers concise, brief responses rather than chatty or verbose communication. Avoid lengthy explanations, excessive enthusiasm, or ASCII art in responses.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build-check (x64)
| <TitleView | ||
| :model="activeModel" | ||
| @messageNavigationToggle="handleMessageNavigationToggle" | ||
| /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix event name casing: use kebab-case for Vue emitted events
TitleView likely emits "messageNavigationToggle" (camelCase). In templates, you must listen with kebab-case. The current listener won't fire.
- @messageNavigationToggle="handleMessageNavigationToggle"
+ @message-navigation-toggle="handleMessageNavigationToggle"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <TitleView | |
| :model="activeModel" | |
| @messageNavigationToggle="handleMessageNavigationToggle" | |
| /> | |
| <TitleView | |
| :model="activeModel" | |
| @message-navigation-toggle="handleMessageNavigationToggle" | |
| /> |
🤖 Prompt for AI Agents
In src/renderer/src/views/ChatTabView.vue around lines 41 to 44, the template
listener uses the camelCase event name "messageNavigationToggle" which won't
match Vue's template listeners; change the listener to kebab-case by replacing
@messageNavigationToggle with @message-navigation-toggle so it correctly
receives the event emitted by TitleView (ensure the emitted event name in
TitleView remains messageNavigationToggle or adjust emission to match).
* fix: chat confg need sync to new value when change model in chat (#823) * fix: gemini nano banana not read image from chatinput * fix: remove file-type ,this will mark html as audio (#824) * fix: Solve the problem of the window becoming larger when dragging floating button under Windows (#826) * fix: improve OpenAI compatible provider compatibility with third-party services * chore: update vue-renderer-markdown to v0.0.35 (#827) * refactor: remove custom-prompts-server and decouple prompts from MCP lifecycle (#829) - Remove custom-prompts-server service entirely including configuration - Implement data source merging in MCP store to load prompts from both config and MCP - Add upgrade migration logic for versions < 0.3.5 to clean up old configurations - Ensure @ operations work independently of MCP state through config data source - Update CLAUDE.md with prompt management guidelines The @ prompt functionality now works completely independently of MCP, loading custom prompts directly from config storage while maintaining full compatibility with existing MCP prompt sources. * chore: add better log for mcp tool name * feat: ux update (#831) * feat: ux update * chore: format * feat: setting provider ux update (#832) * feat: add current datetime to system prompt - Add current date and time information to user's system prompt when not empty - Include complete datetime with timezone, year, month, day, hour, minute, second - Apply to both preparePromptContent and buildContinueToolCallContext methods - Update token calculation to use processed system prompt for accuracy - Skip datetime addition for image generation models and empty prompts * refactor: extract system prompt datetime enhancement to common method - Add enhanceSystemPromptWithDateTime private method to reduce code duplication - Update both preparePromptContent and buildContinueToolCallContext to use common method - Improve code maintainability and ensure consistency across all system prompt processing - Add comprehensive JSDoc documentation for the new method * fix(markdown): auto-wrap hide scroll (#833) * feat: add enable_thinking parameter support for siliconcloud (#835) * chore: bump deps (#834) * chore: bump up deps * fix: change win arm to wasm32 sharp * chore: revert sharp config * feat: drop windows arm support * fix(coderabbitai): remove action for windows arm64 * refactor: adjust scroll-to-bottom button glow effect (#837) * feat: add mutual exclusive confirmation dialogs for DeepSeek-V3.1 (#838) * feat: add sanitizeText utility for clipboard data handling (#843) * feat: support canary upgrade (#840) * feat: support canary upgrade * feat: add update channel selection for stable/canary versions - Add update channel configuration to config presenter - Implement dynamic URL switching for version checks and downloads - Add UI selector in AboutUsSettings for channel selection - Support stable and canary update channels with different endpoints - Add internationalization support for channel selection * chore: change contributors charts to openomy * refactor: improve update channel handling and network resilience - Sanitize update channel input to prevent invalid values - Add 10-second timeout to version check requests to prevent hanging - Treat unknown channels as 'upgrade' (stable) for robustness - Improve error handling for network timeouts and invalid channels * feat: implement thinking parameter support for doubao models (#842) * feat: implement dedicated DashScope provider with enable_thinking support (#844) * feat: implement dedicated DashScope provider with enable_thinking support * refactor: remove unnecessary API key status check methods from DashscopeProvider * fix: prioritize provider.id over apiType in createProviderInstance (#846) * feat: add qwen3 thinking budget support (#848) * feat: add qwen3 thinking budget support * fix: add missing gemini.onlySupported key in zh-CN locale * refactor: merge duplicate silicon case statements in provider creation * feat: add qwen3 thinking budget support in ChatConfig (#849) * refactor(types): 🚀split monolithic presenter.d.ts into strict per-domain *.presenter.d.ts + typed core layer (#847) * docs: Add strong-typed message architecture and implementation guidelines - Update message-architecture.md with strong-typed design, remove compatibility compromises - Add event-to-UI mapping table and rendering checklist for contract compliance - Create presenter-split-plan.md for type system refactoring - Add implementation-tasks.md with phased rollout plan - Create .cursor/rules/provider-guidelines.mdc for provider implementation guidance This establishes a foundation for strong-typed, maintainable message architecture without legacy compatibility debt. * types(core): add strong-typed core types and barrel exports\n\n- Add usage.ts (UsageStats, RateLimitInfo)\n- Add llm-events.ts (discriminated union + factories + guards)\n- Add agent-events.ts (LLMAgentEvent*, shared types)\n- Add chat.ts (Message/AssistantMessageBlock/UserMessageContent)\n- Add mcp.ts (MCP content/response/definition)\n- Add types/index.d.ts barrel exports\n\nNo compatibility shims included by design. * refactor(types): move legacy presenters and add @shared/presenter stub; keep legacy exports in types/index to maintain build\n\n- Move legacy presenters to src/shared/types/presenters/legacy.presenters.d.ts\n- Add src/shared/presenter.d.ts re-export stub\n- Temporarily export only legacy presenters from types/index.d.ts to avoid type mismatches\n- Update implementation-tasks.md (Stage 2 done)\n\nNext: progressive import updates to new cores, then flip barrel to new types and delete legacy. * refactor(types): alias legacy core message types to strong-typed core (B-plan)\n\n- legacy.presenters.d.ts now re-exports ChatMessage/ChatMessageContent/LLMAgentEvent/LLMAgentEventData/LLMCoreStreamEvent from core\n- Prepares for flipping interfaces without changing import sites * docs(tasks): mark Phase 3 as completed\n\n- Successfully implemented B-plan approach with type aliasing\n- Unified core message types (ChatMessage, LLMAgentEvent, LLMCoreStreamEvent)\n- Created core model types and maintained build compatibility\n- All type checks passing with no breaking changes * fix(types): revert to legacy-only exports and fix MESSAGE_ROLE\n\n- Revert types/index.d.ts to only export legacy presenters\n- Remove 'function' from MESSAGE_ROLE to match core definition\n- Maintain build stability while preserving type unification work * feat(provider): implement factory functions for LLMCoreStreamEvent\n\n- Replace all manual event creation with createStreamEvent factory functions\n- Ensures type safety and consistent event structure\n- Updated OpenAICompatibleProvider with strong-typed events:\n - text, reasoning, toolCallStart, toolCallChunk, toolCallEnd\n - error, usage, stop, imageData events\n- All type checks passing\n- Phase 4.1 completed: Provider now outputs LLMCoreStreamEvent with factory construction * feat(provider): update OllamaProvider with factory functions\n\n- Replace all manual event creation with createStreamEvent factory functions\n- Ensures consistent tool_call_start → tool_call_chunk → tool_call_end sequence\n- Updated all event types: text, reasoning, toolCall*, usage, stop, error\n- Maintains proper tool call ID aggregation and sequencing\n- Phase 4.2 completed: Tool call sequences now strictly follow start/chunk/end pattern * docs(tasks): update Phase 4 progress\n\n- Completed Provider strong-typed event output with factory functions\n- Completed tool_call_* strict start/chunk/end sequences\n- Completed usage event sent before stop in all providers\n- Updated implementation tasks document with current progress * feat(phase4): complete Provider strong-typed event integration\n\n- Added factory functions import to AwsBedrockProvider\n- Updated error handling to use createStreamEvent.error() + createStreamEvent.stop('error')\n- Created comprehensive unit tests for LLMCoreStreamEvent factory functions\n- Tests validate: event creation, tool call sequences, error+stop patterns, type guards\n- All 12 core event tests passing ✅\n\n## Phase 4 Completed:\n- ✅ Provider strong-typed event output (factory construction)\n- ✅ tool_call_* strict start/chunk/end sequences with ID aggregation\n- ✅ Usage events sent before stop in all providers\n- ✅ Rate limit events (handled at Presenter layer)\n- ✅ Unified error + stop event patterns\n- ✅ Comprehensive unit tests for sequences/fields/boundaries * feat(phase5): complete Agent & UI alignment ## Phase 5 Completed: Agent & UI Alignment ✅ ### 1. Agent Layer Enhancement - ✅ Agent consumes only CoreEvent and outputs LLMAgentEvent - ✅ Strict separation of response/error/end event types - ✅ Added rate_limit event handling in Agent layer - ✅ Maintained proper event transformation pipeline ### 2. UI Layer Unification - ✅ Removed standalone tool_call_permission type - ✅ Unified to action + action_type pattern - ✅ Updated all UI components and thread presenter logic - ✅ Preserved backward compatibility with conditional rendering ### 3. Renderer Mapping & Testing - ✅ Created comprehensive renderer contract tests (17 tests) - ✅ Added message block data structure snapshot tests (14 tests) - ✅ Validated event-to-UI block mapping compliance - ✅ Ensured consistent status transitions and type safety ### Key Technical Achievements: - **Type Safety**: All event transformations now type-safe - **Consistency**: Unified action_type handling across codebase - **Testing**: 31 new tests covering contracts and snapshots - **Architecture**: Clean separation between Agent/UI concerns - **Quality**: All lint, format, and type checks passing ✅ ### Files Modified: - Agent layer: llmProviderPresenter/index.ts - UI components: MessageItemAssistant.vue - Thread logic: threadPresenter/index.ts - Type definitions: shared/chat.d.ts - Tests: rendererContract.test.ts, messageBlockSnapshot.test.ts Ready for Phase 6: Quality & Tools 🚀 * feat(phase6): complete Quality & Tools phase ## Phase 6 Completed: Quality & Tools ✅ ### 1. Table-Driven Contract Tests - ✅ Created comprehensive event mapping contract tests (25 test cases) - ✅ Validated all event types from architecture mapping table - ✅ Verified status transitions and type constraints - ✅ Added tool call ID aggregation and lifecycle validation - ✅ Implemented error recovery pattern testing ### 2. Performance Evaluation & Stress Testing - ✅ Large text content processing (50KB < 10ms) - ✅ Large reasoning content handling (100KB < 15ms) - ✅ Large image data processing (1MB < 20ms) - ✅ Batch image processing (100 images < 50ms) - ✅ High-frequency event processing (1000 events < 100ms) - ✅ Mixed event type handling (500 events < 80ms) - ✅ Memory leak prevention (5000 events < 500ms) - ✅ Extreme parameter handling (10KB params < 5ms) - ✅ Concurrent processing simulation (10 workers < 100ms) ### Key Technical Achievements: - **Comprehensive Testing**: 67 tests passing across all scenarios - **Performance Validation**: All benchmarks meet performance targets - **Type Safety**: Full TypeScript compliance (0 errors) - **Code Quality**: Lint and format checks passing ✅ - **Architecture Compliance**: All mapping table rules verified - **Stress Testing**: System handles extreme loads efficiently ### Test Coverage Summary: - Event mapping contract tests: 25 tests ✅ - Renderer contract tests: 17 tests ✅ - Performance evaluation tests: 9 tests ✅ - Core event factory tests: 12 tests ✅ - Message block snapshot tests: 14 tests ✅ - Shell integration tests: 8 tests ✅ ### Files Added: - test/renderer/message/eventMappingTable.test.ts (comprehensive mapping validation) - test/renderer/message/performanceEvaluation.test.ts (stress & performance testing) Ready for production deployment with full quality assurance! 🚀 * fix(providers): complete strong-typed event integration across all providers * fix(vitest): modify test case * fix: default settings * chore: update doc * fix(ci): remove duplicate check in pr ci * feat: add pnpm cache for pr check * fix(ci): pr check with pnpm cache * fix(ci): change cache key to package.json * ci: remove pnpm cache * feat: add glow breathing effect to scroll-to-bottom button (#850) * feat: add glow breathing effect to scroll-to-bottom button * fix: ensure exclusive display between MessageList and ArtifactDialog * fix: refine MessageList–ArtifactDialog interaction logic; correct z-order between dialog and ArtifactDialog * chore: prettier .vue * feat: add web search support with configurable options for dashscope (#851) * feat: add web search support with configurable options for dashscope * fix: correct qwen model parameters to match official documentation * feat: add web search support with configurable options for dashscope (#852) * feat: add web search support with configurable options for dashscope * fix: correct qwen model parameters to match official documentation * feat: add search configuration support to ChatConfig components * fix: fix enableSearch state sync and parameter passing issues * fix: preserve search settings during data import * feat: add dashscope commercial models to enable_thinking support (#853) * feat: add search capability icon for model list (#854) * feat: add search capability icon for model list * fix: clear search settings when creating new conversation * feat(markdown): Thinking panel now supports LaTeX compilation for mathematical formulas & markdown performance optimization (#857) * feat(markdown): 思考栏支持数学公式latex编译显示 & markdown 性能优化 close: #845 * chore: lint * chore(ai): update claude code rules and agents * fix(ui): revert Dialog z-index to z-50 to fix dropdown visibility Reverts DialogContent z-index from z-[100] back to z-50 to resolve issue where Select and EmojiPicker dropdowns were not appearing. This maintains proper layering hierarchy without breaking other UI components. * feat: upgrade vue-renderer-markdown & vue-use-monaco (#862) 1. ignore math-block warning 2. Compatible with the syntax issues of mermaid produced by AI, greatly reducing the probability of mermaid rendering errors * feat(dashscope): add qwen3-max-preview model (#865) * fix: mcp params support more types (#861) * feat(mcp): enhance tool parameter display with enum type support - Add enum parameter type detection and enhanced display - Show enum parameters with distinct blue badge styling (enum(string), array[enum(string)]) - Display allowed values for both direct enum and array item enum parameters - Add i18n support for "allowedValues" and "arrayItemValues" labels - Maintain consistent UI design with existing parameter display patterns - Improve developer experience when debugging MCP tools with constrained parameters * fix: enum params support * fix(context-menu): handle local file paths in image save functionality - Fix URL parsing error when saving images from local file paths - Add proper handling for http/https URLs, file:// URLs, and direct file paths - Use fs.promises for reading local files instead of net.fetch for invalid URLs - Prevent "Failed to parse URL from" error when saving local images * fix(context-menu): improve URL handling robustness in image save - Add try-catch around net.fetch to handle invalid URLs gracefully - Implement fallback methods for file:// URLs and local file paths - Add debug logging to track source URL values for troubleshooting - Prevent "Failed to parse URL from" errors with comprehensive URL validation * fix(context-menu): handle empty srcURL in image save functionality - Add comprehensive URL detection when srcURL is empty - Implement fallback URL sources (linkURL, pageURL) for better compatibility - Add debug logging to track all available context menu parameters - Prevent "Failed to parse URL from" errors caused by empty URLs - Provide clear error message when no valid URL can be found * chore: format code * fix: ai review * fix: prevent @ symbol remaining when deleting mentions (#867) * Merge commit from fork * feat: implement separated system and custom prompt management (#868) * feat: implement separated system and custom prompt management * style: code fmt * fix: add migration for legacy default_system_prompt to system_prompts * feat: add Moonshot model configurations (#869) * refactor: translate all cn comments and log to en (#871) * refactor: translate all cn comments and log to en * fix: revert translate in params * feat: add reasoning support for Grok thinking models (#873) * feat: add reasoning support for Grok thinking models * fix: code lint * fix: escaping character issue --------- Co-authored-by: zerob13 <zerob13@gmail.com> --------- Co-authored-by: hllshiro <40970081+hllshiro@users.noreply.github.com> Co-authored-by: yyhhyyyyyy <yyhhyyyyyy8@gmail.com> Co-authored-by: xiaomo <wegi866@gmail.com> Co-authored-by: Simon He <57086651+Simon-He95@users.noreply.github.com> Co-authored-by: luy <12696648@qq.com>
feat: add glow breathing effect to scroll-to-bottom button
Summary by CodeRabbit
New Features
Bug Fixes
Style