Skip to content

Fix runtime crash in SK2TransactionListener in iOS < 15#3206

Merged
tonidero merged 2 commits into
mainfrom
fix-sk2-transaction-listener-ios-14
Sep 14, 2023
Merged

Fix runtime crash in SK2TransactionListener in iOS < 15#3206
tonidero merged 2 commits into
mainfrom
fix-sk2-transaction-listener-ios-14

Conversation

@tonidero

Copy link
Copy Markdown
Contributor

Description

We found that there was another runtime crash in Capacitor in iOS < 15 similar to #3139. This applies the same fix to this new crash.

@tonidero tonidero added the pr:fix A bug fix label Sep 14, 2023
@tonidero tonidero force-pushed the fix-sk2-transaction-listener-ios-14 branch from bb1d3d6 to 9edcb00 Compare September 14, 2023 15:39
@tonidero tonidero force-pushed the fix-sk2-transaction-listener-ios-14 branch from 9edcb00 to 8b91685 Compare September 14, 2023 15:42
Comment thread Sources/Purchasing/StoreKit2/StoreKit2TransactionListener.swift Outdated
@NachoSoto

Copy link
Copy Markdown
Contributor

Thanks for taking care of this!

@tonidero tonidero marked this pull request as ready for review September 14, 2023 15:56
@tonidero tonidero requested review from a team and NachoSoto September 14, 2023 15:56

@NachoSoto NachoSoto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

@tonidero tonidero enabled auto-merge (squash) September 14, 2023 16:18
@tonidero tonidero merged commit e100bd3 into main Sep 14, 2023
@tonidero tonidero deleted the fix-sk2-transaction-listener-ios-14 branch September 14, 2023 16:19
NachoSoto pushed a commit that referenced this pull request Sep 14, 2023
**This is an automatic release.**

### Bugfixes
* Fix runtime crash in SK2TransactionListener in iOS < 15 (#3206) via
Toni Rico (@tonidero)
### Performance Improvements
* `OperationDispatcher`: add support for "long" delays (#3168) via
NachoSoto (@NachoSoto)
### Other Changes
* `Integration Tests`: add tests for ghost transfer behavior (#3135) via
NachoSoto (@NachoSoto)
* `Xcode`: removed `purchases-ios` SPM reference (#3166) via NachoSoto
(@NachoSoto)
* `Integration Tests`: another flaky failure (#3165) via NachoSoto
(@NachoSoto)
* `Integration Tests`: fix flaky test failure due to leftover
transaction (#3167) via NachoSoto (@NachoSoto)
* `Xcode 13`: removed last `Swift 5.7` checks (#3161) via NachoSoto
(@NachoSoto)
* `Integration Tests`: improve flaky tests (#3163) via NachoSoto
(@NachoSoto)
* `Codable`: improved decoding errors (#3153) via NachoSoto (@NachoSoto)
* Refactor: extract `HealthOperation` (#3154) via NachoSoto (@NachoSoto)
* `Xcode 13`: remove conditional code (#3147) via NachoSoto (@NachoSoto)
* `CircleCI`: change all jobs to use `Xcode 14.x` and replace
`xcode-install` with `xcodes` (#2421) via NachoSoto (@NachoSoto)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants