Skip to content

Integration Tests: add tests for ghost transfer behavior#3135

Merged
fire-at-will merged 6 commits into
mainfrom
ghost-transfer-integration-tests
Sep 13, 2023
Merged

Integration Tests: add tests for ghost transfer behavior#3135
fire-at-will merged 6 commits into
mainfrom
ghost-transfer-integration-tests

Conversation

@NachoSoto

@NachoSoto NachoSoto commented Sep 1, 2023

Copy link
Copy Markdown
Contributor

This is now fixed on the backend. These new tests reflect the new expected behavior.

@NachoSoto NachoSoto added the test label Sep 1, 2023
@NachoSoto NachoSoto requested a review from a team September 1, 2023 20:23
Comment thread Sources/Networking/HTTPClient/HTTPClient.swift Outdated
try await self.verifyReceiptIsEventuallyPosted()

// 6. Verify user 2 has purchases
currentCustomerInfo = try await self.purchases.customerInfo(fetchPolicy: .fetchCurrent)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't necessary, we could get the CustomerInfo returned from the last self.purchaseMonthlyOffering() call.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, updated! :D

Comment thread Sources/Networking/HTTPClient/HTTPClient.swift Outdated
@NachoSoto NachoSoto marked this pull request as ready for review September 12, 2023 21:15
@NachoSoto NachoSoto changed the title [WIP] Integration Tests: add tests for ghost transfer behavior Integration Tests: add tests for ghost transfer behavior Sep 12, 2023
@NachoSoto

Copy link
Copy Markdown
Contributor Author

If tests pass, ship it :) 🎉

@codecov

codecov Bot commented Sep 12, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: -0.09% ⚠️

Comparison is base (102cbe7) 86.62% compared to head (4696389) 86.53%.
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3135      +/-   ##
==========================================
- Coverage   86.62%   86.53%   -0.09%     
==========================================
  Files         219      219              
  Lines       15713    15713              
==========================================
- Hits        13611    13597      -14     
- Misses       2102     2116      +14     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fire-at-will fire-at-will merged commit 1072870 into main Sep 13, 2023
@fire-at-will fire-at-will deleted the ghost-transfer-integration-tests branch September 13, 2023 14:48
NachoSoto pushed a commit that referenced this pull request Sep 14, 2023
**This is an automatic release.**

### Bugfixes
* Fix runtime crash in SK2TransactionListener in iOS < 15 (#3206) via
Toni Rico (@tonidero)
### Performance Improvements
* `OperationDispatcher`: add support for "long" delays (#3168) via
NachoSoto (@NachoSoto)
### Other Changes
* `Integration Tests`: add tests for ghost transfer behavior (#3135) via
NachoSoto (@NachoSoto)
* `Xcode`: removed `purchases-ios` SPM reference (#3166) via NachoSoto
(@NachoSoto)
* `Integration Tests`: another flaky failure (#3165) via NachoSoto
(@NachoSoto)
* `Integration Tests`: fix flaky test failure due to leftover
transaction (#3167) via NachoSoto (@NachoSoto)
* `Xcode 13`: removed last `Swift 5.7` checks (#3161) via NachoSoto
(@NachoSoto)
* `Integration Tests`: improve flaky tests (#3163) via NachoSoto
(@NachoSoto)
* `Codable`: improved decoding errors (#3153) via NachoSoto (@NachoSoto)
* Refactor: extract `HealthOperation` (#3154) via NachoSoto (@NachoSoto)
* `Xcode 13`: remove conditional code (#3147) via NachoSoto (@NachoSoto)
* `CircleCI`: change all jobs to use `Xcode 14.x` and replace
`xcode-install` with `xcodes` (#2421) via NachoSoto (@NachoSoto)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants